Skip to content

Retryable responses are abandoned without canceling their bodies #204

Description

@abhinavkr26104

Description

When an HTTP response is retryable, the SDK starts the next attempt without consuming or canceling the previous response body.

The early return at src/core.ts:490-495 bypasses response.text() and does not call response.body.cancel() (or the runtime-equivalent cleanup) before retryRequest().

Reproduction

import Browserbase from '@browserbasehq/sdk';

let attempts = 0;
let cancelCalls = 0;
const client = new Browserbase({
  apiKey: 'test',
  maxRetries: 1,
  fetch: async () => {
    attempts++;
    if (attempts === 1) {
      const body = new ReadableStream({
        cancel() {
          cancelCalls++;
        },
      });
      return new Response(body, {
        status: 500,
        headers: { 'content-type': 'text/plain' },
      });
    }
    return new Response('{}', {
      status: 200,
      headers: { 'content-type': 'application/json' },
    });
  },
});

await client.get('/retry');
console.log(cancelCalls); // 0

Expected behavior

The unused body of the first response is canceled before retrying (cancelCalls === 1).

Actual behavior

The response is abandoned without cancellation (cancelCalls === 0).

Why this matters

With streaming or large error responses, abandoning the body can keep sockets and stream resources occupied, reduce connection reuse, and accumulate resources across repeated 429/5xx responses. The retry branch should explicitly cancel the body in a runtime-compatible way and test both Web and Node stream implementations.

Tested against @browserbasehq/sdk 2.18.0 / current main (b781bd7).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions