diff --git a/multiapps-controller-client/src/main/java/org/cloudfoundry/multiapps/controller/client/facade/util/RestUtil.java b/multiapps-controller-client/src/main/java/org/cloudfoundry/multiapps/controller/client/facade/util/RestUtil.java
index aba72b8fe2..8b22d95fb3 100644
--- a/multiapps-controller-client/src/main/java/org/cloudfoundry/multiapps/controller/client/facade/util/RestUtil.java
+++ b/multiapps-controller-client/src/main/java/org/cloudfoundry/multiapps/controller/client/facade/util/RestUtil.java
@@ -1,12 +1,14 @@
package org.cloudfoundry.multiapps.controller.client.facade.util;
import java.net.MalformedURLException;
+import java.net.Socket;
import java.net.URL;
import java.security.cert.X509Certificate;
import java.text.MessageFormat;
+import javax.net.ssl.SSLEngine;
import javax.net.ssl.SSLException;
-import javax.net.ssl.X509TrustManager;
+import javax.net.ssl.X509ExtendedTrustManager;
import org.springframework.http.client.reactive.ClientHttpConnector;
import org.springframework.http.client.reactive.ReactorClientHttpConnector;
@@ -17,6 +19,7 @@
import io.netty.handler.ssl.SslContext;
import io.netty.handler.ssl.SslContextBuilder;
+import io.netty.handler.ssl.SslProvider;
import reactor.netty.http.client.HttpClient;
/**
@@ -72,6 +75,7 @@ private ClientHttpConnector buildClientConnector(boolean trustSelfSignedCerts) {
private SslContext buildSslContext() {
try {
return SslContextBuilder.forClient()
+ .sslProvider(SslProvider.JDK)
.trustManager(createDummyTrustManager())
.build();
} catch (SSLException e) {
@@ -79,8 +83,8 @@ private SslContext buildSslContext() {
}
}
- private X509TrustManager createDummyTrustManager() {
- return new X509TrustManager() {
+ private X509ExtendedTrustManager createDummyTrustManager() {
+ return new X509ExtendedTrustManager() {
@Override
public void checkClientTrusted(X509Certificate[] xcs, String string) {
@@ -92,6 +96,26 @@ public void checkServerTrusted(X509Certificate[] xcs, String string) {
// NOSONAR
}
+ @Override
+ public void checkClientTrusted(X509Certificate[] xcs, String string, Socket socket) {
+ // NOSONAR
+ }
+
+ @Override
+ public void checkServerTrusted(X509Certificate[] xcs, String string, Socket socket) {
+ // NOSONAR
+ }
+
+ @Override
+ public void checkClientTrusted(X509Certificate[] xcs, String string, SSLEngine sslEngine) {
+ // NOSONAR
+ }
+
+ @Override
+ public void checkServerTrusted(X509Certificate[] xcs, String string, SSLEngine sslEngine) {
+ // NOSONAR
+ }
+
@Override
public X509Certificate[] getAcceptedIssuers() {
return new X509Certificate[] {};
diff --git a/multiapps-controller-core/src/main/java/org/cloudfoundry/multiapps/controller/core/cf/OAuthClientFactory.java b/multiapps-controller-core/src/main/java/org/cloudfoundry/multiapps/controller/core/cf/OAuthClientFactory.java
index 49549bf6ba..e09ad88690 100644
--- a/multiapps-controller-core/src/main/java/org/cloudfoundry/multiapps/controller/core/cf/OAuthClientFactory.java
+++ b/multiapps-controller-core/src/main/java/org/cloudfoundry/multiapps/controller/core/cf/OAuthClientFactory.java
@@ -6,6 +6,7 @@
import org.cloudfoundry.multiapps.controller.client.facade.util.RestUtil;
import org.cloudfoundry.multiapps.controller.client.uaa.UAAClient;
import org.cloudfoundry.multiapps.controller.core.security.token.TokenService;
+import org.cloudfoundry.multiapps.controller.core.util.ApplicationConfiguration;
@Named
public class OAuthClientFactory {
@@ -16,9 +17,11 @@ public class OAuthClientFactory {
private TokenService tokenService;
@Inject
private UAAClient uaaClient;
+ @Inject
+ private ApplicationConfiguration configuration;
public OAuthClient createOAuthClient() {
- return new OAuthClientExtended(uaaClient.getUaaUrl(), tokenService, restUtil.createWebClient(true));
+ return new OAuthClientExtended(uaaClient.getUaaUrl(), tokenService, restUtil.createWebClient(configuration.shouldSkipSslValidation()));
}
}
diff --git a/pom.xml b/pom.xml
index d588740c95..bfe74a381b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -36,8 +36,8 @@
4.33.0
5.1.0
5.16.0.RELEASE
- 1.3.6
- 4.2.15.Final
+ 1.3.7
+ 4.2.17.Final
1.6.16
2.7.0
33.5.0-jre
@@ -292,6 +292,8 @@
+
io.netty
netty-bom
${netty.version}