Skip to content

MsgpackEmitter.emitInteger() has useless bounds checks #47

Description

@puredanger

MsgpackEmitter.emitInteger() has bounds checks to handle longs outside of long range, which is impossible:

if ((i > Long.MAX_VALUE) || (i < Long.MIN_VALUE))
  ...

These conditions are always false and should be removed in both emitInteger() methods.

Metadata

Metadata

Assignees

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions