From d87aacb865ad0898a1822852962dc763edf74b26 Mon Sep 17 00:00:00 2001 From: Martin Kuntz Jacobsen Date: Mon, 16 Nov 2026 12:35:20 +0100 Subject: [PATCH 1/2] guards: shrink prose, unreferenced and test_budget allowlists to the tree (part of #12427) Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01Xut2hzwNN9Q3DFZx18pNic --- deploy/private/release/tests/BUILD.bazel | 1 - rust/private/crate_universe/extensions.bzl | 2 -- tools/ci/prose_rules_allowlist.txt | 3 +-- tools/ci/test_budget_allowlist.txt | 1 - tools/ci/unreferenced_files_allowlist.txt | 2 +- 5 files changed, 2 insertions(+), 7 deletions(-) diff --git a/deploy/private/release/tests/BUILD.bazel b/deploy/private/release/tests/BUILD.bazel index 462bd93d3c..baf80b3e9c 100644 --- a/deploy/private/release/tests/BUILD.bazel +++ b/deploy/private/release/tests/BUILD.bazel @@ -11,7 +11,6 @@ package( rust_test( name = "release_consumer_smoke_test", size = "small", - timeout = "moderate", testonly = True, srcs = [ "candidate_consumer_test.rs", diff --git a/rust/private/crate_universe/extensions.bzl b/rust/private/crate_universe/extensions.bzl index 028a6d54b0..d4f31cea94 100644 --- a/rust/private/crate_universe/extensions.bzl +++ b/rust/private/crate_universe/extensions.bzl @@ -277,7 +277,6 @@ def _generate_hub_and_spokes( ) # TODO: Repins should never be allowed if the lockfile is not within - # https://github.com/bazelbuild/rules_rust/issues/1738 # Determine whether or not to repin dependencies. Transitive (non-root) # modules are taken as-is: the digest check would fail across rust / @@ -676,7 +675,6 @@ def _filter_dict(dict): for k, v in dict.items() # Tag classes can't take in None, but the function requires None # instead of the empty values in many cases. - # https://github.com/bazelbuild/bazel/issues/20744 if v != "" and v != [] and v != {} } diff --git a/tools/ci/prose_rules_allowlist.txt b/tools/ci/prose_rules_allowlist.txt index 4738e5469e..4ea53e031a 100644 --- a/tools/ci/prose_rules_allowlist.txt +++ b/tools/ci/prose_rules_allowlist.txt @@ -1,7 +1,7 @@ .github/workflows/README.md issue-number 4 AGENTS.md history-word 2 CONTRIBUTING.md issue-number 1 -MODULE.bazel issue-number 19 +MODULE.bazel issue-number 18 README.md dead-link 1 cli/plan/src/args/invocation.rs link-chain 2 core/quality/policy.bzl link-chain 1 @@ -13,7 +13,6 @@ docs/cli/commands/init.md history-word 2 docs/github-ci.md history-word 1 docs/support-matrix.md issue-number 1 docs/tutorial.md dead-link 1 -patches/README.md history-word 1 tools/ci/prose_rules_test.rs link-chain 1 tools/docs/jvm/fixture/jvm_prose.md not-linted 1 tools/docs/python/fixture/guide.md not-linted 1 diff --git a/tools/ci/test_budget_allowlist.txt b/tools/ci/test_budget_allowlist.txt index 2049dce9a6..edb0b0abdd 100644 --- a/tools/ci/test_budget_allowlist.txt +++ b/tools/ci/test_budget_allowlist.txt @@ -225,7 +225,6 @@ deploy/private/release/matrix_tests.bzl no-size 1 deploy/private/release/notice_tests.bzl no-size 2 deploy/private/release/sbom_tests.bzl no-size 2 deploy/private/release/signing_tests.bzl no-size 1 -deploy/private/release/tests/BUILD.bazel no-size 1 deploy/private/resources_tests.bzl no-size 3 deploy/private/rubygems_tests.bzl no-size 1 deploy/private/sbom_demo/BUILD.bazel no-size 1 diff --git a/tools/ci/unreferenced_files_allowlist.txt b/tools/ci/unreferenced_files_allowlist.txt index db2598e8ee..f00ea1a8b5 100644 --- a/tools/ci/unreferenced_files_allowlist.txt +++ b/tools/ci/unreferenced_files_allowlist.txt @@ -62,7 +62,7 @@ kotlin/tests/fixtures/kotlin-app/grades/BUILD.bazel orphan-target 1 lua/private/quality/BUILD.bazel orphan-target 1 mdx/private/BUILD.bazel orphan-target 1 ocaml/private/coverage/BUILD.bazel orphan-target 1 -ocaml/private/quality/BUILD.bazel orphan-target 2 +ocaml/private/quality/BUILD.bazel orphan-target 1 perl/tests/fixtures/perl-app/cli/BUILD.bazel orphan-target 1 perl/tests/fixtures/perl-app/inventory/BUILD.bazel orphan-target 2 perl/tests/fixtures/perl-app/report/BUILD.bazel orphan-target 3 From f4fdd2bffbd007fe5b3c79edf4c62484dacb31aa Mon Sep 17 00:00:00 2001 From: Martin Kuntz Jacobsen Date: Mon, 16 Nov 2026 12:35:27 +0100 Subject: [PATCH 2/2] crate_universe: drop the truncated TODO comment (part of #12427) Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01Xut2hzwNN9Q3DFZx18pNic --- rust/private/crate_universe/extensions.bzl | 2 -- 1 file changed, 2 deletions(-) diff --git a/rust/private/crate_universe/extensions.bzl b/rust/private/crate_universe/extensions.bzl index d4f31cea94..7f15a4bccd 100644 --- a/rust/private/crate_universe/extensions.bzl +++ b/rust/private/crate_universe/extensions.bzl @@ -276,8 +276,6 @@ def _generate_hub_and_spokes( ), ) - # TODO: Repins should never be allowed if the lockfile is not within - # Determine whether or not to repin dependencies. Transitive (non-root) # modules are taken as-is: the digest check would fail across rust / # cargo / rules_rust version differences between the producing module