From e24461d935ce718314e8669117798b6b02a3b212 Mon Sep 17 00:00:00 2001 From: Alex Andres Date: Sun, 25 Oct 2026 17:52:39 +0100 Subject: [PATCH] fix: compare the recorded unicode file as a file, not a path, for macOS --- .../onvoid/webrtc/media/recorder/MediaRecorderTest.java | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/webrtc-media/src/test/java/dev/onvoid/webrtc/media/recorder/MediaRecorderTest.java b/webrtc-media/src/test/java/dev/onvoid/webrtc/media/recorder/MediaRecorderTest.java index 05b55f29..96566b9a 100644 --- a/webrtc-media/src/test/java/dev/onvoid/webrtc/media/recorder/MediaRecorderTest.java +++ b/webrtc-media/src/test/java/dev/onvoid/webrtc/media/recorder/MediaRecorderTest.java @@ -25,7 +25,6 @@ import java.io.IOException; import java.nio.file.Files; import java.nio.file.Path; -import java.util.Collections; import java.util.List; import java.util.concurrent.CopyOnWriteArrayList; import java.util.concurrent.CountDownLatch; @@ -184,7 +183,13 @@ void recordsIntoPathBeyondBasicPlane() throws Exception { assertNull(listener.error.get()); try (Stream files = Files.list(dir)) { - assertEquals(Collections.singletonList(file), files.collect(Collectors.toList())); + List written = files.collect(Collectors.toList()); + + // Compared as files, not as paths: on macOS Java holds the name + // decomposed (ΓΌ as u and a diaeresis), while FFmpeg writes it as + // given, and the file system finds the file by either form. + assertEquals(1, written.size(), () -> "Written: " + written); + assertTrue(Files.isSameFile(file, written.get(0)), () -> "Written: " + written); } assertEquals("vp8", readInfo(file).getVideoCodec());