From 1fb675130b3d3b3a91b05cbc13d30a62429d9eb7 Mon Sep 17 00:00:00 2001 From: Davide Angelocola Date: Thu, 16 Jul 2026 19:00:08 +0200 Subject: [PATCH] fix: RaincloudSizeComparisonIntegrationTest.corpusIsHydrated skips instead of failing Used assertTrue (hard fail) instead of assumeTrue (visible skip) when the corpus isn't hydrated, contradicting its own class javadoc and the established pattern in RaincloudConformanceIntegrationTest.corpusIsHydrated. Broke ubuntu/macos CI on every run since the corpus isn't hydrated there. Co-Authored-By: Claude Sonnet 5 --- .../integration/RaincloudSizeComparisonIntegrationTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/integration/src/test/java/io/github/dfa1/vortex/integration/RaincloudSizeComparisonIntegrationTest.java b/integration/src/test/java/io/github/dfa1/vortex/integration/RaincloudSizeComparisonIntegrationTest.java index b8111a5a..4269d494 100644 --- a/integration/src/test/java/io/github/dfa1/vortex/integration/RaincloudSizeComparisonIntegrationTest.java +++ b/integration/src/test/java/io/github/dfa1/vortex/integration/RaincloudSizeComparisonIntegrationTest.java @@ -12,7 +12,7 @@ import java.nio.file.Path; import java.util.stream.Stream; -import static org.junit.jupiter.api.Assertions.assertTrue; +import static org.junit.jupiter.api.Assumptions.assumeTrue; /// File-size comparison across the Raincloud corpus for three representations: /// Parquet (corpus oracle), vortex-jni (corpus file, written by Rust Vortex), and @@ -33,7 +33,7 @@ class RaincloudSizeComparisonIntegrationTest { @Test void corpusIsHydrated() { // Given / When / Then — visible skip marker when the corpus is absent - assertTrue(Files.exists(manifestPath()), + assumeTrue(Files.exists(manifestPath()), "raincloud corpus not hydrated — run scripts/hydrate-raincloud-corpus.sh"); }