From d2f115774e32f13fef69e72c9671b2e3c1a2dc5d Mon Sep 17 00:00:00 2001 From: Will Ezell Date: Wed, 16 Sep 2026 22:15:15 -0400 Subject: [PATCH 1/3] chore(core): remove pgjdbc-ng and PostgresPubSubImpl (#37592) PostgresPubSubImpl was superseded by JDBCPubSubImpl (vanilla postgres driver, #26019) and DotPubSubProviderLocator has defaulted to it since. Nothing in the repo sets DOT_PUBSUB_PROVIDER_OVERRIDE to PostgresPubSubImpl, so the pgjdbc-ng code path was unreachable. pgjdbc-ng was the only remaining compile-scope, non-Azure/non-AWS source of Netty on the classpath, transitively bringing Netty 4.1.63 while langchain4j-azure-open-ai brought 4.1.118. Changes: - Delete PostgresPubSubImpl, PgNgDataSourceUrl and their tests - Deregister PostgresPubSubImplTest from MainSuite2a/MainSuite2b - Drop the pgjdbc-ng dependency from dotCMS/pom.xml and bom/application - Replace the codebase's only Netty import (io.netty.util.NetUtil in HttpRequestDataUtil#getIpAddress) with Guava InetAddresses.forString; Guava is already a direct compile dependency. The `throws UnknownHostException` signature is preserved because callers catch it. - Keep the six Netty BOM pins; Azure/reactor-netty still ship 4.1.112 vs 4.1.118 skew, and AWS still pulls 4.1.130. Update the stale comment. Netty remains on the classpath via azure-core-http-netty and the AWS SDK sqs netty-nio-client; only the 4.1.63 line disappears. --- bom/application/pom.xml | 11 +- dotCMS/pom.xml | 5 - .../dotcms/dotpubsub/PgNgDataSourceUrl.java | 89 ------ .../dotcms/dotpubsub/PostgresPubSubImpl.java | 292 ------------------ .../com/dotcms/util/HttpRequestDataUtil.java | 17 +- .../transport/PubSubCacheTransportTest.java | 2 +- .../dotpubsub/PgNgDataSourceUrlTest.java | 98 ------ .../src/test/java/com/dotcms/MainSuite2a.java | 1 - .../src/test/java/com/dotcms/MainSuite2b.java | 2 - .../dotpubsub/PostgresPubSubImplTest.java | 256 --------------- 10 files changed, 17 insertions(+), 756 deletions(-) delete mode 100644 dotCMS/src/main/java/com/dotcms/dotpubsub/PgNgDataSourceUrl.java delete mode 100644 dotCMS/src/main/java/com/dotcms/dotpubsub/PostgresPubSubImpl.java delete mode 100644 dotCMS/src/test/java/com/dotcms/dotpubsub/PgNgDataSourceUrlTest.java delete mode 100644 dotcms-integration/src/test/java/com/dotcms/dotpubsub/PostgresPubSubImplTest.java diff --git a/bom/application/pom.xml b/bom/application/pom.xml index 19738ee7501c..d8356a327ad1 100644 --- a/bom/application/pom.xml +++ b/bom/application/pom.xml @@ -100,8 +100,9 @@ 3.4.41 - + io.netty netty-common @@ -847,12 +848,6 @@ - - com.impossibl.pgjdbc-ng - pgjdbc-ng - 0.8.9 - - + io.netty - netty-common - 4.1.118.Final - - - io.netty - netty-buffer - 4.1.118.Final - - - io.netty - netty-transport - 4.1.118.Final - - - io.netty - netty-resolver - 4.1.118.Final - - - io.netty - netty-codec - 4.1.118.Final - - - io.netty - netty-handler - 4.1.118.Final + netty-bom + ${netty.version} + pom + import