Migrate test suite from JUnit 4 to JUnit 5

[marioserrano09]

Goal

Migrate all tests in the monorepo (platform/, extensions/, examples/) from JUnit 4 to JUnit 5 (Jupiter).

Scope

• Root pom.xml: replace the junit:junit dependency with junit-jupiter (version managed by the already-imported spring-boot-dependencies BOM).
• Review extension poms that declare JUnit explicitly (finances/http-functions/saas have their own poms).
• Migrate ~90 test classes: annotations (@test, @Before->@beforeeach, @After->@AfterEach, @BeforeClass->@BeforeAll, @AfterClass->@afterall), org.junit.* imports -> org.junit.jupiter.api., Assert. -> Assertions.*, @ignore->@disabled, JUnit4 rules (@Rule/ExpectedException) -> assertThrows, runners (@RunWith) -> @ExtendWith.
• Verify compatibility with Mockito/Spring Boot Test where applicable.
• Produce a list of recommended additional tests (coverage gap analysis) per module.

Branch

chore/junit5-migration (from origin/main)

🤖 Generated with Claude Code

[marioserrano09]

Migration completed in PR #77. All modules compile and tests pass (includes a pre-existing bug found and fixed: CrudServiceRestTest silently ran 0 tests before this migration due to a missing vintage engine in Surefire — see details in the PR).

[marioserrano09]

Recommended additional tests (coverage gap analysis)

Based on the module-by-module review done during the JUnit 5 migration.

platform/app

• CrudServiceRestTest only covers the happy path of findAll(). Missing: create/update/delete through AbstractCrudServiceRestController, response for a non-existent entity (404), and ValidationError propagated as an HTTP response.

platform/core/domain / domain-jpa

• InMemoryCrudServiceTest doesn't cover pagination (DataPaginator) combined with filters, nor multi-field sorting.
• JpaCrudServiceTest doesn't cover executeQuery with having + groupBy on more than one field, nor transactional rollback behavior (exception inside executeWithinTransaction).
• Missing test for JpaCrudService.batchUpdate with conditions that match no rows (0 affected rows).

platform/core/integration/reactive (Reactive)

• No test for an effect() that throws inside the callback (is it propagated? isolated?).
• No test for circular dependencies between Computed values (should fail or be detected).
• Missing test for cleanup/disposal of an effect() (if an "unsubscribe" API exists).

platform/core/commons (ops.PropertyAccessor)

• No test for invokeSetMethod with incompatible numeric types (e.g. passing an unparseable String to an int setter) — does it throw a clear exception or fail silently?
• Missing test with nested properties (invokeSetMethod(bean, "address.city", ...)) if the API supports it.

extensions/entity-files (Buckie/S3)

• BuckieEntityFileStorageTest: the real upload/delete/download tests (Assumptions.assumeTrue(isServerReachable())) are always skipped in CI without an SFS server — consider a RestClient stub/mock to cover those paths without external infrastructure (today they depend 100% on a real server being reachable).
• Missing test for getFileName with an empty filename or extension-only (.pdf).

extensions/saas/migration

• EntityDependencyGraphTest doesn't cover dependency cycles between entities (A→B→A) — topologicalSort should document/test what happens (exception, arbitrary order, stack overflow?).
• GzipStreamTest doesn't cover a corrupted/truncated ZIP file (error handling).
• No test for AccountMigrationJob with a partial failure (some entities export fine, others throw) — is the migration atomic or partial?
• Uuid7IdentityMapperTest/KeepIdsIdentityMapperTest don't cover ID collisions across different accounts in the same import.

extensions/http-functions

• DynamiaHttpFunctionsServiceImplTest doesn't cover outgoing HTTP call timeouts or retries.
• Missing test for an inactive function (FunctionInactiveException) invoked concurrently (race condition while deactivating during execution).

Cross-cutting

• No module has JSON serialization/deserialization tests for the entities exposed over REST (DynamiaHttpFunction, PersonEntity, etc.) — important before exposing these as public contracts.
• No concurrency tests for Containers/SimpleObjectContainer (simultaneous register/lookup from multiple threads).

---

🤖 Generated with Claude Code