From 9b13aba79cac200cce6b24df50773e9b3d0f38b9 Mon Sep 17 00:00:00 2001 From: Quang Truong Date: Tue, 29 Sep 2026 14:55:07 +0200 Subject: [PATCH] Fix wrong parameter, return typ --- .../cef/handlers/BrowserProcessHandler.java | 4 ++-- .../set/browser/cef/handlers/CookieVisitor.java | 2 +- .../cef/handlers/browser/DownloadHandler.java | 15 +++++++++------ .../cef/handlers/browser/JSDialogHandler.java | 2 +- .../cef/handlers/browser/LifeSpanHandler.java | 2 +- 5 files changed, 14 insertions(+), 11 deletions(-) diff --git a/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/BrowserProcessHandler.java b/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/BrowserProcessHandler.java index b225c9a0..6c1b118c 100644 --- a/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/BrowserProcessHandler.java +++ b/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/BrowserProcessHandler.java @@ -37,11 +37,11 @@ public long get() { @SuppressWarnings({ "static-method", "unused" }) // Called from JNI private void on_schedule_message_pump_work( - final long pbrowserProcessHandler, final long delay) { + final long pbrowserProcessHandler, final int delay) { if (ChromiumStatic.browsers.get() <= 0 || ChromiumStatic.disposingAny > 0) { return; } - ChromiumStatic.getMessageLoop().scheduleMessagePumpWork((int) delay); + ChromiumStatic.getMessageLoop().scheduleMessagePumpWork(delay); } } \ No newline at end of file diff --git a/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/CookieVisitor.java b/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/CookieVisitor.java index 35ac35c7..4d90d45c 100644 --- a/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/CookieVisitor.java +++ b/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/CookieVisitor.java @@ -60,7 +60,7 @@ public void getCookie() { @SuppressWarnings("unused") private int visit(final long self, final long cefcookie, final int count, - final int total, final int delete) { + final int total, final long delete) { final String name = cef_cookie_visitor_t .cefswt_cookie_to_java(cefcookie); if (WebBrowser.CookieName != null diff --git a/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/browser/DownloadHandler.java b/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/browser/DownloadHandler.java index e001036d..873829ea 100644 --- a/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/browser/DownloadHandler.java +++ b/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/browser/DownloadHandler.java @@ -54,16 +54,19 @@ private int can_download(final long download_handler, final long id, } @SuppressWarnings({ "unused" }) // Called from JNI - private void on_before_download(final long download_handler, final long id, + private int on_before_download(final long download_handler, final long id, final long download_item, final long suggested_name, final long callback) { final Optional optPath = browser.getDownloadListener() .beforeDownload( ChromiumLib.cefswt_cefstring_to_java(suggested_name), cef_download_item_t.get_url(download_item)); - - optPath.ifPresent(path -> cef_download_item_t.before_download_callback( - callback, path.toAbsolutePath().toString())); + if (optPath.isPresent()) { + cef_download_item_t.before_download_callback(callback, + optPath.get().toAbsolutePath().toString()); + return 1; + } + return 0; } @SuppressWarnings({ "unused" }) // Called from JNI @@ -76,8 +79,8 @@ private void on_download_updated(final long download_handler, final long id, if (complete || cancelled) { final String path = cef_download_item_t .get_full_path(download_item); - browser.getDownloadListener().downloadFinished(!cancelled, - Path.of(path)); + browser.getDownloadListener() + .downloadFinished(!cancelled, Path.of(path)); } } diff --git a/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/browser/JSDialogHandler.java b/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/browser/JSDialogHandler.java index 120839b9..4ab8095d 100644 --- a/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/browser/JSDialogHandler.java +++ b/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/browser/JSDialogHandler.java @@ -58,7 +58,7 @@ private void on_dialog_closed(final long self_, final long id) { private int on_jsdialog(final long self_, final long id, final long origin_url, final int dialog_type, final long message_text, final long default_prompt_text, - final long callback, final int suppress_message) { + final long callback, final long suppress_message) { return browser.on_jsdialog(origin_url, dialog_type, message_text, default_prompt_text, callback); } diff --git a/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/browser/LifeSpanHandler.java b/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/browser/LifeSpanHandler.java index da1e4e89..34f45960 100644 --- a/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/browser/LifeSpanHandler.java +++ b/java/org.eclipse.set.browser/src/org/eclipse/set/browser/cef/handlers/browser/LifeSpanHandler.java @@ -83,7 +83,7 @@ private void on_before_close(final long plifeSpanHandler, @SuppressWarnings("unused") // Called from JNI private int on_before_popup(final long self, final long id, - final long frame, final long target_url, + final long frame, final int popupId, final long target_url, final long target_frame_name, final int target_disposition, final int user_gesture, final long popupFeaturesPtr, final long windowInfo, final long client, final long settings,