Skip to content

Commit 46d540f

Browse files
committed
TASK-197: Record approved HTTP/3 parity validation and follow-ups
Validate the complete TASK-197 diff against 05e5e89 with eight approving reviews. Persist three nonblocking fixture-readability findings without changing runtime code. Verify 2,683 retained artifact hashes and 20 equivalent retained libraries; reuse the unchanged 44 installed H3/H2/TCP TLS cells, 674 normal/ASan/TSan owner tests and all nine transport gate stages. Refresh 87 Python contract tests with no skips; diff checks pass. Nonlocal platform checks remain CI-owned.
1 parent dd82c9b commit 46d540f

1 file changed

Lines changed: 21 additions & 0 deletions

File tree

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# Unworked Review Issues
2+
3+
**Run:** 2026-10-13 20:35:41
4+
**Task:** TASK-197
5+
**Total:** 3 (0 critical, 1 major, 2 minor)
6+
7+
## Major
8+
9+
1. [ ] **code-simplifier** | `scripts/test-v3-public-http3.py:41` | code-structure
10+
The matrix fixture builds every scenario payload through one deeply nested conditional expression on a single line. This hides the mapping between a case and its expected fields, making later contract additions and corrections difficult to review.
11+
*Recommendation:* Extract named helpers for the distinct payload families (lifecycle, WebSocket, semantic parity, credentials, and mTLS), then keep the matrix comprehension focused on assembling cells. Preserve the existing expected values and scenario coverage.
12+
13+
## Minor
14+
15+
2. [ ] **code-quality-reviewer** | `scripts/test-v3-public-http3.py:41` | readability
16+
Contracts.matrix builds every configuration family in one long expression containing nested comprehensions and chained conditional expressions. The added lifecycle, credential, mTLS and WebSocket branches make the otherwise useful fail-closed test fixture difficult to inspect and extend independently.
17+
*Recommendation:* Optionally extract a configuration_row(case) helper with explicit family branches and small observation helpers, then keep matrix() responsible only for assembling cells. Preserve the existing malformed-receipt tests.
18+
19+
3. [ ] **test-quality-reviewer** | `scripts/test-v3-public-http3.py:35` | excessive-setup
20+
Contracts.matrix constructs all nested semantic, credential, QPACK, flow and WebSocket observations in one long conditional comprehension, making the starting valid receipt difficult to inspect when a negative contract case fails.
21+
*Recommendation:* Split the valid receipt construction into small named family builders and compose each cell explicitly, retaining the existing targeted mutations and assertions.

0 commit comments

Comments
 (0)