Enforce strict ESLint block formatting (#185)

* Enforce strict ESLint block formatting

* Trim incidental type formatting and test formatter stability

* Run ESLint fixes in the documented formatting workflow

* Remove ESLint policy tests and dedicated test wiring

Author: niemyjski

AGENTS.md

@@ -32,7 +32,7 @@ npm test
 # Lint (ESLint + Prettier check)
 npm run lint
 
-# Auto-format with Prettier
+# Auto-format with ESLint fixes followed by Prettier
 npm run format
 
 # Clean all build outputs
@@ -107,7 +107,7 @@ All framework packages (`react`, `vue`, `angularjs`) depend on `browser`, which
 
 ### Style & Formatting
 
-- Run `npm run format` (Prettier) to auto-format code
+- Run `npm run format` (ESLint fixes followed by Prettier) to auto-format code
 - Run `npm run lint` (ESLint + Prettier check) to verify
 - Match existing file style; minimize diffs
 - No code comments unless necessary—code should be self-explanatory

eslint.config.mjs

@@ -1,11 +1,14 @@
 import eslint from "@eslint/js";
+import stylistic from "@stylistic/eslint-plugin";
 import { defineConfig } from "eslint/config";
 import eslintConfigPrettier from "eslint-config-prettier";
 import vitest from "@vitest/eslint-plugin";
 import tseslint from "typescript-eslint";
 
 export default defineConfig(
-  { ignores: ["**/dist/", "**/node_modules/", ".agents/", "example/", "**/expo-plugin/", "**/react-native.config.*"] },
+  {
+    ignores: ["**/dist/", "**/node_modules/", ".agents/", "example/", "**/expo-plugin/", "**/react-native.config.*"]
+  },
   eslint.configs.recommended,
   {
     extends: tseslint.configs.recommendedTypeChecked,
@@ -27,11 +30,52 @@ export default defineConfig(
       "@typescript-eslint/no-duplicate-type-constituents": "off",
       "@typescript-eslint/restrict-plus-operands": "off",
       "@typescript-eslint/no-unused-vars": "error",
-      "@typescript-eslint/no-unused-expressions": ["error", { allowShortCircuit: true }],
-      "@typescript-eslint/no-misused-promises": ["error", { checksVoidReturn: false }]
+      "@typescript-eslint/no-unused-expressions": [
+        "error",
+        {
+          allowShortCircuit: true
+        }
+      ],
+      "@typescript-eslint/no-misused-promises": [
+        "error",
+        {
+          checksVoidReturn: false
+        }
+      ]
     }
   },
   eslintConfigPrettier,
+  {
+    plugins: {
+      "@stylistic": stylistic
+    },
+    rules: {
+      curly: ["error", "all"],
+      "@stylistic/object-curly-newline": [
+        "error",
+        {
+          ObjectExpression: {
+            minProperties: 1
+          }
+        }
+      ],
+      "@stylistic/brace-style": [
+        "error",
+        "1tbs",
+        {
+          allowSingleLine: false
+        }
+      ],
+      "padding-line-between-statements": [
+        "error",
+        {
+          blankLine: "always",
+          prev: "block-like",
+          next: ["if", "while", "for", "do"]
+        }
+      ]
+    }
+  },
   {
     files: ["**/test/**/*.ts"],
     plugins: vitest.configs.recommended.plugins,

package-lock.json

@@ -11,7 +11,7 @@
     "lint:eslint": "eslint .",
     "lint:prettier": "prettier --check .",
     "lint:fix": "eslint . --fix",
-    "format": "prettier --write .",
+    "format": "npm run lint:fix && prettier --write .",
     "test": "vitest run",
     "test:watch": "vitest",
     "version": "npm --no-git-tag-version --workspaces=true version",
@@ -30,6 +30,7 @@
   ],
   "devDependencies": {
     "@eslint/js": "^10.0.1",
+    "@stylistic/eslint-plugin": "^5.10.0",
     "@vitest/eslint-plugin": "^1.6.19",
     "eslint": "^10.4.1",
     "eslint-config-prettier": "^10.1.8",

package.json

@@ -59,7 +59,9 @@ export class BrowserErrorPlugin implements IEventPlugin {
 
       const items: ParameterInfo[] = [];
       for (const param of params) {
-        items.push({ name: param });
+        items.push({
+          name: param
+        });
       }
 
       return items;

packages/browser/src/plugins/BrowserErrorPlugin.ts

@@ -90,6 +90,7 @@ export class BrowserGlobalHandlerPlugin implements IEventPlugin {
         if (errorName) {
           name = errorName;
         }
+
         if (errorMessage) {
           msg = errorMessage;
         }

packages/browser/src/plugins/BrowserGlobalHandlerPlugin.ts

@@ -56,7 +56,11 @@ describe("BrowserErrorPlugin", () => {
       const error = {
         someProperty: "Test"
       };
-      await processError(new Error("Error With Cause", { cause: error }));
+      await processError(
+        new Error("Error With Cause", {
+          cause: error
+        })
+      );
       const additionalData = getAdditionalData(context.event);
       expect(additionalData).not.toBeNull();
       expect(additionalData?.cause).toStrictEqual(error);

packages/browser/test/plugins/BrowserErrorPlugin.test.ts

@@ -22,7 +22,13 @@ describe("BrowserIgnoreExtensionErrorsPlugin", () => {
     const eventContext = new EventContext();
     eventContext.setException(error);
 
-    const context = new EventPluginContext(client, { type: "error" }, eventContext);
+    const context = new EventPluginContext(
+      client,
+      {
+        type: "error"
+      },
+      eventContext
+    );
 
     await plugin.run(context);
     return context;

packages/browser/test/plugins/BrowserIgnoreExtensionErrorsPlugin.test.ts

@@ -87,7 +87,13 @@ export class EventBuilder {
   public setUserIdentity(identity: string): EventBuilder;
   public setUserIdentity(identity: string, name: string): EventBuilder;
   public setUserIdentity(userInfoOrIdentity: UserInfo | string, name?: string): EventBuilder {
-    const userInfo = typeof userInfoOrIdentity !== "string" ? userInfoOrIdentity : { identity: userInfoOrIdentity, name };
+    const userInfo =
+      typeof userInfoOrIdentity !== "string"
+        ? userInfoOrIdentity
+        : {
+            identity: userInfoOrIdentity,
+            name
+          };
     if (!userInfo || (!userInfo.identity && !userInfo.name)) {
       return this;
     }
@@ -121,7 +127,9 @@ export class EventBuilder {
    */
   public setManualStackingInfo(signatureData: Record<string, string>, title?: string): EventBuilder {
     if (signatureData) {
-      const stack: ManualStackingInfo = { signature_data: signatureData };
+      const stack: ManualStackingInfo = {
+        signature_data: signatureData
+      };
       if (title) {
         stack.title = title;
       }
@@ -139,7 +147,9 @@ export class EventBuilder {
    */
   public setManualStackingKey(manualStackingKey: string, title?: string): EventBuilder {
     if (manualStackingKey) {
-      const data = { ManualStackingKey: manualStackingKey };
+      const data = {
+        ManualStackingKey: manualStackingKey
+      };
       this.setManualStackingInfo(data, title);
     }
 

packages/core/src/EventBuilder.ts

@@ -195,7 +195,13 @@ export class ExceptionlessClient {
   }
 
   public createEvent(context?: EventContext): EventBuilder {
-    return new EventBuilder({ date: new Date() }, this, context);
+    return new EventBuilder(
+      {
+        date: new Date()
+      },
+      this,
+      context
+    );
   }
 
   /**
@@ -264,7 +270,10 @@ export class ExceptionlessClient {
       return;
     }
 
-    const userDescription: UserDescription = { email_address: email, description };
+    const userDescription: UserDescription = {
+      email_address: email,
+      description
+    };
     const response = await this.config.services.submissionClient.submitUserDescription(referenceId, userDescription);
     if (!response.success) {
       this.config.services.log.error(`Failed to submit user email and description for event "${referenceId}": ${response.status} ${response.message}`);