From 64e2905a2343766240d294c00c7a2687961e08e5 Mon Sep 17 00:00:00 2001 From: Ben Hoffman Date: Sat, 15 Aug 2026 22:37:33 -0400 Subject: [PATCH 1/3] Update spdlog submodule to v1.17.0 The flingengine/spdlog fork's v1.x branch was already synced with upstream gabime/spdlog, but was missing the release tags after v1.3.1. Pushed the missing tags (v1.4.0-v1.17.0) to the fork and bumped the submodule pin to the latest stable release. Co-Authored-By: Claude Sonnet 5 --- external/spdlog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/external/spdlog b/external/spdlog index a7148b71..79524ddd 160000 --- a/external/spdlog +++ b/external/spdlog @@ -1 +1 @@ -Subproject commit a7148b718ea2fabb8387cb90aee9bf448da63e65 +Subproject commit 79524ddd08a4ec981b7fea76afd08ee05f83755d From 8082dc315ddea21363311f951497c1bd306a3fb2 Mon Sep 17 00:00:00 2001 From: Ben Hoffman Date: Sat, 15 Aug 2026 22:39:05 -0400 Subject: [PATCH 2/3] Fix VkResult logging for stricter fmt v12 enum formatting spdlog v1.17.0 bundles fmt v12, which no longer implicitly formats arbitrary enums like VkResult. Cast to int in VK_CHECK_RESULT so the build keeps working with the upgraded submodule. Co-Authored-By: Claude Sonnet 5 --- FlingEngine/Graphics/inc/GraphicsHelpers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FlingEngine/Graphics/inc/GraphicsHelpers.h b/FlingEngine/Graphics/inc/GraphicsHelpers.h index 38eee371..caadae1c 100644 --- a/FlingEngine/Graphics/inc/GraphicsHelpers.h +++ b/FlingEngine/Graphics/inc/GraphicsHelpers.h @@ -11,7 +11,7 @@ VkResult res = (f); \ if (res != VK_SUCCESS) \ { \ - F_LOG_ERROR("VkResult is {} in {} at line {}", res, __FILE__, __LINE__); \ + F_LOG_ERROR("VkResult is {} in {} at line {}", static_cast(res), __FILE__, __LINE__); \ assert(res == VK_SUCCESS); \ } \ } From 096de95af857506a3ee4c581238493029872bfaa Mon Sep 17 00:00:00 2001 From: Ben Hoffman Date: Sun, 16 Aug 2026 08:06:23 -0400 Subject: [PATCH 3/3] Enable MSVC /utf-8 so spdlog 1.17's bundled fmt can compile. Co-authored-by: Cursor --- CMakeLists.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index fe3bd865..d8d51d88 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -80,6 +80,11 @@ if( MSVC ) SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /MP") SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /MP") endif() + + # spdlog 1.17+ bundles fmt v12, which requires UTF-8 source encoding on MSVC. + # See https://github.com/fmtlib/fmt/pull/4159 + SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /utf-8") + SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /utf-8") # GCC elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")