To unblock the analyze CI after the stable Flutter 3.47.0 upgrade (#1088), five diagnostics newly reported by the Dart 3.13.0 analyzer were temporarily suppressed in the root analysis_options.yaml instead of modifying code. Each suppression is marked with a TODO(jsuya): Different from flutter/packages comment referencing this issue.
This issue tracks re-enabling them. Each task below removes one suppression after fixing the affected package(s) in a follow-up PR.
Tasks
1. use_super_parameters — google_maps_flutter
2. collection_methods_unrelated_type — tizen_bundle
3. strict_top_level_inference — video_player_avplay, video_player_videohole
4. unintended_html_in_doc_comment — in_app_purchase
Deferred upstream settings (repo-wide migrations)
The following settings from the upstream flutter/packages analysis_options.yaml are also disabled with the same TODO markers. They require repo-wide migration rather than per-package fixes.
5. omit_obvious_local_variable_types — repo-wide
6. formatter: page_width: 100 — repo-wide
To unblock the analyze CI after the stable Flutter 3.47.0 upgrade (#1088), five diagnostics newly reported by the Dart 3.13.0 analyzer were temporarily suppressed in the root
analysis_options.yamlinstead of modifying code. Each suppression is marked with aTODO(jsuya): Different from flutter/packagescomment referencing this issue.This issue tracks re-enabling them. Each task below removes one suppression after fixing the affected package(s) in a follow-up PR.
Tasks
1.
use_super_parameters— google_maps_fluttersuper.key(19 files underexample/lib/), then re-enable the rule.2.
collection_methods_unrelated_type— tizen_bundleexample/integration_test/tizen_bundle_test.dartare false positives from intentional null-handling tests (bundle[null],bundle.remove(null)). Add// ignore: collection_methods_unrelated_typeto those lines (first-party code), then re-enable the rule.3.
strict_top_level_inference— video_player_avplay, video_player_videoholevoid _afterFrameLayout(Duration _)inlib/video_player.dart), then re-enable the rule.4.
unintended_html_in_doc_comment— in_app_purchaselib/src/in_app_purchase_tizen_platform.dart(Map<Object?, Object?>?→`Map<Object?, Object?>?`), then re-enable the rule.Deferred upstream settings (repo-wide migrations)
The following settings from the upstream flutter/packages
analysis_options.yamlare also disabled with the same TODO markers. They require repo-wide migration rather than per-package fixes.5.
omit_obvious_local_variable_types— repo-widealways_specify_typesstyle (hundreds of violations), then enable the rule.6.
formatter: page_width: 100— repo-wide