Skip to content

Port Deno E2E test apps to span streaming #23812

Description

@andreiborza

Port these E2E test applications to span streaming (4 apps).

deno-streamed carries no traceLifecycle pin; check whether it is already the streamed reference for this group.

Apps

  • deno
  • deno-mysql
  • deno-pg
  • deno-redis

What to do

For each app:

  1. Remove the traceLifecycle: 'static' pin added in test(e2e): Disable span streaming in e2e test applications #22590 from src/app.ts.
  2. Rewrite the specs from transaction envelopes to span v2:
    • waitForTransaction becomes waitForStreamedSpan / waitForStreamedSpans
    • event.transaction becomes span.name
    • contexts.trace.op becomes getSpanOp(span) plus span.is_segment
    • contexts.trace.data['x'] becomes span.attributes['x'], which has the shape { value, type }
    • transaction_info.source becomes the sentry.segment.name.source attribute
  3. Streamed child spans arrive across several envelopes, so use collectStreamedSpans wherever a test asserts on children of a segment span.

The db apps are directly affected by the low-cardinality db span names (mysql, postgres, redis), so their span name assertions have to change.

Reference app: nextjs-16-streaming. Worked example: #23797.

Keep static trace lifecycle coverage

Before porting this group, duplicate deno as-is into deno-static and leave that copy on the current transaction-based specs. That keeps the static trace lifecycle covered once the rest of the group moves to streaming.

The copy is verbatim; only the app name changes:

  • package.json -> name
  • start-event-proxy.mjs -> proxyServerName
  • every waitForTransaction / waitForError / waitForSession call in tests/

Keep traceLifecycle: 'static' in the copy's Sentry.init calls. The e2e matrix discovers apps by directory, so no CI config change is needed.

The representative is a suggestion: swap it if another app in the list exercises more of this SDK's instrumentation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    TaskjavascriptPull requests that update javascript code

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions