diff --git a/api/golang/basics-of-authentication/README.md b/api/golang/basics-of-authentication/README.md index e2c028622..dd43f73cc 100644 --- a/api/golang/basics-of-authentication/README.md +++ b/api/golang/basics-of-authentication/README.md @@ -27,4 +27,4 @@ This command will run the server at `localhost:4567`. Visit `http://localhost:45 If you should get any errors while redirecting to GitHub, double check your environmental variables and the callback URL you set while registering your OAuth app. -[basics of auth]: http://developer.github.com/guides/basics-of-authentication/ +[basics of auth]: https://docs.github.com/en/apps/oauth-apps/building-oauth-apps/authenticating-to-the-rest-api-with-an-oauth-app diff --git a/api/java/deployment/README.md b/api/java/deployment/README.md index 54f39e68d..0930bf468 100644 --- a/api/java/deployment/README.md +++ b/api/java/deployment/README.md @@ -2,7 +2,7 @@ A sample implementation for using GitHub Deployment API. -Ported [this](https://developer.github.com/guides/delivering-deployments/) by Java. Powered by [Spark](http://sparkjava.com/). +Ported [this](https://docs.github.com/en/rest/guides/delivering-deployments) by Java. Powered by [Spark](http://sparkjava.com/). ## Prerequisite - JDK8 @@ -36,4 +36,4 @@ Then you can see it works on `http://localhost:4567`. After you make sure this sever deployed a place where GitHub can reach out to, you can test how it interacts with GitHub via its Deployment API. -You can also place it on your local pc, then expose it by using ngrok. Please refer the direction described [here](https://developer.github.com/guides/delivering-deployments/). +You can also place it on your local pc, then expose it by using ngrok. Please refer the direction described [here](https://docs.github.com/en/rest/guides/delivering-deployments). diff --git a/api/ruby/basics-of-authentication/README.md b/api/ruby/basics-of-authentication/README.md index e96723fbb..271ee7956 100644 --- a/api/ruby/basics-of-authentication/README.md +++ b/api/ruby/basics-of-authentication/README.md @@ -16,5 +16,5 @@ For the correct server, enter `ruby advanced_server.rb` on the command line. Both commands will run the server at `localhost:4567`. -[basics of auth]: http://developer.github.com/guides/basics-of-authentication/ +[basics of auth]: https://docs.github.com/en/apps/oauth-apps/building-oauth-apps/authenticating-to-the-rest-api-with-an-oauth-app [bundler]: http://gembundler.com/ diff --git a/api/ruby/rendering-data-as-graphs/README.md b/api/ruby/rendering-data-as-graphs/README.md index dd43068a2..47a75c172 100644 --- a/api/ruby/rendering-data-as-graphs/README.md +++ b/api/ruby/rendering-data-as-graphs/README.md @@ -9,5 +9,5 @@ To run these projects, make sure you have [Bundler][bundler] installed; then typ Then, enter `bundle exec rackup -p 4567` on the command line. -[rendering data]: http://developer.github.com/guides/rendering-data-as-graphs/ +[rendering data]: https://docs.github.com/en/rest/guides/rendering-data-as-graphs [bundler]: http://gembundler.com/ diff --git a/app/ruby/app-issue-creator/README.md b/app/ruby/app-issue-creator/README.md index 0da7caca7..652f5a174 100644 --- a/app/ruby/app-issue-creator/README.md +++ b/app/ruby/app-issue-creator/README.md @@ -24,4 +24,4 @@ To start the server, type `ruby server.rb` on the command line. The [sinatra server](http://www.sinatrarb.com/) will be running at `localhost:4567`. -[basics of auth]: http://developer.github.com/guides/basics-of-authentication/ +[basics of auth]: https://docs.github.com/en/apps/oauth-apps/building-oauth-apps/authenticating-to-the-rest-api-with-an-oauth-app diff --git a/pre-receive-hooks/README.md b/pre-receive-hooks/README.md index da6a8c4de..e5d3ffcd5 100644 --- a/pre-receive-hooks/README.md +++ b/pre-receive-hooks/README.md @@ -53,7 +53,7 @@ Depending on your particular use case, you might be able to achieve your goals u If you also enable [Required Status](https://help.github.com/articles/enabling-required-status-checks/) on a protected branch, all required checks must succeed before team members are able to merge a Pull Request. Using our [Status API](https://developer.github.com/v3/repos/statuses/) you are able to define which checks (required or optional) should be triggered upon a Pull Request submission. -Instead of preventing the code from being committed you can also prevent it from being deployed. To do this, you can configure your deployment process to be triggered by the Pull Request merge event. Using the information that [GitHub's webhooks](https://developer.github.com/webhooks/) provide, you'll be able to determine whether the Pull Request meets the review and CI requirements. If it does not, you can reject the deployment and post the failure information back to the Pull Request. You can learn more about delivering deployments at https://developer.github.com/guides/delivering-deployments/. +Instead of preventing the code from being committed you can also prevent it from being deployed. To do this, you can configure your deployment process to be triggered by the Pull Request merge event. Using the information that [GitHub's webhooks](https://developer.github.com/webhooks/) provide, you'll be able to determine whether the Pull Request meets the review and CI requirements. If it does not, you can reject the deployment and post the failure information back to the Pull Request. You can learn more about delivering deployments at https://docs.github.com/en/rest/guides/delivering-deployments. Instead of putting controls in place that technically enforce your policy, you can also socially enforce it. Let's say your policy prescribes that pull requests should not be merged by the author of the pull request. You can build a culture within the company which makes merging your own Pull Request unacceptable behavior. To do this, you will need to be notified when someone merges their own Pull Request so that you can revert it and educate them on why having independent review is important. You can write a simple script, and attach it to a [webhook](https://developer.github.com/webhooks/), that looks for Pull Requests that were merged by the author. When this happens you can either post a comment in the Pull Request pinging a compliance team or send an email to a mailing list reporting the transgression. Once a developer has had their Pull Request reverted, they will be unlikely to make the same mistake again. This model places trust in the developers but still allows a certain degree of control and audibility. The power of Git makes undoing any unreviewed changes easy.