Repository navigation
Commit bdaf1dc
test(submodule): close retained parent before checkout removal
The Windows Python 3.14 job for PR #2274 failed in
`TestSubmodule.test_base_rw` when forced module-only removal called
`rmtree`: Windows reported `WinError 32` for `git/ext/gitdb`.
The legacy test retains that checkout's `Repo` through `csm.repo` and
starts its persistent `cat-file` process while reading parent commits.
Closing only the fresh handle created by `Submodule.remove()` cannot
release this caller-owned process.
Close the retained test-owned parent before deleting its checkout. Keep
strict removal and all existing happy-path assertions, and remove the
obsolete commented-out skip that claimed removal ignored this error.
The original test predates the PR's base, so record this as a follow-up
rather than rewriting shared history.
The focused `test_base_rw` passed locally with both CLI and Gix.
Relevant pre-commit hooks passed. Hosted Windows validation remains
part of the PR CI loop.1 parent 6881712 commit bdaf1dc
1 file changed
Lines changed: 1 addition & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1419 | 1419 | | |
1420 | 1420 | | |
1421 | 1421 | | |
| 1422 | + | |
1422 | 1423 | | |
1423 | 1424 | | |
1424 | 1425 | | |
| |||
1521 | 1522 | | |
1522 | 1523 | | |
1523 | 1524 | | |
1524 | | - | |
1525 | | - | |
1526 | | - | |
1527 | | - | |
1528 | | - | |
1529 | | - | |
1530 | | - | |
1531 | 1525 | | |
1532 | 1526 | | |
1533 | 1527 | | |
| |||
0 commit comments