From 13fd7a2a98d96f3ff884f9d68d06f689004e95c5 Mon Sep 17 00:00:00 2001 From: Daniel Sanche Date: Wed, 26 Aug 2026 16:15:36 -0700 Subject: [PATCH 1/3] ignore case in assertion --- .../google-cloud-bigquery/tests/unit/test_client.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/packages/google-cloud-bigquery/tests/unit/test_client.py b/packages/google-cloud-bigquery/tests/unit/test_client.py index d9c7fbbfbe5a..123d18359da1 100644 --- a/packages/google-cloud-bigquery/tests/unit/test_client.py +++ b/packages/google-cloud-bigquery/tests/unit/test_client.py @@ -1798,11 +1798,13 @@ def test_get_table_sets_user_agent(self): http.request.assert_called_once_with( url=mock.ANY, method="GET", - headers={ - "X-Goog-API-Client": expected_user_agent, - "Accept-Encoding": "gzip", - "User-Agent": expected_user_agent, - }, + headers=requests.structures.CaseInsensitiveDict( + { + "X-Goog-API-Client": expected_user_agent, + "Accept-Encoding": "gzip", + "User-Agent": expected_user_agent, + } + ), data=mock.ANY, timeout=DEFAULT_TIMEOUT, ) From 272c8f5f67666ed15157d742dc1e8333b684b535 Mon Sep 17 00:00:00 2001 From: Daniel Sanche Date: Wed, 26 Aug 2026 16:37:22 -0700 Subject: [PATCH 2/3] assert updated header --- .../google-cloud-bigquery/tests/unit/test_client.py | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/google-cloud-bigquery/tests/unit/test_client.py b/packages/google-cloud-bigquery/tests/unit/test_client.py index 123d18359da1..f9e8a38b716e 100644 --- a/packages/google-cloud-bigquery/tests/unit/test_client.py +++ b/packages/google-cloud-bigquery/tests/unit/test_client.py @@ -1798,13 +1798,11 @@ def test_get_table_sets_user_agent(self): http.request.assert_called_once_with( url=mock.ANY, method="GET", - headers=requests.structures.CaseInsensitiveDict( - { - "X-Goog-API-Client": expected_user_agent, - "Accept-Encoding": "gzip", - "User-Agent": expected_user_agent, - } - ), + headers={ + "x-goog-api-client": expected_user_agent, + "Accept-Encoding": "gzip", + "User-Agent": expected_user_agent, + }, data=mock.ANY, timeout=DEFAULT_TIMEOUT, ) From 4985d1b754997ce0c6bba8820220b713af3bd67a Mon Sep 17 00:00:00 2001 From: Daniel Sanche Date: Wed, 26 Aug 2026 17:16:15 -0700 Subject: [PATCH 3/3] support either case --- .../tests/unit/test_client.py | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/packages/google-cloud-bigquery/tests/unit/test_client.py b/packages/google-cloud-bigquery/tests/unit/test_client.py index f9e8a38b716e..5cce574d3ff1 100644 --- a/packages/google-cloud-bigquery/tests/unit/test_client.py +++ b/packages/google-cloud-bigquery/tests/unit/test_client.py @@ -1798,14 +1798,20 @@ def test_get_table_sets_user_agent(self): http.request.assert_called_once_with( url=mock.ANY, method="GET", - headers={ - "x-goog-api-client": expected_user_agent, - "Accept-Encoding": "gzip", - "User-Agent": expected_user_agent, - }, + headers=mock.ANY, data=mock.ANY, timeout=DEFAULT_TIMEOUT, ) + _, kwargs = http.request.call_args + actual_headers = {k.lower(): v for k, v in kwargs["headers"].items()} + self.assertEqual( + actual_headers, + { + "x-goog-api-client": expected_user_agent, + "accept-encoding": "gzip", + "user-agent": expected_user_agent, + }, + ) self.assertIn("my-application/1.2.3", expected_user_agent) def test_get_iam_policy(self):