Skip to content

OIDC: Additional external redirect_url whitelist #969

Description

@jmattheis

The POST /auth/oidc/external/authorize and POST /auth/oidc/external/token endpoints currently accept any redirect_uri from the request body and forward it verbatim to the OIDC provider

The OIDC provider is expected to enforce its own redirect_uri allowlist, so this isn't exploitable against a correctly configured IdP. This is an extra change that may reduce the risk of misconfigured IdP servers.

Originally reported privately by @overgrowncarrot1.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    a:featureNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions