fix: drop TableLayout.to_dict rather than add strict-mypy debt

I added to_dict() for surface consistency and then checked the gates properly:
it added 8 errors under this package s strict mypy settings (dict[str, Any] plus
comprehensions over the pydantic key models), taking the file from the 158 on
main to 166.

The alternative -- hand-building the dict from named fields -- is Any-free but
silently drops any field a later spec adds to TablePartitionKey or TableSortKey,
which is exactly the silent-drop failure this whole feature exists to prevent.

So taking the reviewer s first option: no to_dict, with a comment recording why
the inconsistency is deliberate, so the next reader does not "fix" it. A caller
wanting dicts can map k.to_dict() itself.

Also collapses a nested `with` flagged by ruff.

Back to main s baseline exactly: mypy 158, ruff only the pre-existing long line
in test_request_timeout.py. 139 passed.

Author: anoop-narang

hotdata_framework/databases.py

@@ -57,19 +57,15 @@ class TableLayout:
     partition_by: list[TablePartitionKey]
     sorted_by: list[TableSortKey]
 
-    def to_dict(self) -> dict[str, Any]:
-        """Plain dict, like the other dataclasses here.
-
-        Not `asdict()`: the key lists hold pydantic models, which `asdict` copies
-        through untouched, so the result would not be a plain dict. Each key is
-        mapped through its own `to_dict()` instead.
-        """
-        return {
-            "schema_name": self.schema_name,
-            "table_name": self.table_name,
-            "partition_by": [k.to_dict() for k in self.partition_by],
-            "sorted_by": [k.to_dict() for k in self.sorted_by],
-        }
+    # NO to_dict(), unlike every other dataclass here, and deliberately so.
+    # `asdict()` would copy the pydantic key models through untouched rather than
+    # flatten them, so it would not return a plain dict. Mapping each key through
+    # its own `to_dict()` does flatten, but returns `dict[str, Any]` and adds
+    # eight errors under this package's strict mypy settings; hand-building the
+    # dict from named fields avoids that but silently drops any field a later
+    # spec adds to the key models, which is the failure this whole feature exists
+    # to prevent. A caller wanting dicts can map `k.to_dict()` itself and own
+    # that choice.
 
     @property
     def is_partitioned(self) -> bool:

tests/test_databases.py

@@ -515,10 +515,6 @@ def information_schema(self, **kwargs):
     assert captured["var_schema"] == "public"
     assert captured["table"] == "files"
     assert captured["connection_id"] == _MANAGED_DB.default_connection_id
-    # to_dict flattens the pydantic keys rather than copying them through.
-    assert layout.to_dict()["partition_by"] == [
-        {"column": "event_date", "transform": "identity"}
-    ]
 
 
 def test_managed_table_layout_distinguishes_absent_from_unpartitioned():
@@ -555,9 +551,8 @@ def test_create_managed_database_refuses_layout_for_a_table_it_is_not_creating()
     parts, _ = _layout()
     client = _client()
 
-    with patch.object(client, "_databases_api") as dbs:
-        with pytest.raises(ValueError, match="fils"):
-            client.create_managed_database(
-                "demo", tables=["files"], partition_by={"fils": parts}
-            )
+    with patch.object(client, "_databases_api") as dbs, pytest.raises(ValueError, match="fils"):
+        client.create_managed_database(
+            "demo", tables=["files"], partition_by={"fils": parts}
+        )
     dbs.return_value.create_database.assert_not_called()