From f5c32128aeec9dfefc6c6a2f83bfd97649503d71 Mon Sep 17 00:00:00 2001 From: David Simansky Date: Fri, 18 Sep 2026 17:54:30 +0200 Subject: [PATCH] Fix non-contant format string err in go 1.26 --- pkg/apis/bindings/v1alpha1/githubbinding_lifecycle.go | 2 +- pkg/reconciler/source/githubsource.go | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/apis/bindings/v1alpha1/githubbinding_lifecycle.go b/pkg/apis/bindings/v1alpha1/githubbinding_lifecycle.go index a56e288b6..9cf5c1ab9 100644 --- a/pkg/apis/bindings/v1alpha1/githubbinding_lifecycle.go +++ b/pkg/apis/bindings/v1alpha1/githubbinding_lifecycle.go @@ -66,7 +66,7 @@ func (sbs *GitHubBindingStatus) InitializeConditions() { // MarkBindingUnavailable marks the GitHubBinding's Ready condition to False with // the provided reason and message. func (sbs *GitHubBindingStatus) MarkBindingUnavailable(reason, message string) { - sbCondSet.Manage(sbs).MarkFalse(GitHubBindingConditionReady, reason, message) + sbCondSet.Manage(sbs).MarkFalse(GitHubBindingConditionReady, reason, "%s", message) } // MarkBindingAvailable marks the GitHubBinding's Ready condition to True. diff --git a/pkg/reconciler/source/githubsource.go b/pkg/reconciler/source/githubsource.go index d374a969a..111db3d7e 100644 --- a/pkg/reconciler/source/githubsource.go +++ b/pkg/reconciler/source/githubsource.go @@ -124,7 +124,7 @@ func (r *Reconciler) ReconcileKind(ctx context.Context, source *sourcesv1alpha1. ksvc, err := r.reconcileReceiveAdapter(ctx, source) if err != nil { - source.Status.MarkWebhookNotConfigured("MissingReceiveAdapter", err.Error()) + source.Status.MarkWebhookNotConfigured("MissingReceiveAdapter", "%s", err) return err } @@ -147,14 +147,14 @@ func (r *Reconciler) ReconcileKind(ctx context.Context, source *sourcesv1alpha1. if source.Status.WebhookIDKey == "" { hookID, err := r.createWebhook(ctx, args) if err != nil { - source.Status.MarkWebhookNotConfigured("CreationFailed", err.Error()) + source.Status.MarkWebhookNotConfigured("CreationFailed", "%s", err) return err } source.Status.WebhookIDKey = hookID } else { err := r.reconcileWebhook(ctx, args, source.Status.WebhookIDKey) if err != nil { - source.Status.MarkWebhookNotConfigured("ReconciliationFailed", err.Error()) + source.Status.MarkWebhookNotConfigured("ReconciliationFailed", "%s", err) return err } }