Skip to content

Commit ab2bc54

Browse files
committed
Revert MSVC stack protection to defaults
I recall previous benchmarks showing that this mattered but this has no noticeable effect on current benchmarks, likely due to the new API being more efficient than the old one or changes in Python itself or modern hardware. Adding this flag was not well thought out before but it's unacceptable in the current era of AI generated hacks.
1 parent a69efbb commit ab2bc54

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎build_libtcod.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ def walk_sources(directory: str) -> Iterator[str]:
201201

202202
tdl_build = os.environ.get("TDL_BUILD", "RELEASE").upper()
203203

204-
MSVC_CFLAGS = {"DEBUG": ["/Od"], "RELEASE": ["/GL", "/O2", "/GS-", "/wd4996"]}
204+
MSVC_CFLAGS = {"DEBUG": ["/Od"], "RELEASE": ["/GL", "/O2", "/wd4996"]}
205205
MSVC_LDFLAGS: dict[str, list[str]] = {"DEBUG": [], "RELEASE": ["/LTCG"]}
206206
GCC_CFLAGS = {
207207
"DEBUG": ["-std=c99", "-Og", "-g", "-fPIC"],

0 commit comments

Comments
 (0)