diff --git a/CHANGELOG.md b/CHANGELOG.md index 9f7895d6..f08ad508 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # [unreleased] +## Improvements + +- ui: Remove process ID from credential prompt. + # 0.3.0 [2026-08-27] This release is a big milestone toward our goal of providing a Credential diff --git a/credentialsd-ui/src/gui/view_model/mod.rs b/credentialsd-ui/src/gui/view_model/mod.rs index 0ce7bfeb..0a791e1b 100644 --- a/credentialsd-ui/src/gui/view_model/mod.rs +++ b/credentialsd-ui/src/gui/view_model/mod.rs @@ -30,7 +30,6 @@ pub(crate) struct ViewModel { rp_id: String, app_name: String, app_path_or_id: String, - app_pid: u32, // This includes devices like platform authenticator, USB, hybrid devices: Vec, @@ -49,7 +48,7 @@ impl ViewModel { let RequestingApplication { name: app_name, path_or_app_id: path, - pid, + pid: _, } = request.requesting_app; let app_name: Option = app_name.into(); @@ -62,7 +61,6 @@ impl ViewModel { rp_id: request.rp_id, app_name: app_name.unwrap_or_else(|| gettext("unknown application")), app_path_or_id: path, - app_pid: pid, title: String::default(), subtitle: String::default(), devices, @@ -89,21 +87,18 @@ impl ViewModel { Operation::PublicKeyCreate => { // TRANSLATORS: %s1 is the "relying party" (e.g.: domain name) where the request is coming from // TRANSLATORS: %s2 is the application name (e.g.: firefox) where the request is coming from, must be left untouched to make the name bold - // TRANSLATORS: %i1 is the process ID of the requesting application // TRANSLATORS: %s3 is the app ID (think: org.mozilla.firefox) of the requesting application - gettext("\"%s2\" (process ID: %i1, app ID: %s3) is asking to create a credential to register at \"%s1\". Only proceed if you trust this process.") + gettext("\"%s2\" (%s3) is asking to create a credential to register at \"%s1\". Only proceed if you trust this process.") } Operation::PublicKeyGet => { // TRANSLATORS: %s1 is the "relying party" (think: domain name) where the request is coming from // TRANSLATORS: %s2 is the application name (e.g.: firefox) where the request is coming from, must be left untouched to make the name bold - // TRANSLATORS: %i1 is the process ID of the requesting application // TRANSLATORS: %s3 is the app ID (think: org.mozilla.firefox) of the requesting application - gettext("\"%s2\" (process ID: %i1, app ID: %s3) is asking to use a credential to sign in to \"%s1\". Only proceed if you trust this process.") + gettext("\"%s2\" (%s3) is asking to use a credential to sign in to \"%s1\". Only proceed if you trust this process.") } } .to_string(); subtitle = subtitle.replace("%s1", &self.rp_id); - subtitle = subtitle.replace("%i1", &format!("{}", self.app_pid)); subtitle = subtitle.replace("%s2", &self.app_name); subtitle = subtitle.replace("%s3", &self.app_path_or_id); self.title = title;