Skip to content

Commit ab40a5c

Browse files
committed
ci: the two run criteria tolerate a carriage return and name aapt2's attribute
1 parent 89f1daa commit ab40a5c

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1189,8 +1189,10 @@ jobs:
11891189
"$AAPT2" dump badging "$apk" 2>/dev/null | tee badging.log
11901190
grep -q "^package: name='" badging.log \
11911191
|| { echo "FAIL: aapt2 could not read the package name"; exit 1; }
1192-
grep -q "sdkVersion:'24'" badging.log \
1193-
|| { echo "FAIL: minSdkVersion is not 24 (this fixture's own min_api_level)"; exit 1; }
1192+
# aapt2 spells the attribute `minSdkVersion:'24'`; the file is shown
1193+
# byte-for-byte on a miss so that a quoting difference is visible.
1194+
tr -d '\r' < badging.log | grep -Eq "^(min)?[sS]dkVersion:'24'" \
1195+
|| { echo "FAIL: minSdkVersion is not 24 (this fixture's own min_api_level)"; cat -A badging.log | head -12; exit 1; }
11941196
echo "ok: dist-apk level 0 -- a signed, aapt2-readable APK carrying the native library, the deployed asset and the run sidecar"
11951197
11961198
# Compiles the device unit on a machine with no GPU: the clang route
@@ -1855,8 +1857,11 @@ jobs:
18551857
printf '%s\n' "$out" | tail -20
18561858
[ "$rc" -eq 0 ] \
18571859
|| { echo "FAIL: mcpp run --target aarch64-ios-sim --format app exited $rc"; exit 1; }
1858-
grep -qx '1-2-3' <<<"$out" \
1859-
|| { echo "FAIL: the program's output line '1-2-3' is absent"; exit 1; }
1860+
# `simctl launch --console-pty` returns the program's output through
1861+
# a pty, so a line may end in a carriage return; the marker is asserted
1862+
# as a line after that is stripped.
1863+
tr -d '\r' <<<"$out" | grep -Eq '^[[:space:]]*1-2-3[[:space:]]*$' \
1864+
|| { echo "FAIL: the program's output line '1-2-3' is absent"; printf '%s\n' "$out" | cat -A | tail -8; exit 1; }
18601865
echo "ok: a flat iOS Simulator bundle, MinimumOSVersion 17.0, and the simulator ran it"
18611866
18621867
- name: the rule declared its own compiler

0 commit comments

Comments
 (0)