Skip to content

Commit 64ab244

Browse files
dmealingclaude
andcommitted
fix(showcase): name the generators, since C# and Python no longer have a default suite
`regen-showcase.ts` invoked the C# and Python CLIs with no `--generators`. ADR-0034 Amendment 2 made codegen opt-in on both, so a run that names none generates nothing and exits 2 — `gen: no generators selected`. The Python arm failed exactly that way in the 1.0.4 release dry run. It reached a cut rather than a lane because this script is the only caller of those two CLIs outside their own tests, and `--check` runs in the release preflight, not in CI. The opt-in change and the caller that assumed a default shipped in the same release window and nothing sat between them. The two suites are spelled out with the reason, not defaulted back in. They are exactly the generators whose output is committed under `examples/showcase/generated/<port>/`, which is verifiable rather than asserted: `--check --all-ports` regenerates PRISTINE and reports the committed tree FRESH on all five ports, so these sets reproduce what is already there byte for byte. The ports' own test suites spell the same lists for the same reason (`server/python/tests/codegen/gen_suite.py`, `server/csharp/MetaObjects.Cli.Tests/GenSuiteForTests.cs`). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011cQxyVuTkdPmAduLiedNEg
1 parent bcb59b9 commit 64ab244

1 file changed

Lines changed: 21 additions & 0 deletions

File tree

scripts/regen-showcase.ts

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ const PORTS: Port[] = [
130130
"uv", "run", "--project", resolve(REPO, "server/python"),
131131
"metaobjects", "gen", join(project, "metaobjects"),
132132
"--out", join(project, "generated", "python"),
133+
"--generators", PYTHON_SUITE,
133134
]),
134135
},
135136
{
@@ -145,6 +146,7 @@ const PORTS: Port[] = [
145146
"-v", "q", "--",
146147
"gen", join(project, "metaobjects"),
147148
"--out", join(project, "generated", "csharp"),
149+
"--generators", CSHARP_SUITE,
148150
]),
149151
},
150152
{
@@ -199,6 +201,25 @@ const PORTS: Port[] = [
199201
},
200202
];
201203

204+
/**
205+
* The generators whose output is COMMITTED under `examples/showcase/generated/<port>/`.
206+
*
207+
* Spelled out because ADR-0034 Amendment 2 removed the default suite: `--generators` is
208+
* required on the C# and Python CLIs, and a run that names none generates nothing and
209+
* exits 2. This script is the only caller of those two CLIs outside their own tests, and
210+
* it runs ONLY at a release cut (`regen-showcase --check`), which is why the omission
211+
* reached a cut rather than a lane — it surfaced as `gen: no generators selected` in the
212+
* 1.0.4 dry run.
213+
*
214+
* These sets are not a default by the back door. They are exactly the generators that
215+
* produce the files committed here, so changing one means the committed tree changes too
216+
* — which is the diff this gate exists to show. The ports' own test suites spell the same
217+
* lists for the same reason (`server/python/tests/codegen/gen_suite.py`,
218+
* `server/csharp/MetaObjects.Cli.Tests/GenSuiteForTests.cs`).
219+
*/
220+
const PYTHON_SUITE = "entity,routes,filter-allowlist,names,payload,output-parser,output-prompt,extractor";
221+
const CSHARP_SUITE = "entity,names,db-context,routes,filter-allowlist,payload,output-parser,output-prompt,extractor";
222+
202223
function selectPorts(): Port[] {
203224
if (BUN_ONLY) {
204225
for (const p of PORTS.filter((p) => p.tool)) {

0 commit comments

Comments
 (0)