Skip to content

Commit d31511c

Browse files
author
vijay
committed
Rename skill resource-URI validator for clarity
_resource_uri_in_skill reads like a boolean predicate but returns None and raises; rename to _validate_resource_uri_in_skill to match its sibling validators (validate_skill, validate_list_result, validate_directory_result) and signal that it asserts.
1 parent 3a3725b commit d31511c

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/mcp/shared/skills.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ def skill_name_from_uri(uri: str) -> str:
151151
return name
152152

153153

154-
def _resource_uri_in_skill(skill_uri: str, resource_uri: str) -> None:
154+
def _validate_resource_uri_in_skill(skill_uri: str, resource_uri: str) -> None:
155155
"""Raise `ValueError` unless `resource_uri` names a file within `skill_uri`'s directory."""
156156
skill_parts = urlsplit(skill_uri)
157157
resource_parts = urlsplit(resource_uri)
@@ -195,7 +195,7 @@ def validate_skill(skill: Skill) -> None:
195195
seen: set[str] = set()
196196
total_size = 0
197197
for resource in resources:
198-
_resource_uri_in_skill(skill.uri, resource.uri)
198+
_validate_resource_uri_in_skill(skill.uri, resource.uri)
199199
if resource.uri in seen:
200200
raise ValueError(f"skill {skill.uri!r} lists resource {resource.uri!r} more than once")
201201
seen.add(resource.uri)

0 commit comments

Comments
 (0)