From 3e7b9d39925a7de6fbe727f2b94984d5c2533cab Mon Sep 17 00:00:00 2001 From: alperozturk96 Date: Tue, 17 Nov 2026 16:11:35 +0100 Subject: [PATCH 1/3] Rename .java to .kt Signed-off-by: alperozturk96 --- .../android/files/{FileMenuFilter.java => FileMenuFilter.kt} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename app/src/main/java/com/owncloud/android/files/{FileMenuFilter.java => FileMenuFilter.kt} (100%) diff --git a/app/src/main/java/com/owncloud/android/files/FileMenuFilter.java b/app/src/main/java/com/owncloud/android/files/FileMenuFilter.kt similarity index 100% rename from app/src/main/java/com/owncloud/android/files/FileMenuFilter.java rename to app/src/main/java/com/owncloud/android/files/FileMenuFilter.kt From 840579901f99c41c09340faee8ff7f3b58e89776 Mon Sep 17 00:00:00 2001 From: alperozturk96 Date: Tue, 17 Nov 2026 16:11:36 +0100 Subject: [PATCH 2/3] refactor(file-menu-filter): kotlin Signed-off-by: alperozturk96 --- .../android/files/FileMenuFilterIT.kt | 16 +- .../ui/fileactions/FileActionsViewModel.kt | 4 +- .../owncloud/android/files/FileMenuFilter.kt | 751 ++++-------------- .../android/files/FileMenuFilterFactory.kt | 41 + .../owncloud/android/files/FileSelection.kt | 70 ++ .../files/FileSynchronizationChecker.kt | 40 + 6 files changed, 321 insertions(+), 601 deletions(-) create mode 100644 app/src/main/java/com/owncloud/android/files/FileMenuFilterFactory.kt create mode 100644 app/src/main/java/com/owncloud/android/files/FileSelection.kt create mode 100644 app/src/main/java/com/owncloud/android/files/FileSynchronizationChecker.kt diff --git a/app/src/androidTest/java/com/owncloud/android/files/FileMenuFilterIT.kt b/app/src/androidTest/java/com/owncloud/android/files/FileMenuFilterIT.kt index ce02972076ef..e3f5f2cb372e 100644 --- a/app/src/androidTest/java/com/owncloud/android/files/FileMenuFilterIT.kt +++ b/app/src/androidTest/java/com/owncloud/android/files/FileMenuFilterIT.kt @@ -176,7 +176,7 @@ class FileMenuFilterIT : AbstractIT() { launchActivity().use { it.onActivity { activity -> val filterFactory = - FileMenuFilter.Factory(mockStorageManager, activity, editorUtils) + FileMenuFilterFactory(mockStorageManager, activity, editorUtils) var sut = filterFactory.newInstance(encryptedFolder, mockComponentsGetter, true, user) var toHide = sut.getToHide(false) @@ -234,7 +234,7 @@ class FileMenuFilterIT : AbstractIT() { launchActivity().use { it.onActivity { activity -> val filterFactory = - FileMenuFilter.Factory(mockStorageManager, activity, editorUtils) + FileMenuFilterFactory(mockStorageManager, activity, editorUtils) var sut = filterFactory.newInstance(encryptedVideo, mockComponentsGetter, true, user) var toHide = sut.getToHide(false) @@ -259,7 +259,7 @@ class FileMenuFilterIT : AbstractIT() { launchActivity().use { it.onActivity { activity -> - val filterFactory = FileMenuFilter.Factory(mockStorageManager, activity, editorUtils) + val filterFactory = FileMenuFilterFactory(mockStorageManager, activity, editorUtils) val files = listOf(OCFile("/foo.bin"), OCFile("/bar.bin"), OCFile("/baz.bin")) @@ -298,7 +298,7 @@ class FileMenuFilterIT : AbstractIT() { launchActivity().use { it.onActivity { activity -> - val filterFactory = FileMenuFilter.Factory(mockStorageManager, activity, editorUtils) + val filterFactory = FileMenuFilterFactory(mockStorageManager, activity, editorUtils) val files = listOf(OCFile("/foo.bin"), OCFile("/bar.bin"), OCFile("/baz.bin")) @@ -344,7 +344,7 @@ class FileMenuFilterIT : AbstractIT() { launchActivity().use { it.onActivity { activity -> - val filterFactory = FileMenuFilter.Factory(mockStorageManager, activity, editorUtils) + val filterFactory = FileMenuFilterFactory(mockStorageManager, activity, editorUtils) val downloadedToHide = filterFactory .newInstance(downloadedFile, mockComponentsGetter, true, user) @@ -376,7 +376,7 @@ class FileMenuFilterIT : AbstractIT() { launchActivity().use { it.onActivity { activity -> - val filterFactory = FileMenuFilter.Factory(mockStorageManager, activity, editorUtils) + val filterFactory = FileMenuFilterFactory(mockStorageManager, activity, editorUtils) val toHide = filterFactory .newInstance(file, mockComponentsGetter, true, user) @@ -403,7 +403,7 @@ class FileMenuFilterIT : AbstractIT() { launchActivity().use { it.onActivity { activity -> - val filterFactory = FileMenuFilter.Factory(mockStorageManager, activity, editorUtils) + val filterFactory = FileMenuFilterFactory(mockStorageManager, activity, editorUtils) val toHide = filterFactory .newInstance(file, mockComponentsGetter, true, user) @@ -433,7 +433,7 @@ class FileMenuFilterIT : AbstractIT() { launchActivity().use { it.onActivity { activity -> val filterFactory = - FileMenuFilter.Factory(mockStorageManager, activity, editorUtils) + FileMenuFilterFactory(mockStorageManager, activity, editorUtils) val sut = filterFactory.newInstance(file, mockComponentsGetter, true, user) val toHide = sut.getToHide(false) diff --git a/app/src/main/java/com/nextcloud/ui/fileactions/FileActionsViewModel.kt b/app/src/main/java/com/nextcloud/ui/fileactions/FileActionsViewModel.kt index 909b09910f27..537281816367 100644 --- a/app/src/main/java/com/nextcloud/ui/fileactions/FileActionsViewModel.kt +++ b/app/src/main/java/com/nextcloud/ui/fileactions/FileActionsViewModel.kt @@ -17,7 +17,7 @@ import com.nextcloud.client.account.CurrentAccountProvider import com.nextcloud.client.logger.Logger import com.nextcloud.utils.AppConstants import com.owncloud.android.datamodel.OCFile -import com.owncloud.android.files.FileMenuFilter +import com.owncloud.android.files.FileMenuFilterFactory import com.owncloud.android.lib.resources.files.model.FileLockType import com.owncloud.android.ui.activity.ComponentsGetter import kotlinx.coroutines.Dispatchers @@ -26,7 +26,7 @@ import javax.inject.Inject class FileActionsViewModel @Inject constructor( private val currentAccountProvider: CurrentAccountProvider, - private val filterFactory: FileMenuFilter.Factory, + private val filterFactory: FileMenuFilterFactory, private val logger: Logger ) : ViewModel() { diff --git a/app/src/main/java/com/owncloud/android/files/FileMenuFilter.kt b/app/src/main/java/com/owncloud/android/files/FileMenuFilter.kt index 0d7fa33d94a6..74f978f29362 100644 --- a/app/src/main/java/com/owncloud/android/files/FileMenuFilter.kt +++ b/app/src/main/java/com/owncloud/android/files/FileMenuFilter.kt @@ -1,668 +1,237 @@ /* * Nextcloud - Android Client * - * SPDX-FileCopyrightText: 2026 TSI-mc - * SPDX-FileCopyrightText: 2023 Alper Ozturk - * SPDX-FileCopyrightText: 2019-2023 Tobias Kaminsky - * SPDX-FileCopyrightText: 2022 Álvaro Brey Vilas - * SPDX-FileCopyrightText: 2020 Andy Scherzinger - * SPDX-FileCopyrightText: 2018 Mario Danic - * SPDX-FileCopyrightText: 2016 ownCloud Inc. - * SPDX-FileCopyrightText: 2014-2016 David A. Velasco - * SPDX-FileCopyrightText: 2012 Bartosz Przybylski - * SPDX-License-Identifier: GPL-2.0-only AND (AGPL-3.0-or-later OR GPL-2.0-only) + * SPDX-FileCopyrightText: 2026 Alper Ozturk + * SPDX-License-Identifier: AGPL-3.0-or-later */ -package com.owncloud.android.files; - -import android.accounts.AccountManager; -import android.content.Context; -import android.view.Menu; - -import com.nextcloud.android.files.FileLockingHelper; -import com.nextcloud.client.account.User; -import com.nextcloud.client.editimage.EditImageActivity; -import com.nextcloud.client.jobs.download.FileDownloadHelper; -import com.nextcloud.client.jobs.upload.FileUploadHelper; -import com.nextcloud.ui.fileactions.FileAction; -import com.nextcloud.utils.EditorUtils; -import com.nextcloud.utils.mdm.MDMConfig; -import com.owncloud.android.R; -import com.owncloud.android.datamodel.FileDataStorageManager; -import com.owncloud.android.datamodel.OCFile; -import com.owncloud.android.lib.resources.status.OCCapability; -import com.owncloud.android.services.OperationsService.OperationsServiceBinder; -import com.owncloud.android.ui.activity.ComponentsGetter; -import com.owncloud.android.ui.helpers.FileOperationsHelper; -import com.owncloud.android.utils.MimeTypeUtil; -import com.owncloud.android.utils.NextcloudServer; - -import java.util.ArrayList; -import java.util.Collection; -import java.util.Collections; -import java.util.HashSet; -import java.util.Iterator; -import java.util.List; - -import javax.inject.Inject; - -import androidx.annotation.IdRes; -import androidx.core.content.pm.ShortcutManagerCompat; - -/** - * Filters out the file actions available in a given {@link Menu} for a given {@link OCFile} - * according to the current state of the latest. - */ -public class FileMenuFilter { - - private static final int SINGLE_SELECT_ITEMS = 1; - private static final int EMPTY_FILE_LENGTH = 0; - public static final String SEND_OFF = "off"; - - private final int numberOfAllFiles; - private final Collection files; - private final ComponentsGetter componentsGetter; - private final Context context; - private final boolean overflowMenu; - private final User user; - private final String userId; - private final FileDataStorageManager storageManager; - private final EditorUtils editorUtils; - - - public static class Factory { - private final FileDataStorageManager storageManager; - private final Context context; - private final EditorUtils editorUtils; - - @Inject - public Factory(final FileDataStorageManager storageManager, final Context context, final EditorUtils editorUtils) { - this.storageManager = storageManager; - this.context = context; - this.editorUtils = editorUtils; - } - - /** - * @param numberOfAllFiles Number of all displayed files - * @param files Collection of {@link OCFile} file targets of the action to filter in the {@link Menu}. - * @param componentsGetter Accessor to app components, needed to access synchronization services - * @param overflowMenu true if the overflow menu items are being filtered - * @param user currently active user - */ - public FileMenuFilter newInstance(final int numberOfAllFiles, final Collection files, final ComponentsGetter componentsGetter, boolean overflowMenu, User user) { - return new FileMenuFilter(storageManager, editorUtils, numberOfAllFiles, files, componentsGetter, context, overflowMenu, user); - } - - /** - * @param file {@link OCFile} file target - * @param componentsGetter Accessor to app components, needed to access synchronization services - * @param overflowMenu true if the overflow menu items are being filtered - * @param user currently active user - */ - public FileMenuFilter newInstance(final OCFile file, final ComponentsGetter componentsGetter, boolean overflowMenu, User user) { - return newInstance(1, Collections.singletonList(file), componentsGetter, overflowMenu, user); - } - } - +package com.owncloud.android.files + +import android.accounts.AccountManager +import android.content.Context +import androidx.annotation.IdRes +import androidx.core.content.pm.ShortcutManagerCompat +import com.nextcloud.android.files.FileLockingHelper.canUserUnlockFile +import com.nextcloud.client.account.User +import com.nextcloud.client.editimage.EditImageActivity.Companion.canBePreviewed +import com.nextcloud.ui.fileactions.FileAction +import com.nextcloud.utils.EditorUtils +import com.nextcloud.utils.mdm.MDMConfig.sendFilesSupport +import com.nextcloud.utils.mdm.MDMConfig.shareViaLink +import com.nextcloud.utils.mdm.MDMConfig.shareViaUser +import com.owncloud.android.R +import com.owncloud.android.datamodel.FileDataStorageManager +import com.owncloud.android.datamodel.OCFile +import com.owncloud.android.lib.common.accounts.AccountUtils +import com.owncloud.android.lib.resources.status.OCCapability +import com.owncloud.android.ui.activity.ComponentsGetter +import com.owncloud.android.ui.helpers.FileOperationsHelper.Companion.isEndToEndEncryptionSetup +import com.owncloud.android.utils.MimeTypeUtil +import com.owncloud.android.utils.NextcloudServer + +class FileMenuFilter internal constructor( + private val storageManager: FileDataStorageManager, + private val editorUtils: EditorUtils, + private val numberOfAllFiles: Int, + private val files: Collection, + private val componentsGetter: ComponentsGetter, + private val context: Context, + private val overflowMenu: Boolean, + private val user: User +) { + private val userId: String? = AccountManager + .get(context) + .getUserData(user.toPlatformAccount(), AccountUtils.Constants.KEY_USER_ID) + + private val selection = FileSelection(files, storageManager) - private FileMenuFilter(FileDataStorageManager storageManager, EditorUtils editorUtils, int numberOfAllFiles, - Collection files, - ComponentsGetter componentsGetter, - Context context, - boolean overflowMenu, - User user - ) { - this.storageManager = storageManager; - this.editorUtils = editorUtils; - this.numberOfAllFiles = numberOfAllFiles; - this.files = files; - this.componentsGetter = componentsGetter; - this.context = context; - this.overflowMenu = overflowMenu; - this.user = user; - userId = AccountManager - .get(context) - .getUserData(this.user.toPlatformAccount(), - com.owncloud.android.lib.common.accounts.AccountUtils.Constants.KEY_USER_ID); - } - - /** - * List of actions to remove given the parameters supplied in the constructor - */ @IdRes - public List getToHide(final boolean inSingleFileFragment){ - if(files != null && ! files.isEmpty()){ - return filter(inSingleFileFragment); - } - return null; - } + fun getToHide(inSingleFileFragment: Boolean): List { + if (files.isEmpty()) return emptyList() + val synchronizing = FileSynchronizationChecker(files, componentsGetter, user).isAnyFileSynchronizing() + val capability = storageManager.getCapability(user.accountName) - /** - * Decides what actions must be shown and hidden implementing the different rule sets. - * - * @param inSingleFileFragment True if this is not listing, but single file fragment, like preview or details. - */ - private List filter(boolean inSingleFileFragment) { - boolean synchronizing = anyFileSynchronizing(); - OCCapability capability = storageManager.getCapability(user.getAccountName()); - boolean endToEndEncryptionEnabled = capability.getEndToEndEncryption().isTrue(); - boolean fileLockingEnabled = capability.getFilesLockingVersion() != null; - - @IdRes final List toHide = new ArrayList<>(); - - filterEdit(toHide, capability); - filterDownload(toHide, synchronizing); - filterExport(toHide); - filterRename(toHide, synchronizing); - filterMoveOrCopy(toHide, synchronizing); - filterRemove(toHide, synchronizing); - filterSelectAll(toHide, inSingleFileFragment); - filterDeselectAll(toHide, inSingleFileFragment); - filterOpenWith(toHide, synchronizing); - filterOpenInWebEditor(toHide); - filterCancelSync(toHide, synchronizing); - filterSync(toHide, synchronizing); - filterShareFile(toHide, capability); - filterSendFiles(toHide, inSingleFileFragment); - filterDetails(toHide); - filterFavorite(toHide, synchronizing); - filterUnfavorite(toHide, synchronizing); - filterEncrypt(toHide, endToEndEncryptionEnabled); - filterUnsetEncrypted(toHide, endToEndEncryptionEnabled); - filterSetPictureAs(toHide); - filterStream(toHide); - filterAddToAlbum(toHide); - filterLock(toHide, fileLockingEnabled); - filterUnlock(toHide, fileLockingEnabled); - filterPinToHome(toHide); - filterRetry(toHide); - filterPermissionActions(toHide); - filterReadOnly(toHide); - - return toHide; - } - - private void filterPermissionActions(List toHide) { - final var actionsToHide = FileAction.Companion.getActionsToHide(new HashSet<>(files)); - toHide.addAll(actionsToHide); - } - - - private void filterShareFile(List toHide, OCCapability capability) { - if (!isSingleSelection() || containsEncryptedFile() || hasEncryptedParent() || - (!isShareViaLinkAllowed() && !isShareWithUsersAllowed()) || - !isShareApiEnabled(capability) || !files.iterator().next().canReshare()) { - toHide.add(R.id.action_send_share_file); + return buildList { + addAll(getHiddenFileActions(capability, synchronizing)) + addAll(getHiddenSelectionActions(inSingleFileFragment)) + addAll(getHiddenSyncActions(synchronizing)) + addAll(getHiddenShareActions(capability, inSingleFileFragment)) + addAll(getHiddenFavoriteActions(synchronizing)) + addAll(getHiddenEncryptionActions(capability.endToEndEncryption.isTrue)) + addAll(getHiddenMediaActions()) + addAll(getHiddenLockActions(capability.filesLockingVersion != null)) + addAll(FileAction.getActionsToHide(files.toHashSet())) + if (selection.containsReadOnlyFile()) addAll(READ_ONLY_HIDDEN_ACTIONS) } } - private void filterSendFiles(List toHide, boolean inSingleFileFragment) { - boolean sendFilesNotSupported = context != null && !MDMConfig.INSTANCE.sendFilesSupport(context); - boolean hasEncryptedFile = containsEncryptedFile(); - boolean isSingleSelection = isSingleSelection(); - boolean allFilesNotDown = !allFileDown(); - - if (sendFilesNotSupported) { - toHide.add(R.id.action_send_file); - return; - } - - if (overflowMenu || hasEncryptedFile) { - toHide.add(R.id.action_send_file); - return; - } + private fun getHiddenFileActions(capability: OCCapability, synchronizing: Boolean) = buildList { + val containsEncryptedOrLocked = selection.containsEncrypted || selection.containsLocked - if (!inSingleFileFragment && (isSingleSelection || allFilesNotDown)) { - toHide.add(R.id.action_send_file); - } else if (!toHide.contains(R.id.action_send_share_file)) { - toHide.add(R.id.action_send_file); + if (isEditHidden(capability)) add(R.id.action_edit) + if (selection.containsFolder || selection.anyDown || synchronizing) add(R.id.action_download_file) + if (selection.containsFolder) add(R.id.action_export_file) + if (!selection.isSingleSelection || synchronizing || containsEncryptedOrLocked) add(R.id.action_rename_file) + if (synchronizing || containsEncryptedOrLocked) add(R.id.action_move_or_copy) + if (synchronizing || selection.containsLocked || selection.containsEncryptedFolderContent()) { + add(R.id.action_remove_file) } + if (!selection.isSingleFile || !selection.anyDown || synchronizing) add(R.id.action_open_file_with) + if (isOpenInWebEditorHidden()) add(R.id.action_open_in_web_editor) + if (isPinToHomeHidden()) add(R.id.action_pin_to_homescreen) + if (!selection.firstFile.isOfflineOperation) add(R.id.action_retry) } - private void filterDetails(Collection toHide) { - if (!isSingleSelection()) { - toHide.add(R.id.action_see_details); - } - } + private fun getHiddenSelectionActions(inSingleFileFragment: Boolean) = buildList { + val allFilesSelected = files.size >= numberOfAllFiles - private void filterFavorite(List toHide, boolean synchronizing) { - if (files.isEmpty() || synchronizing || allFavorites()) { - toHide.add(R.id.action_favorite); - } + if (inSingleFileFragment || allFilesSelected || overflowMenu) add(R.id.action_select_all_action_menu) + if (inSingleFileFragment || overflowMenu) add(R.id.action_deselect_all_action_menu) + if (!selection.isSingleSelection) add(R.id.action_see_details) } - private void filterUnfavorite(List toHide, boolean synchronizing) { - if (files.isEmpty() || synchronizing || allNotFavorites()) { - toHide.add(R.id.action_unset_favorite); - } - } + private fun getHiddenSyncActions(synchronizing: Boolean) = buildList { + val nothingToSync = !selection.anyDown && !selection.containsFolder - private void filterLock(List toHide, boolean fileLockingEnabled) { - if (files.isEmpty() || - !isSingleSelection() || - !fileLockingEnabled || - containsEncryptedFile() || - containsEncryptedFolder()) { - toHide.add(R.id.action_lock_file); - } else { - OCFile file = files.iterator().next(); - if (file.isLocked() || file.isFolder()) { - toHide.add(R.id.action_lock_file); - } + if (!synchronizing) add(R.id.action_cancel_sync) + if (nothingToSync || synchronizing || selection.containsEncrypted) { + add(R.id.action_sync_file) + add(R.id.action_sync_all_files) } } - private void filterUnlock(List toHide, boolean fileLockingEnabled) { - if (files.isEmpty() || !isSingleSelection() || !fileLockingEnabled) { - toHide.add(R.id.action_unlock_file); - } else { - OCFile file = files.iterator().next(); - if (!FileLockingHelper.canUserUnlockFile(userId, file)) { - toHide.add(R.id.action_unlock_file); - } - } - } + private fun getHiddenShareActions(capability: OCCapability, inSingleFileFragment: Boolean) = buildList { + val shareFileHidden = isShareFileHidden(capability) - private void filterEncrypt(List toHide, boolean endToEndEncryptionEnabled) { - if (files.isEmpty() || !isSingleSelection() || isSingleFile() || isEncryptedFolder() || isGroupFolder() - || !endToEndEncryptionEnabled || !isEmptyFolder() || isShared()) { - toHide.add(R.id.action_encrypted); - } + if (shareFileHidden) add(R.id.action_send_share_file) + if (isSendFileHidden(inSingleFileFragment, shareFileHidden)) add(R.id.action_send_file) } - private void filterUnsetEncrypted(List toHide, boolean endToEndEncryptionEnabled) { - if (!endToEndEncryptionEnabled || files.isEmpty() || !isSingleSelection() || isSingleFile() || !isEncryptedFolder() || hasEncryptedParent() - || !isEmptyFolder() || !FileOperationsHelper.isEndToEndEncryptionSetup(context, user)) { - toHide.add(R.id.action_unset_encrypted); - } + private fun getHiddenFavoriteActions(synchronizing: Boolean) = buildList { + if (synchronizing || selection.allFavorites) add(R.id.action_favorite) + if (synchronizing || selection.noneFavorite) add(R.id.action_unset_favorite) } - private void filterSetPictureAs(List toHide) { - if (!isSingleImage() || MimeTypeUtil.isSVG(files.iterator().next())) { - toHide.add(R.id.action_set_as_wallpaper); - } - } - - private void filterPinToHome(List toHide) { - if (!isSingleSelection() || !ShortcutManagerCompat.isRequestPinShortcutSupported(context)) { - toHide.add(R.id.action_pin_to_homescreen); - } - } - - private void filterRetry(List toHide) { - if (!files.iterator().next().isOfflineOperation()) { - toHide.add(R.id.action_retry); - } - } - - private void filterEdit( - List toHide, - OCCapability capability - ) { - if (files.iterator().next().isEncrypted()) { - toHide.add(R.id.action_edit); - return; - } - - String mimeType = files.iterator().next().getMimeType(); - - if (!isRichDocumentEditingSupported(capability, mimeType) && !editorUtils.isEditorAvailable(user, mimeType) && - !(isSingleImage() && EditImageActivity.Companion.canBePreviewed(files.iterator().next()))) { - toHide.add(R.id.action_edit); - } - } - - /** - * This will be replaced by unified editor and can be removed once EOL of corresponding server version. - */ - @NextcloudServer(max = 18) - private boolean isRichDocumentEditingSupported(OCCapability capability, String mimeType) { - final var mimeTypeList = capability.getRichDocumentsMimeTypeList(); - final var isMimeTypeListContainsMimeType = (mimeTypeList != null && mimeTypeList.contains(mimeType)); - - final var optionalMimeTypeList = capability.getRichDocumentsOptionalMimeTypeList(); - final var isOptionalMimeTypeListContainsMimeType = (optionalMimeTypeList != null && - optionalMimeTypeList.contains(mimeType)); - - return isSingleFile() && - (isMimeTypeListContainsMimeType || isOptionalMimeTypeListContainsMimeType) && - capability.getRichDocumentsDirectEditing().isTrue(); - } - - private void filterSync(List toHide, boolean synchronizing) { - if (files.isEmpty() || (!anyFileDown() && !containsFolder()) || synchronizing || containsEncryptedFile() - || containsEncryptedFolder()) { - toHide.add(R.id.action_sync_file); - toHide.add(R.id.action_sync_all_files); - } - } - - private void filterCancelSync(List toHide, boolean synchronizing) { - if (files.isEmpty() || !synchronizing) { - toHide.add(R.id.action_cancel_sync); - } - } - - private void filterOpenWith(Collection toHide, boolean synchronizing) { - if (!isSingleFile() || !anyFileDown() || synchronizing) { - toHide.add(R.id.action_open_file_with); - } - } - - private void filterOpenInWebEditor(Collection toHide) { - if (!isSingleFile()) { - toHide.add(R.id.action_open_in_web_editor); - return; - } - - OCFile file = files.iterator().next(); - boolean canOpenLocally = file.isDown() && !file.isEncrypted(); - if (!canOpenLocally || !editorUtils.isOfficeEditorAvailable(user, file.getMimeType())) { - toHide.add(R.id.action_open_in_web_editor); - } + private fun getHiddenEncryptionActions(endToEndEncryptionEnabled: Boolean) = buildList { + if (isEncryptHidden(endToEndEncryptionEnabled)) add(R.id.action_encrypted) + if (isUnsetEncryptedHidden(endToEndEncryptionEnabled)) add(R.id.action_unset_encrypted) } - private void filterDeselectAll(List toHide, boolean inSingleFileFragment) { - if (inSingleFileFragment) { - // Always hide in single file fragments - toHide.add(R.id.action_deselect_all_action_menu); - } else { - // Show only if at least one item is selected. - if (files.isEmpty() || overflowMenu) { - toHide.add(R.id.action_deselect_all_action_menu); - } - } - } + private fun getHiddenMediaActions() = buildList { + val firstFile = selection.firstFile - private void filterSelectAll(List toHide, boolean inSingleFileFragment) { - if (!inSingleFileFragment) { - // Show only if at least one item isn't selected. - if (files.size() >= numberOfAllFiles || overflowMenu) { - toHide.add(R.id.action_select_all_action_menu); - } - } else { - // Always hide in single file fragments - toHide.add(R.id.action_select_all_action_menu); + if (!selection.isSingleImage || MimeTypeUtil.isSVG(firstFile)) add(R.id.action_set_as_wallpaper) + if (!selection.isSingleFile || !selection.isSingleMedia || selection.containsEncryptedFile) { + add(R.id.action_stream_media) } + if (selection.containsEncryptedFile || !MimeTypeUtil.isImageOrVideo(firstFile)) add(R.id.action_add_to_album) } - private void filterReadOnly(Collection toHide) { - boolean anyReadOnly = false; - for (OCFile file : files) { - if (storageManager.isReadOnly(file)) { - anyReadOnly = true; - break; - } - } - - if (!anyReadOnly) { - return; - } - - toHide.add(R.id.action_remove_file); - toHide.add(R.id.action_rename_file); - toHide.add(R.id.action_move_or_copy); - toHide.add(R.id.action_edit); - toHide.add(R.id.action_encrypted); - toHide.add(R.id.action_unset_encrypted); - toHide.add(R.id.action_lock_file); - toHide.add(R.id.action_unlock_file); - toHide.add(R.id.action_favorite); - toHide.add(R.id.action_unset_favorite); + private fun getHiddenLockActions(fileLockingEnabled: Boolean) = buildList { + if (isLockHidden(fileLockingEnabled)) add(R.id.action_lock_file) + if (!selection.isSingleSelection || !fileLockingEnabled || !canUserUnlock()) add(R.id.action_unlock_file) } - private void filterRemove(List toHide, boolean synchronizing) { - if (files.isEmpty() || synchronizing || containsLockedFile() - || containsEncryptedFolder() || isFolderAndContainsEncryptedFile()) { - toHide.add(R.id.action_remove_file); - } - } + private fun isEditHidden(capability: OCCapability): Boolean { + val file = selection.firstFile + if (file.isEncrypted) return true - private void filterMoveOrCopy(List toHide, boolean synchronizing) { - if (files.isEmpty() || synchronizing || containsEncryptedFile() || containsEncryptedFolder() || containsLockedFile()) { - toHide.add(R.id.action_move_or_copy); + val mimeType = file.mimeType + if (isRichDocumentEditingSupported(capability, mimeType) || editorUtils.isEditorAvailable(user, mimeType)) { + return false } - } - private void filterRename(Collection toHide, boolean synchronizing) { - if (!isSingleSelection() || synchronizing || containsEncryptedFile() || containsEncryptedFolder() || containsLockedFile()) { - toHide.add(R.id.action_rename_file); - } + return !(selection.isSingleImage && canBePreviewed(file)) } - private void filterDownload(List toHide, boolean synchronizing) { - if (files.isEmpty() || containsFolder() || anyFileDown() || synchronizing) { - toHide.add(R.id.action_download_file); - } - } + @NextcloudServer(max = 18) + private fun isRichDocumentEditingSupported(capability: OCCapability, mimeType: String?): Boolean { + if (!selection.isSingleFile) return false - private void filterExport(List toHide) { - if (files.isEmpty() || containsFolder()) { - toHide.add(R.id.action_export_file); - } - } + val isSupportedMimeType = capability.richDocumentsMimeTypeList?.contains(mimeType) == true || + capability.richDocumentsOptionalMimeTypeList?.contains(mimeType) == true - private void filterStream(List toHide) { - if (files.isEmpty() || !isSingleFile() || !isSingleMedia() || containsEncryptedFile()) { - toHide.add(R.id.action_stream_media); - } + return isSupportedMimeType && capability.richDocumentsDirectEditing.isTrue } - private void filterAddToAlbum(List toHide) { - if (files.isEmpty() || containsEncryptedFile()) { - toHide.add(R.id.action_add_to_album); - return; - } - OCFile file = files.iterator().next(); - if (!MimeTypeUtil.isImageOrVideo(file)) { - toHide.add(R.id.action_add_to_album); - } - } + private fun isOpenInWebEditorHidden(): Boolean { + if (!selection.isSingleFile) return true - private boolean anyFileSynchronizing() { - boolean synchronizing = false; - if (componentsGetter != null && !files.isEmpty() && user != null) { - OperationsServiceBinder opsBinder = componentsGetter.getOperationsServiceBinder(); - synchronizing = anyFileSynchronizing(opsBinder) || // comparing local and remote - anyFileDownloading() || - anyFileUploading(); - } - return synchronizing; - } + val file = selection.firstFile + val canOpenLocally = file.isDown && !file.isEncrypted - private boolean anyFileSynchronizing(OperationsServiceBinder opsBinder) { - boolean synchronizing = false; - if (opsBinder != null) { - for (Iterator iterator = files.iterator(); !synchronizing && iterator.hasNext(); ) { - synchronizing = opsBinder.isSynchronizing(user, iterator.next()); - } - } - return synchronizing; + return !canOpenLocally || !editorUtils.isOfficeEditorAvailable(user, file.mimeType) } - private boolean anyFileDownloading() { - final var fileDownloadHelper = FileDownloadHelper.Companion.instance(); + private fun isPinToHomeHidden(): Boolean = + !selection.isSingleSelection || !ShortcutManagerCompat.isRequestPinShortcutSupported(context) - for (OCFile file : files) { - if (fileDownloadHelper.isDownloading(user, file)) { - return true; - } + private fun isShareFileHidden(capability: OCCapability): Boolean { + if (!selection.isSingleSelection || selection.containsEncryptedFile || selection.hasEncryptedParent()) { + return true } - return false; + return !isShareAllowed() || !isShareApiEnabled(capability) || !selection.firstFile.canReshare() } - private boolean anyFileUploading() { - for (OCFile file : files) { - if (FileUploadHelper.Companion.instance().isUploading(file.getRemotePath(), user.getAccountName())) { - return true; - } - } - return false; - } + private fun isShareAllowed(): Boolean = shareViaLink(context) || shareViaUser(context) - private boolean isShareApiEnabled(OCCapability capability) { - return capability != null && - (capability.getFilesSharingApiEnabled().isTrue() || - capability.getFilesSharingApiEnabled().isUnknown() - ); - } + private fun isShareApiEnabled(capability: OCCapability): Boolean { + val sharingApi = capability.filesSharingApiEnabled - private boolean isShareWithUsersAllowed() { - return context != null && MDMConfig.INSTANCE.shareViaUser(context); + return sharingApi.isTrue || sharingApi.isUnknown } - private boolean isShareViaLinkAllowed() { - return context != null && MDMConfig.INSTANCE.shareViaLink(context); - } + private fun isSendFileHidden(inSingleFileFragment: Boolean, shareFileHidden: Boolean): Boolean { + if (!sendFilesSupport(context) || overflowMenu || selection.containsEncryptedFile) return true - private boolean isSingleSelection() { - return files.size() == SINGLE_SELECT_ITEMS; - } + val hiddenInListing = !inSingleFileFragment && (selection.isSingleSelection || !selection.allDown) - private boolean isSingleFile() { - return isSingleSelection() && !files.iterator().next().isFolder(); + return hiddenInListing || !shareFileHidden } - private boolean isEncryptedFolder() { - if (isSingleSelection()) { - OCFile file = files.iterator().next(); + private fun isEncryptHidden(endToEndEncryptionEnabled: Boolean): Boolean { + if (!endToEndEncryptionEnabled || !selection.isSingleFolder || selection.isEncryptedFolder) return true + if (selection.isGroupFolder || selection.containsShared) return true - return file.isFolder() && file.isEncrypted(); - } else { - return false; - } + return !selection.isEmptyFolder() } - private boolean isEmptyFolder() { - if (isSingleSelection()) { - OCFile file = files.iterator().next(); - - boolean noChildren = storageManager - .getFolderContent(file, false).size() == EMPTY_FILE_LENGTH; + private fun isUnsetEncryptedHidden(endToEndEncryptionEnabled: Boolean): Boolean { + if (!endToEndEncryptionEnabled || !selection.isEncryptedFolder) return true + if (selection.hasEncryptedParent() || !selection.isEmptyFolder()) return true - return file.isFolder() && file.getFileLength() == EMPTY_FILE_LENGTH && noChildren; - } else { - return false; - } + return !isEndToEndEncryptionSetup(context, user) } - private boolean isGroupFolder() { - return files.iterator().next().mounted(); - } - - private boolean hasEncryptedParent() { - OCFile folder = files.iterator().next(); - OCFile parent = storageManager.getFileById(folder.getParentId()); - - return parent != null && parent.isEncrypted(); - } - - private boolean isSingleImage() { - return isSingleSelection() && MimeTypeUtil.isImage(files.iterator().next()); - } - - private boolean isSingleMedia() { - OCFile file = files.iterator().next(); - return isSingleSelection() && (MimeTypeUtil.isVideo(file) || MimeTypeUtil.isAudio(file)); - } - - private boolean isFolderAndContainsEncryptedFile() { - for (OCFile file : files) { - if (!file.isFolder()) { - continue; - } - if (file.isFolder()) { - List children = storageManager.getFolderContent(file, false); - for (OCFile child : children) { - if (child.isEncrypted()) { - return true; - } - } - } - } - return false; - } - - - private boolean containsEncryptedFile() { - for (OCFile file : files) { - if (!file.isFolder() && file.isEncrypted()) { - return true; - } - } - return false; - } + private fun isLockHidden(fileLockingEnabled: Boolean): Boolean { + if (!selection.isSingleSelection || !fileLockingEnabled || selection.containsEncrypted) return true - private boolean containsLockedFile() { - for (OCFile file : files) { - if (file.isLocked()) { - return true; - } - } - return false; - } + val file = selection.firstFile - private boolean containsEncryptedFolder() { - for (OCFile file : files) { - if (file.isFolder() && file.isEncrypted()) { - return true; - } - } - return false; + return file.isLocked || file.isFolder } - private boolean containsFolder() { - for (OCFile file : files) { - if (file.isFolder()) { - return true; - } - } - return false; - } + private fun canUserUnlock(): Boolean { + val userId = userId ?: return false - private boolean anyFileDown() { - for (OCFile file : files) { - if (file.isDown()) { - return true; - } - } - return false; + return canUserUnlockFile(userId, selection.firstFile) } - private boolean allFileDown() { - for (OCFile file: files) { - if(!file.isDown()) { - return false; - } - } - return true; - } + companion object { + const val SEND_OFF: String = "off" - private boolean allFavorites() { - for (OCFile file : files) { - if (!file.isFavorite()) { - return false; - } - } - return true; - } - - private boolean allNotFavorites() { - for (OCFile file : files) { - if (file.isFavorite()) { - return false; - } - } - return true; - } - - private boolean isShared() { - for (OCFile file : files) { - if (file.isSharedWithMe() || file.isSharedViaLink() || file.isSharedWithSharee()) { - return true; - } - } - return false; + private val READ_ONLY_HIDDEN_ACTIONS = listOf( + R.id.action_remove_file, + R.id.action_rename_file, + R.id.action_move_or_copy, + R.id.action_edit, + R.id.action_encrypted, + R.id.action_unset_encrypted, + R.id.action_lock_file, + R.id.action_unlock_file, + R.id.action_favorite, + R.id.action_unset_favorite + ) } } diff --git a/app/src/main/java/com/owncloud/android/files/FileMenuFilterFactory.kt b/app/src/main/java/com/owncloud/android/files/FileMenuFilterFactory.kt new file mode 100644 index 000000000000..958aaa13deed --- /dev/null +++ b/app/src/main/java/com/owncloud/android/files/FileMenuFilterFactory.kt @@ -0,0 +1,41 @@ +/* + * Nextcloud - Android Client + * + * SPDX-FileCopyrightText: 2026 Alper Ozturk + * SPDX-License-Identifier: AGPL-3.0-or-later + */ +package com.owncloud.android.files + +import android.content.Context +import com.nextcloud.client.account.User +import com.nextcloud.utils.EditorUtils +import com.owncloud.android.datamodel.FileDataStorageManager +import com.owncloud.android.datamodel.OCFile +import com.owncloud.android.ui.activity.ComponentsGetter +import javax.inject.Inject + +class FileMenuFilterFactory @Inject constructor( + private val storageManager: FileDataStorageManager, + private val context: Context, + private val editorUtils: EditorUtils +) { + fun newInstance( + numberOfAllFiles: Int, + files: Collection, + componentsGetter: ComponentsGetter, + overflowMenu: Boolean, + user: User + ) = FileMenuFilter( + storageManager, + editorUtils, + numberOfAllFiles, + files, + componentsGetter, + context, + overflowMenu, + user + ) + + fun newInstance(file: OCFile, componentsGetter: ComponentsGetter, overflowMenu: Boolean, user: User) = + newInstance(FileSelection.SINGLE_SELECT_ITEMS, listOf(file), componentsGetter, overflowMenu, user) +} diff --git a/app/src/main/java/com/owncloud/android/files/FileSelection.kt b/app/src/main/java/com/owncloud/android/files/FileSelection.kt new file mode 100644 index 000000000000..7c70b9927528 --- /dev/null +++ b/app/src/main/java/com/owncloud/android/files/FileSelection.kt @@ -0,0 +1,70 @@ +/* + * Nextcloud - Android Client + * + * SPDX-FileCopyrightText: 2026 Alper Ozturk + * SPDX-License-Identifier: AGPL-3.0-or-later + */ +package com.owncloud.android.files + +import com.owncloud.android.datamodel.FileDataStorageManager +import com.owncloud.android.datamodel.OCFile +import com.owncloud.android.utils.MimeTypeUtil + +class FileSelection(private val files: Collection, private val storageManager: FileDataStorageManager) { + + val isSingleSelection = files.size == SINGLE_SELECT_ITEMS + val containsFolder = files.any { it.isFolder } + val containsEncrypted = files.any { it.isEncrypted } + val containsEncryptedFile = files.any { !it.isFolder && it.isEncrypted } + val containsEncryptedFolder = files.any { it.isFolder && it.isEncrypted } + val containsLocked = files.any { it.isLocked } + val containsShared = files.any { it.isSharedWithMe || it.isSharedViaLink || it.isSharedWithSharee } + val anyDown = files.any { it.isDown } + val allDown = files.all { it.isDown } + val allFavorites = files.all { it.isFavorite } + val noneFavorite = files.none { it.isFavorite } + + val firstFile: OCFile + get() = files.first() + + val isSingleFile: Boolean + get() = isSingleSelection && !firstFile.isFolder + + val isSingleFolder: Boolean + get() = isSingleSelection && firstFile.isFolder + + val isSingleImage: Boolean + get() = isSingleSelection && MimeTypeUtil.isImage(firstFile) + + val isSingleMedia: Boolean + get() = isSingleSelection && (MimeTypeUtil.isVideo(firstFile) || MimeTypeUtil.isAudio(firstFile)) + + val isEncryptedFolder: Boolean + get() = isSingleFolder && firstFile.isEncrypted + + val isGroupFolder: Boolean + get() = firstFile.mounted() + + fun isEmptyFolder(): Boolean { + if (!isSingleFolder) return false + + val file = firstFile + + return file.fileLength == EMPTY_FILE_LENGTH && storageManager.getFolderContent(file, false).isEmpty() + } + + fun hasEncryptedParent(): Boolean = storageManager.getFileById(firstFile.parentId)?.isEncrypted == true + + fun containsReadOnlyFile(): Boolean = files.any { storageManager.isReadOnly(it) } + + fun containsEncryptedFolderContent(): Boolean = containsEncryptedFolder || containsFolderWithEncryptedChild() + + private fun containsFolderWithEncryptedChild(): Boolean = files.any { file -> + file.isFolder && storageManager.getFolderContent(file, false).any { it.isEncrypted } + } + + companion object { + const val SINGLE_SELECT_ITEMS = 1 + private const val EMPTY_FILE_LENGTH = 0L + } +} diff --git a/app/src/main/java/com/owncloud/android/files/FileSynchronizationChecker.kt b/app/src/main/java/com/owncloud/android/files/FileSynchronizationChecker.kt new file mode 100644 index 000000000000..26b8acbd9131 --- /dev/null +++ b/app/src/main/java/com/owncloud/android/files/FileSynchronizationChecker.kt @@ -0,0 +1,40 @@ +/* + * Nextcloud - Android Client + * + * SPDX-FileCopyrightText: 2026 Alper Ozturk + * SPDX-License-Identifier: AGPL-3.0-or-later + */ +package com.owncloud.android.files + +import com.nextcloud.client.account.User +import com.nextcloud.client.jobs.download.FileDownloadHelper +import com.nextcloud.client.jobs.upload.FileUploadHelper +import com.owncloud.android.datamodel.OCFile +import com.owncloud.android.ui.activity.ComponentsGetter + +class FileSynchronizationChecker( + private val files: Collection, + private val componentsGetter: ComponentsGetter, + private val user: User +) { + fun isAnyFileSynchronizing(): Boolean = anyFileComparedWithRemote() || anyFileDownloading() || anyFileUploading() + + private fun anyFileComparedWithRemote(): Boolean { + val operationsServiceBinder = componentsGetter.operationsServiceBinder ?: return false + + return files.any { operationsServiceBinder.isSynchronizing(user, it) } + } + + private fun anyFileDownloading(): Boolean { + val fileDownloadHelper = FileDownloadHelper.instance() + + return files.any { fileDownloadHelper.isDownloading(user, it) } + } + + private fun anyFileUploading(): Boolean { + val fileUploadHelper = FileUploadHelper.instance() + val accountName = user.accountName + + return files.any { fileUploadHelper.isUploading(it.remotePath, accountName) } + } +} From 84b883cc42bf4b2ecfa6ea8f35a728e0933ecf5f Mon Sep 17 00:00:00 2001 From: alperozturk96 Date: Wed, 18 Nov 2026 08:43:16 +0100 Subject: [PATCH 3/3] codacy Signed-off-by: alperozturk96 --- .../nextcloud/ui/fileactions/FileAction.kt | 13 +++++++ .../owncloud/android/files/FileMenuFilter.kt | 35 ++++++------------- 2 files changed, 24 insertions(+), 24 deletions(-) diff --git a/app/src/main/java/com/nextcloud/ui/fileactions/FileAction.kt b/app/src/main/java/com/nextcloud/ui/fileactions/FileAction.kt index e5310f9129f2..74b7edec8066 100644 --- a/app/src/main/java/com/nextcloud/ui/fileactions/FileAction.kt +++ b/app/src/main/java/com/nextcloud/ui/fileactions/FileAction.kt @@ -80,6 +80,19 @@ enum class FileAction( } companion object { + val READ_ONLY_HIDDEN_ACTIONS = listOf( + R.id.action_remove_file, + R.id.action_rename_file, + R.id.action_move_or_copy, + R.id.action_edit, + R.id.action_encrypted, + R.id.action_unset_encrypted, + R.id.action_lock_file, + R.id.action_unlock_file, + R.id.action_favorite, + R.id.action_unset_favorite + ) + /** * All file actions, in the order they should be displayed */ diff --git a/app/src/main/java/com/owncloud/android/files/FileMenuFilter.kt b/app/src/main/java/com/owncloud/android/files/FileMenuFilter.kt index 74f978f29362..1c71b9f9b999 100644 --- a/app/src/main/java/com/owncloud/android/files/FileMenuFilter.kt +++ b/app/src/main/java/com/owncloud/android/files/FileMenuFilter.kt @@ -52,7 +52,8 @@ class FileMenuFilter internal constructor( val capability = storageManager.getCapability(user.accountName) return buildList { - addAll(getHiddenFileActions(capability, synchronizing)) + addAll(getHiddenEditActions(capability, synchronizing)) + addAll(getHiddenDownloadActions(synchronizing)) addAll(getHiddenSelectionActions(inSingleFileFragment)) addAll(getHiddenSyncActions(synchronizing)) addAll(getHiddenShareActions(capability, inSingleFileFragment)) @@ -61,25 +62,26 @@ class FileMenuFilter internal constructor( addAll(getHiddenMediaActions()) addAll(getHiddenLockActions(capability.filesLockingVersion != null)) addAll(FileAction.getActionsToHide(files.toHashSet())) - if (selection.containsReadOnlyFile()) addAll(READ_ONLY_HIDDEN_ACTIONS) + if (selection.containsReadOnlyFile()) addAll(FileAction.READ_ONLY_HIDDEN_ACTIONS) } } - private fun getHiddenFileActions(capability: OCCapability, synchronizing: Boolean) = buildList { + private fun getHiddenEditActions(capability: OCCapability, synchronizing: Boolean) = buildList { val containsEncryptedOrLocked = selection.containsEncrypted || selection.containsLocked if (isEditHidden(capability)) add(R.id.action_edit) - if (selection.containsFolder || selection.anyDown || synchronizing) add(R.id.action_download_file) - if (selection.containsFolder) add(R.id.action_export_file) if (!selection.isSingleSelection || synchronizing || containsEncryptedOrLocked) add(R.id.action_rename_file) if (synchronizing || containsEncryptedOrLocked) add(R.id.action_move_or_copy) if (synchronizing || selection.containsLocked || selection.containsEncryptedFolderContent()) { add(R.id.action_remove_file) } + } + + private fun getHiddenDownloadActions(synchronizing: Boolean) = buildList { + if (selection.containsFolder || selection.anyDown || synchronizing) add(R.id.action_download_file) + if (selection.containsFolder) add(R.id.action_export_file) if (!selection.isSingleFile || !selection.anyDown || synchronizing) add(R.id.action_open_file_with) if (isOpenInWebEditorHidden()) add(R.id.action_open_in_web_editor) - if (isPinToHomeHidden()) add(R.id.action_pin_to_homescreen) - if (!selection.firstFile.isOfflineOperation) add(R.id.action_retry) } private fun getHiddenSelectionActions(inSingleFileFragment: Boolean) = buildList { @@ -88,12 +90,14 @@ class FileMenuFilter internal constructor( if (inSingleFileFragment || allFilesSelected || overflowMenu) add(R.id.action_select_all_action_menu) if (inSingleFileFragment || overflowMenu) add(R.id.action_deselect_all_action_menu) if (!selection.isSingleSelection) add(R.id.action_see_details) + if (isPinToHomeHidden()) add(R.id.action_pin_to_homescreen) } private fun getHiddenSyncActions(synchronizing: Boolean) = buildList { val nothingToSync = !selection.anyDown && !selection.containsFolder if (!synchronizing) add(R.id.action_cancel_sync) + if (!selection.firstFile.isOfflineOperation) add(R.id.action_retry) if (nothingToSync || synchronizing || selection.containsEncrypted) { add(R.id.action_sync_file) add(R.id.action_sync_all_files) @@ -217,21 +221,4 @@ class FileMenuFilter internal constructor( return canUserUnlockFile(userId, selection.firstFile) } - - companion object { - const val SEND_OFF: String = "off" - - private val READ_ONLY_HIDDEN_ACTIONS = listOf( - R.id.action_remove_file, - R.id.action_rename_file, - R.id.action_move_or_copy, - R.id.action_edit, - R.id.action_encrypted, - R.id.action_unset_encrypted, - R.id.action_lock_file, - R.id.action_unlock_file, - R.id.action_favorite, - R.id.action_unset_favorite - ) - } }