From 5a4bbcbda5f491c3750a40f7327bb45a9c931fa8 Mon Sep 17 00:00:00 2001 From: daniele-verducci Date: Thu, 19 Nov 2026 14:35:39 +0100 Subject: [PATCH 1/2] Fix images attached to notes not shown Signed-off-by: daniele-verducci --- .../owncloud/notes/edit/NotePreviewFragment.java | 6 ++++++ .../niedermann/owncloud/notes/util/NotesExtensions.kt | 10 ++++++++++ 2 files changed, 16 insertions(+) create mode 100644 app/src/main/java/it/niedermann/owncloud/notes/util/NotesExtensions.kt diff --git a/app/src/main/java/it/niedermann/owncloud/notes/edit/NotePreviewFragment.java b/app/src/main/java/it/niedermann/owncloud/notes/edit/NotePreviewFragment.java index e7bbde4d2..4024ad539 100644 --- a/app/src/main/java/it/niedermann/owncloud/notes/edit/NotePreviewFragment.java +++ b/app/src/main/java/it/niedermann/owncloud/notes/edit/NotePreviewFragment.java @@ -39,6 +39,7 @@ import it.niedermann.owncloud.notes.databinding.FragmentNotePreviewBinding; import it.niedermann.owncloud.notes.persistence.entity.Note; import it.niedermann.owncloud.notes.shared.util.SSOUtil; +import it.niedermann.owncloud.notes.util.NotesExtensionsKt; import kotlin.Unit; public class NotePreviewFragment extends SearchableBaseNoteFragment implements OnRefreshListener { @@ -152,8 +153,13 @@ protected void onNoteLoaded(Note note) { lifecycleScopeIOJob(() -> { final String content = note.getContent(); changedText = content; + final String imageUrlPrefix = NotesExtensionsKt.getAttachmentImageUrlPrefix( + note, + repo.getAccountById(note.getAccountId()) + ); onMainThread(() -> { + binding.singleNoteContent.setMarkdownImageUrlPrefix(imageUrlPrefix); binding.singleNoteContent.setMarkdownString(content, setScrollY); final var activity = getActivity(); diff --git a/app/src/main/java/it/niedermann/owncloud/notes/util/NotesExtensions.kt b/app/src/main/java/it/niedermann/owncloud/notes/util/NotesExtensions.kt new file mode 100644 index 000000000..27078c863 --- /dev/null +++ b/app/src/main/java/it/niedermann/owncloud/notes/util/NotesExtensions.kt @@ -0,0 +1,10 @@ +package it.niedermann.owncloud.notes.util + +import it.niedermann.owncloud.notes.persistence.entity.Account +import it.niedermann.owncloud.notes.persistence.entity.Note + +private const val ATTACHMENT_ENDPOINT = "/index.php/apps/notes/api/v1/attachment/" + + +fun Note.getAttachmentImageUrlPrefix(account: Account): String = + remoteId?.let { "${account.url}${ATTACHMENT_ENDPOINT}$it?path=" }.orEmpty() \ No newline at end of file From b46827c4ae69db3ee598d32272eef9990936f6f2 Mon Sep 17 00:00:00 2001 From: daniele-verducci Date: Thu, 19 Nov 2026 15:29:58 +0100 Subject: [PATCH 2/2] Missing copyright Signed-off-by: daniele-verducci --- .../it/niedermann/owncloud/notes/util/NotesExtensions.kt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/src/main/java/it/niedermann/owncloud/notes/util/NotesExtensions.kt b/app/src/main/java/it/niedermann/owncloud/notes/util/NotesExtensions.kt index 27078c863..5c93b6fcf 100644 --- a/app/src/main/java/it/niedermann/owncloud/notes/util/NotesExtensions.kt +++ b/app/src/main/java/it/niedermann/owncloud/notes/util/NotesExtensions.kt @@ -1,3 +1,9 @@ +/* + * Nextcloud Notes - Android Client + * + * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors + * SPDX-License-Identifier: GPL-3.0-or-later + */ package it.niedermann.owncloud.notes.util import it.niedermann.owncloud.notes.persistence.entity.Account