From 819cac35bd2aee0e4022eb3a5d74ac90b0742a07 Mon Sep 17 00:00:00 2001 From: Marcel Hibbe Date: Fri, 20 Nov 2026 11:53:16 +0100 Subject: [PATCH 1/2] chore: ignore app bundles fastlane releasePhase1 writes the app bundle to release/nextcloud-notes-gplay-.aab, next to the APKs. Without ignoring it, the working tree is not clean and releasePhase2 stops. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Marcel Hibbe --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index a642eb42e..a29a66899 100644 --- a/.gitignore +++ b/.gitignore @@ -5,6 +5,7 @@ # SPDX-License-Identifier: GPL-3.0-or-later # built application files *.apk +*.aab *.ap_ # files for the dex VM From aa75d9299dc357d30724655f67aa30934c886f4b Mon Sep 17 00:00:00 2001 From: Marcel Hibbe Date: Fri, 20 Nov 2026 12:52:25 +0100 Subject: [PATCH 2/2] chore(fastlane): remove release passwords and token from the environment The keystore passwords and the GitHub API token are no longer read from environment variables set in the shell configuration. The release lanes of the shared common.Fastfile from nextcloud/android-config ask for them instead, so GRADLE_SIGNING_PROPERTIES only names the keystore file and the key alias. Needs the common.Fastfile of nextcloud/android-config that asks for the passwords; merge after its sync pull request. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Marcel Hibbe --- fastlane/Fastfile | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/fastlane/Fastfile b/fastlane/Fastfile index ba203908c..2e306f5e5 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -5,10 +5,10 @@ ## config # add following to your shell rc: # export FASTLANE_NOTES_UPLOAD_STORE_FILE="" -# export FASTLANE_NOTES_UPLOAD_STORE_PASSWORD="" # export FASTLANE_NOTES_UPLOAD_KEY_ALIAS="" -# export FASTLANE_NOTES_UPLOAD_KEY_PASSWORD="" -# export FASTLANE_NEXTCLOUD_GITHUB_API_TOKEN="" +# +# Passwords and the GitHub API token are not read from the environment, +# they are asked for when a release lane starts (see common.Fastfile). @@ -18,11 +18,10 @@ skip_docs APP="notes" REPO="nextcloud/notes-android" +# passwords are added at build time, see askForSigningPasswords in common.Fastfile GRADLE_SIGNING_PROPERTIES = { "android.injected.signing.store.file" => ENV["FASTLANE_NOTES_UPLOAD_STORE_FILE"], - "android.injected.signing.store.password" => ENV["FASTLANE_NOTES_UPLOAD_STORE_PASSWORD"], "android.injected.signing.key.alias" => ENV["FASTLANE_NOTES_UPLOAD_KEY_ALIAS"], - "android.injected.signing.key.password" => ENV["FASTLANE_NOTES_UPLOAD_KEY_PASSWORD"], }.freeze import("./common.Fastfile")