Skip to content

remesh docs advertise an IntrinsicGeometryInterface& overload the code doesn't have #247

Description

@designbynumbers

Version: master @ 1e8e43d2 (and the docs site as of 2026-06-01).

The remeshing docs (https://geometry-central.net/surface/algorithms/remeshing/)
show:

void remesh(ManifoldSurfaceMesh& mesh, IntrinsicGeometryInterface& geom, RemeshOptions options = defaultRemeshOptions);
void remesh(ManifoldSurfaceMesh& mesh, IntrinsicGeometryInterface& geom, MutationManager& mm, RemeshOptions options = defaultRemeshOptions);

But include/geometrycentral/surface/remeshing.h (unchanged since
2022-12-09) declares only VertexPositionGeometry& overloads, and the
implementation uses geom.vertexPositions[...] / geom.faceNormal(...)
(smoothing to circumcenters, computing split midpoints in 3D) — so it
genuinely requires an embedded geometry and cannot run on a bare
IntrinsicGeometryInterface.

So either the docs are aspirational/stale, or an intended
IntrinsicGeometryInterface& overload was never merged. Either way the
documented signature won't compile against the current code. (Context: we
were hoping to remesh an intrinsic triangulation directly; the docs implied
it was supported.)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions