From bdec92d870ff55541437d97349393a612197d35d Mon Sep 17 00:00:00 2001 From: Philipp Dunkel Date: Tue, 8 Sep 2026 08:48:36 +0200 Subject: [PATCH] test: skip C++ symbols in tick-processor-arguments The test only checks that a CLI flag is passed through to the V8 tick processor, but processing a --prof log makes the tick processor resolve the C++ symbols of every shared library listed in it by shelling out to nm (plus c++filt on macOS) once per library. On a --shared build that links around a hundred dylibs this takes longer than the test timeout on the macOS x86_64 GitHub Actions runner, and the outcome depends on the host toolchain rather than on node. Drop the shared-library entries from the log before processing it so the test exercises argument handling only. C++ symbol resolution is covered by test/tick-processor. Signed-off-by: Philipp Dunkel --- test/parallel/test-tick-processor-arguments.js | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/test/parallel/test-tick-processor-arguments.js b/test/parallel/test-tick-processor-arguments.js index 406b13b676d7..a2d99192f979 100644 --- a/test/parallel/test-tick-processor-arguments.js +++ b/test/parallel/test-tick-processor-arguments.js @@ -19,6 +19,17 @@ const files = fs.readdirSync(tmpdir.path); const logfile = files.find((name) => /\.log$/.test(name)); assert(logfile); +// Drop the shared-library entries: the tick processor resolves the C++ +// symbols of every listed library through nm (and c++filt on macOS), which is +// slow on builds that link many shared libraries and depends on the host +// toolchain. This test only checks that CLI arguments reach the tick +// processor; C++ symbol resolution is covered by test/tick-processor. +const logpath = tmpdir.resolve(logfile); +fs.writeFileSync(logpath, fs.readFileSync(logpath, 'utf8') + .split('\n') + .filter((line) => !line.startsWith('shared-library,')) + .join('\n')); + // Make sure that the --preprocess argument is passed through correctly, // as an example flag listed in deps/v8/tools/tickprocessor.js. // Any of the other flags there should work for this test too, if --preprocess