From f94a68d132bdb1fb0fbba530575411cd37b217f1 Mon Sep 17 00:00:00 2001
From: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com>
Date: Mon, 29 Jun 2026 12:19:41 +0800
Subject: [PATCH] =?UTF-8?q?feat(cli):=20wire=20SDUI=20manifest=20=E2=80=94?=
 =?UTF-8?q?=20build-console.sh=20generates=20it,=20os=20build=20resolves?=
 =?UTF-8?q?=20from=20@objectstack/console=20(ADR-0080)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

build-console.sh: guarded best-effort step that boots the just-built console's
registry and dumps the public-tier manifest into @objectstack/console/dist/
sdui.manifest.json (skips on a sha without the dump tooling; never fails the
build). validate.ts: resolve the manifest from @objectstack/console too (cli
already deps it) → full component/prop validation when present, parse-level
otherwise. Activation = bump .objectui-sha to >=96b1293 (a release step).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 .changeset/sdui-manifest-wiring.md    |  5 +++++
 packages/cli/src/commands/validate.ts |  7 +++++++
 scripts/build-console.sh              | 23 +++++++++++++++++++++++
 3 files changed, 35 insertions(+)
 create mode 100644 .changeset/sdui-manifest-wiring.md

diff --git a/.changeset/sdui-manifest-wiring.md b/.changeset/sdui-manifest-wiring.md
new file mode 100644
index 0000000000..15eca1580a
--- /dev/null
+++ b/.changeset/sdui-manifest-wiring.md
@@ -0,0 +1,5 @@
+---
+"@objectstack/cli": minor
+---
+
+ADR-0080: wire the SDUI manifest end-to-end. `build-console.sh` now (best-effort, guarded) generates `sdui.manifest.json` from the just-built console's public-tier registry into `@objectstack/console/dist/`; the `os build` / `os validate` JSX gate resolves the manifest from `@objectstack/console` (in addition to the project root) and does full component/prop validation when present. Activating full validation requires bumping `.objectui-sha` to an objectui commit that ships the dump tooling (>=96b1293); until then the gate falls back to parse-level and the build step skips.
diff --git a/packages/cli/src/commands/validate.ts b/packages/cli/src/commands/validate.ts
index 523392c275..e0c6084cdf 100644
--- a/packages/cli/src/commands/validate.ts
+++ b/packages/cli/src/commands/validate.ts
@@ -2,6 +2,7 @@
 
 import { Args, Command, Flags } from '@oclif/core';
 import { existsSync, readFileSync } from 'node:fs';
+import { createRequire } from 'node:module';
 import { join } from 'node:path';
 import chalk from 'chalk';
 import { ZodError } from 'zod';
@@ -179,6 +180,12 @@ export default class Validate extends Command {
       try {
         const mp = join(process.cwd(), 'sdui.manifest.json');
         if (existsSync(mp)) sduiManifest = JSON.parse(readFileSync(mp, 'utf8'));
+        if (!sduiManifest) {
+          // Fall back to the manifest shipped inside @objectstack/console
+          // (built from objectui's public-tier registry; cli already deps it).
+          const cp = createRequire(import.meta.url).resolve('@objectstack/console/dist/sdui.manifest.json');
+          if (existsSync(cp)) sduiManifest = JSON.parse(readFileSync(cp, 'utf8'));
+        }
       } catch { /* fall back to parse-level */ }
       const jsxFindings = validateJsxPages(
         result.data as Record<string, unknown>,
diff --git a/scripts/build-console.sh b/scripts/build-console.sh
index 81aeb59c0d..397996ada5 100755
--- a/scripts/build-console.sh
+++ b/scripts/build-console.sh
@@ -128,3 +128,26 @@ cp -R "$CONSOLE_DIST" "$TARGET"
 
 BYTES="$(du -sk "$TARGET" 2>/dev/null | awk '{print $1}')"
 echo "✓ @objectstack/console dist ready (${BYTES} KB) from objectui@${PINNED_SHA:0:12}"
+
+# ADR-0080: generate the public-tier SDUI manifest from the just-built console's
+# registry so the framework os-build JSX gate can do full component/prop
+# validation. Best-effort and GUARDED: skips on a sha without the dump tooling,
+# and never fails the console build (the gate falls back to parse-level).
+DUMP_PAGE="${BUILD_ROOT}/apps/console/dev/manifest-dump.html"
+DUMP_SCRIPT="${BUILD_ROOT}/scripts/dump-public-manifest.mjs"
+if [[ -f "$DUMP_PAGE" && -f "$DUMP_SCRIPT" ]]; then
+  echo "→ Generating SDUI public-tier manifest (ADR-0080)..."
+  pushd "$BUILD_ROOT" > /dev/null
+  pnpm --filter @object-ui/console exec vite dev --port 5180 > /tmp/sdui-dump-dev.log 2>&1 &
+  DUMP_DEV_PID=$!
+  for _ in $(seq 1 90); do curl -sf "http://localhost:5180/" > /dev/null 2>&1 && break; sleep 1; done
+  if BASE_URL="http://localhost:5180" OUT="${TARGET}/sdui.manifest.json" node scripts/dump-public-manifest.mjs; then
+    echo "✓ wrote ${TARGET}/sdui.manifest.json"
+  else
+    echo "⚠ manifest generation failed — os-build JSX gate falls back to parse-level (non-fatal)"
+  fi
+  kill "$DUMP_DEV_PID" 2>/dev/null || true
+  popd > /dev/null
+else
+  echo "ℹ manifest dump tooling not present at objectui@${PINNED_SHA:0:12} — skipping (bump .objectui-sha to >=96b1293 to enable full JSX validation)"
+fi