Check with open-java-format 2.98.0.2, and on Windows too

open-java-format 2.98.0.2 has a single style, so the action and the pre-commit hook stop passing --ojf, which that version only warns about, and both default to 2.98.0.2. A workflow that still pins 2.98.0.1 would now check in Google style, so this goes out as v2, and such a workflow stays on v1.

2.98.0.2 also ships a native binary for Windows on x86-64. The action and the hook recognise a Windows runner or Git Bash by uname, download the binary with its .exe extension, and keep that extension on disk.

The CI used to run the action on a repository without Java files, so it checked nothing. It now writes a formatted file and one that is not, and expects the action to pass the first and fail the second, on Linux and macOS on both architectures and on Windows; the hook runs through the same two cases in a scratch repository.

Author: abashev

.github/workflows/ci.yml

@@ -14,15 +14,57 @@ jobs:
           fetch-depth: 0
       - uses: ./
         with:
-          version: '2.98.0.1'
+          version: '2.98.0.2'
           mode: changed
 
-  test-all:
-    name: Test mode=all
-    runs-on: ubuntu-latest
+  # The action and the hook on every platform they support, with a file that is formatted and one that
+  # is not. The repository itself has no Java files, so the tests write their own.
+  test-platforms:
+    name: Test on ${{ matrix.os }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, ubuntu-24.04-arm, macos-latest, macos-15-intel, windows-latest]
+    defaults:
+      run:
+        shell: bash
     steps:
       - uses: actions/checkout@v7
-      - uses: ./
+
+      - name: Write a formatted file
+        run: printf 'class Formatted {\n    int x;\n}\n' > Formatted.java
+
+      - name: Check it
+        uses: ./
+        with:
+          version: '2.98.0.2'
+          mode: all
+
+      - name: Write a file that is not formatted
+        run: printf 'class Unformatted{int x;}\n' > Unformatted.java
+
+      - name: Check it, expecting a failure
+        id: unformatted
+        continue-on-error: true
+        uses: ./
         with:
-          version: '2.98.0.1'
+          version: '2.98.0.2'
           mode: all
+
+      - name: Make sure the check failed
+        run: test "${{ steps.unformatted.outcome }}" = failure
+
+      - name: Run the pre-commit hook on a file that is not formatted, then on a formatted one
+        run: |
+          git init -q hook-test
+          cd hook-test
+          printf 'class Hook{int x;}\n' > Hook.java
+          git add Hook.java
+          if bash ../pre-commit; then
+            echo "::error::The hook accepted a file that is not formatted"
+            exit 1
+          fi
+          printf 'class Hook {\n    int x;\n}\n' > Hook.java
+          git add Hook.java
+          bash ../pre-commit

README.md

@@ -9,16 +9,18 @@ No Java, Maven, or Gradle required — downloads a native binary from Maven Cent
 ```yaml
 - uses: actions/checkout@v7
 
-- uses: openjavaformat/open-java-format-action@v1
+- uses: openjavaformat/open-java-format-action@v2
   with:
-    version: '2.98.0.1'
+    version: '2.98.0.2'
 ```
 
+v2 is for open-java-format 2.98.0.2 and later, which has a single style. A workflow that pins 2.98.0.1 stays on `@v1`, which passes that version the `--ojf` flag it needs.
+
 ## Inputs
 
 | Input | Required | Default | Description |
 |-------|----------|---------|-------------|
-| `version` | yes | `2.98.0.1` | Version of the open-java-format native binary, one of those on [Maven Central](https://repo1.maven.org/maven2/dev/openjavaformat/open-java-format-native/) |
+| `version` | yes | `2.98.0.2` | Version of the open-java-format native binary, one of those on [Maven Central](https://repo1.maven.org/maven2/dev/openjavaformat/open-java-format-native/) |
 | `mode` | no | `changed` | `changed` — only files from PR or push; `all` — every `.java` file in repo |
 
 ## How `mode: changed` works
@@ -32,12 +34,12 @@ No Java, Maven, or Gradle required — downloads a native binary from Maven Cent
 - If all files are formatted correctly → passes ✅
 - If any file has formatting issues → lists unformatted files and fails ❌
 
-Files are checked in the open-java-format style, `--ojf` (formerly `--palantir`). When the check fails, fix locally with a native binary or the runnable jar from the [open-java-format releases](https://github.com/openjavaformat/open-java-format/releases):
+Files are checked in the open-java-format style, the formatter's only style. When the check fails, fix locally with a native binary or the runnable jar from the [open-java-format releases](https://github.com/openjavaformat/open-java-format/releases):
 
 ```bash
-open-java-format --ojf --replace <files>
+open-java-format --replace <files>
 # or, with Java 21 or later
-java -jar open-java-format-2.98.0.1-all.jar --ojf --replace <files>
+java -jar open-java-format-2.98.0.2-all.jar --replace <files>
 ```
 
 ## Excluding files
@@ -78,9 +80,9 @@ jobs:
     steps:
       - uses: actions/checkout@v7
 
-      - uses: openjavaformat/open-java-format-action@v1
+      - uses: openjavaformat/open-java-format-action@v2
         with:
-          version: '2.98.0.1'
+          version: '2.98.0.2'
           mode: ${{ github.event_name == 'push' && 'all' || 'changed' }}
 ```
 
@@ -107,5 +109,6 @@ The hook pins its own formatter version in `FORMATTER_VERSION` at the top of the
 - Linux aarch64 (glibc)
 - macOS aarch64 (Apple Silicon)
 - macOS x86_64 (Intel)
+- Windows x86_64
 
-There is no native binary for Windows or for musl-based Linux such as Alpine.
+There is no native binary for Windows on ARM or for musl-based Linux such as Alpine.

action.yml

@@ -10,7 +10,7 @@ inputs:
   version:
     description: 'Version of open-java-format to use'
     required: true
-    default: '2.98.0.1'
+    default: '2.98.0.2'
   mode:
     description: 'Which files to check: "changed" for files from PR/push, "all" for every .java file'
     required: false
@@ -31,13 +31,25 @@ runs:
           Linux-aarch64) SUFFIX="linux-glibc_aarch64" ;;
           Darwin-arm64)  SUFFIX="macos_aarch64" ;;
           Darwin-x86_64) SUFFIX="macos_x86-64" ;;
+          MINGW*-x86_64 | MSYS*-x86_64) SUFFIX="windows_x86-64" ;;
           *)
-            echo "::error::No open-java-format native binary for ${OS}-${ARCH}. Supported: Linux x86_64, Linux aarch64, macOS aarch64, macOS x86_64."
+            echo "::error::No open-java-format native binary for ${OS}-${ARCH}. Supported: Linux x86_64, Linux aarch64, macOS aarch64, macOS x86_64, Windows x86_64."
             exit 1
             ;;
         esac
 
+        # The Windows binary is an .exe, on Maven Central and on disk. It exists from 2.98.0.2 on.
+        if [ "$SUFFIX" = "windows_x86-64" ]; then
+          EXTENSION="exe"
+          BINARY="open-java-format.exe"
+        else
+          EXTENSION="bin"
+          BINARY="open-java-format"
+        fi
+
         echo "suffix=$SUFFIX" >> "$GITHUB_OUTPUT"
+        echo "extension=$EXTENSION" >> "$GITHUB_OUTPUT"
+        echo "binary=$BINARY" >> "$GITHUB_OUTPUT"
 
     - name: Check for newer open-java-format version
       shell: bash
@@ -68,7 +80,7 @@ runs:
       id: cache
       uses: actions/cache@v6
       with:
-        path: ${{ github.action_path }}/open-java-format
+        path: ${{ github.action_path }}/${{ steps.platform.outputs.binary }}
         key: open-java-format-${{ inputs.version }}-${{ steps.platform.outputs.suffix }}
 
     - name: Download open-java-format native binary
@@ -78,9 +90,9 @@ runs:
         VERSION="${{ inputs.version }}"
         SUFFIX="${{ steps.platform.outputs.suffix }}"
         BASE_URL="https://repo1.maven.org/maven2/dev/openjavaformat/open-java-format-native/${VERSION}"
-        ARTIFACT="open-java-format-native-${VERSION}-nativeImage-${SUFFIX}.bin"
+        ARTIFACT="open-java-format-native-${VERSION}-nativeImage-${SUFFIX}.${{ steps.platform.outputs.extension }}"
         DOWNLOAD_URL="${BASE_URL}/${ARTIFACT}"
-        BINARY="${{ github.action_path }}/open-java-format"
+        BINARY="${{ github.action_path }}/${{ steps.platform.outputs.binary }}"
 
         echo "Downloading open-java-format ${VERSION} (${SUFFIX})..."
         if ! curl -sSfL -o "$BINARY" "$DOWNLOAD_URL"; then
@@ -93,7 +105,7 @@ runs:
 
     - name: Set binary path
       shell: bash
-      run: echo "OJF_BINARY=${{ github.action_path }}/open-java-format" >> "$GITHUB_ENV"
+      run: echo "OJF_BINARY=${{ github.action_path }}/${{ steps.platform.outputs.binary }}" >> "$GITHUB_ENV"
 
     - name: Collect files to check
       shell: bash
@@ -159,7 +171,7 @@ runs:
         UNFORMATTED=()
         for FILE in $OJF_FILES; do
           if [ -f "$FILE" ]; then
-            if ! "$OJF_BINARY" --ojf --dry-run --set-exit-if-changed "$FILE" > /dev/null 2>&1; then
+            if ! "$OJF_BINARY" --dry-run --set-exit-if-changed "$FILE" > /dev/null 2>&1; then
               UNFORMATTED+=("$FILE")
             fi
           fi
@@ -174,7 +186,7 @@ runs:
           done
           echo ""
           echo "Run open-java-format locally to fix:"
-          echo "  open-java-format --ojf --replace ${UNFORMATTED[*]}"
+          echo "  open-java-format --replace ${UNFORMATTED[*]}"
           exit 1
         fi
 

example-usage.yml

@@ -15,7 +15,7 @@ jobs:
       - uses: actions/checkout@v7
 
       - name: Check formatting
-        uses: openjavaformat/open-java-format-action@v1
+        uses: openjavaformat/open-java-format-action@v2
         with:
-          version: '2.98.0.1'
+          version: '2.98.0.2'
           mode: ${{ github.event_name == 'push' && 'all' || 'changed' }}

pre-commit

@@ -1,11 +1,17 @@
 #!/usr/bin/env bash
 set -euo pipefail
 
-FORMATTER_VERSION="2.98.0.1"
+FORMATTER_VERSION="2.98.0.2"
 CACHE_DIR="${HOME}/.cache/open-java-format"
-BINARY="${CACHE_DIR}/open-java-format-${FORMATTER_VERSION}"
 BASE_URL="https://repo1.maven.org/maven2/dev/openjavaformat/open-java-format-native/${FORMATTER_VERSION}"
 
+# The Windows binary is an .exe, on Maven Central and on disk.
+case "$(uname -s)" in
+    MINGW* | MSYS* | CYGWIN*) EXTENSION="exe"; EXE=".exe" ;;
+    *) EXTENSION="bin"; EXE="" ;;
+esac
+BINARY="${CACHE_DIR}/open-java-format-${FORMATTER_VERSION}${EXE}"
+
 # Read exclude patterns from .open-java-format-exclude (repo root), if present.
 # Each non-empty, non-comment line is a git pathspec whose matches are skipped.
 # This file is the single source of exclusions, shared with the GitHub Action.
@@ -41,14 +47,15 @@ if [ ! -x "$BINARY" ]; then
         Linux-aarch64) SUFFIX="linux-glibc_aarch64" ;;
         Darwin-arm64)  SUFFIX="macos_aarch64" ;;
         Darwin-x86_64) SUFFIX="macos_x86-64" ;;
+        MINGW*-x86_64 | MSYS*-x86_64 | CYGWIN*-x86_64) SUFFIX="windows_x86-64" ;;
         *)
             echo "ERROR: No open-java-format native binary for ${OS}-${ARCH}."
-            echo "       Supported: Linux x86_64, Linux aarch64, macOS aarch64, macOS x86_64."
+            echo "       Supported: Linux x86_64, Linux aarch64, macOS aarch64, macOS x86_64, Windows x86_64."
             exit 1
             ;;
     esac
 
-    ARTIFACT="open-java-format-native-${FORMATTER_VERSION}-nativeImage-${SUFFIX}.bin"
+    ARTIFACT="open-java-format-native-${FORMATTER_VERSION}-nativeImage-${SUFFIX}.${EXTENSION}"
     DOWNLOAD_URL="${BASE_URL}/${ARTIFACT}"
 
     echo "Downloading open-java-format ${FORMATTER_VERSION} (${SUFFIX})..."
@@ -68,7 +75,7 @@ fi
 UNFORMATTED=()
 for FILE in $STAGED_FILES; do
     if [ -f "$FILE" ]; then
-        if ! "$BINARY" --ojf --dry-run --set-exit-if-changed "$FILE" > /dev/null 2>&1; then
+        if ! "$BINARY" --dry-run --set-exit-if-changed "$FILE" > /dev/null 2>&1; then
             UNFORMATTED+=("$FILE")
         fi
     fi
@@ -84,7 +91,7 @@ if [ ${#UNFORMATTED[@]} -gt 0 ]; then
     echo ""
     echo "Run the following command to fix:"
     echo ""
-    echo "  $BINARY --ojf --replace ${UNFORMATTED[*]}"
+    echo "  $BINARY --replace ${UNFORMATTED[*]}"
     echo ""
     exit 1
 fi