Skip to content

Commit 3807354

Browse files
author
Dean Troyer
committed
Command docs: group
Fix up formatting for group command docs and help Change-Id: Icda79842d52da90d5eac2b0fdbc0d576d371378d
1 parent 8132072 commit 3807354

3 files changed

Lines changed: 45 additions & 42 deletions

File tree

‎doc/source/command-objects/group.rst‎

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -16,18 +16,18 @@ Add user to group
1616
<group>
1717
<user>
1818
19-
.. option:: <group>
19+
.. describe:: <group>
2020

21-
Group that user will be added to (name or ID)
21+
Group to contain <user> (name or ID)
2222

23-
.. option:: <user>
23+
.. describe:: <user>
2424

25-
User to add to group (name or ID)
25+
User to add to <group> (name or ID)
2626

2727
group contains user
2828
-------------------
2929

30-
Check user in group
30+
Check user membership in group
3131

3232
.. program:: group contains user
3333
.. code:: bash
@@ -36,11 +36,11 @@ Check user in group
3636
<group>
3737
<user>
3838
39-
.. option:: <group>
39+
.. describe:: <group>
4040

41-
Group to check if user belongs to (name or ID)
41+
Group to check (name or ID)
4242

43-
.. option:: <user>
43+
.. describe:: <user>
4444

4545
User to check (name or ID)
4646

@@ -60,7 +60,7 @@ Create new group
6060
6161
.. option:: --domain <domain>
6262

63-
References the domain ID or name which owns the group
63+
Domain to contain new group (name or ID)
6464

6565
.. option:: --description <description>
6666

@@ -72,7 +72,7 @@ Create new group
7272

7373
If the group already exists, return the existing group data and do not fail.
7474

75-
.. option:: <group-name>
75+
.. describe:: <group-name>
7676

7777
New group name
7878

@@ -90,9 +90,9 @@ Delete group
9090
9191
.. option:: --domain <domain>
9292

93-
Domain where group resides (name or ID)
93+
Domain containing group(s) (name or ID)
9494

95-
.. option:: <group>
95+
.. describe:: <group>
9696

9797
Group(s) to delete (name or ID)
9898

@@ -115,11 +115,11 @@ List groups
115115

116116
.. option:: --user <user>
117117

118-
List group memberships for <user> (name or ID)
118+
Filter group list by <user> (name or ID)
119119

120120
.. option:: --long
121121

122-
List additional fields in output (defaults to false)
122+
List additional fields in output
123123

124124
group remove user
125125
-----------------
@@ -133,13 +133,13 @@ Remove user from group
133133
<group>
134134
<user>
135135
136-
.. option:: <group>
136+
.. describe:: <group>
137137

138-
Group that user will be removed from (name or ID)
138+
Group containing <user> (name or ID)
139139

140-
.. option:: <user>
140+
.. describe:: <user>
141141

142-
User to remove from group (name or ID)
142+
User to remove from <group> (name or ID)
143143

144144
group set
145145
---------
@@ -161,20 +161,20 @@ Set group properties
161161

162162
.. option:: --domain <domain>
163163

164-
New domain that will now own the group (name or ID)
164+
New domain to contain <group> (name or ID)
165165

166166
.. option:: --description <description>
167167

168168
New group description
169169

170-
.. option:: <group>
170+
.. describe:: <group>
171171

172172
Group to modify (name or ID)
173173

174174
group show
175175
----------
176176

177-
Show group details
177+
Display group details
178178

179179
.. program:: group show
180180
.. code:: bash
@@ -185,8 +185,8 @@ Show group details
185185
186186
.. option:: --domain <domain>
187187

188-
Domain where group resides (name or ID)
188+
Domain containing <group> (name or ID)
189189

190-
.. option:: <group>
190+
.. describe:: <group>
191191

192192
Group to display (name or ID)

‎doc/source/commands.rst‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ referring to both Compute and Volume quotas.
8383
* ``endpoint``: (**Identity**) the base URL used to contact a specific service
8484
* ``extension``: (**Compute**, **Identity**, **Volume**) OpenStack server API extensions
8585
* ``flavor``: (**Compute**) pre-defined server configurations: ram, root disk, etc
86-
* ``group``: Identity - a grouping of users
86+
* ``group``: (**Identity**) a grouping of users
8787
* ``host``: Compute - the physical computer running a hypervisor
8888
* ``hypervisor``: Compute - the virtual machine manager
8989
* ``identity provider``: Identity - a source of users and authentication

‎openstackclient/identity/v3/group.py‎

Lines changed: 21 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,12 @@ def get_parser(self, prog_name):
3939
parser.add_argument(
4040
'group',
4141
metavar='<group>',
42-
help='Group that user will be added to (name or ID)',
42+
help='Group to contain <user> (name or ID)',
4343
)
4444
parser.add_argument(
4545
'user',
4646
metavar='<user>',
47-
help='User to add to group (name or ID)',
47+
help='User to add to <group> (name or ID)',
4848
)
4949
return parser
5050

@@ -68,7 +68,7 @@ def take_action(self, parsed_args):
6868

6969

7070
class CheckUserInGroup(command.Command):
71-
"""Check user in group"""
71+
"""Check user membership in group"""
7272

7373
log = logging.getLogger(__name__ + '.CheckUserInGroup')
7474

@@ -77,7 +77,7 @@ def get_parser(self, prog_name):
7777
parser.add_argument(
7878
'group',
7979
metavar='<group>',
80-
help='Group to check if user belongs to (name or ID)',
80+
help='Group to check (name or ID)',
8181
)
8282
parser.add_argument(
8383
'user',
@@ -115,15 +115,18 @@ def get_parser(self, prog_name):
115115
parser.add_argument(
116116
'name',
117117
metavar='<group-name>',
118-
help='New group name')
119-
parser.add_argument(
120-
'--description',
121-
metavar='<description>',
122-
help='New group description')
118+
help='New group name',
119+
)
123120
parser.add_argument(
124121
'--domain',
125122
metavar='<domain>',
126-
help='References the domain ID or name which owns the group')
123+
help='Domain to contain new group (name or ID)',
124+
)
125+
parser.add_argument(
126+
'--description',
127+
metavar='<description>',
128+
help='New group description',
129+
)
127130
parser.add_argument(
128131
'--or-show',
129132
action='store_true',
@@ -173,7 +176,7 @@ def get_parser(self, prog_name):
173176
parser.add_argument(
174177
'--domain',
175178
metavar='<domain>',
176-
help='Domain where group resides (name or ID)',
179+
help='Domain containing group(s) (name or ID)',
177180
)
178181
return parser
179182

@@ -211,7 +214,7 @@ def get_parser(self, prog_name):
211214
parser.add_argument(
212215
'--user',
213216
metavar='<user>',
214-
help='List group memberships for <user> (name or ID)',
217+
help='Filter group list by <user> (name or ID)',
215218
)
216219
parser.add_argument(
217220
'--long',
@@ -259,7 +262,7 @@ def take_action(self, parsed_args):
259262

260263

261264
class RemoveUserFromGroup(command.Command):
262-
"""Remove user to group"""
265+
"""Remove user from group"""
263266

264267
log = logging.getLogger(__name__ + '.RemoveUserFromGroup')
265268

@@ -268,12 +271,12 @@ def get_parser(self, prog_name):
268271
parser.add_argument(
269272
'group',
270273
metavar='<group>',
271-
help='Group that user will be removed from (name or ID)',
274+
help='Group containing <user> (name or ID)',
272275
)
273276
parser.add_argument(
274277
'user',
275278
metavar='<user>',
276-
help='User to remove from group (name or ID)',
279+
help='User to remove from <group> (name or ID)',
277280
)
278281
return parser
279282

@@ -314,7 +317,7 @@ def get_parser(self, prog_name):
314317
parser.add_argument(
315318
'--domain',
316319
metavar='<domain>',
317-
help='New domain that will now own the group (name or ID)')
320+
help='New domain to contain <group> (name or ID)')
318321
parser.add_argument(
319322
'--description',
320323
metavar='<description>',
@@ -341,7 +344,7 @@ def take_action(self, parsed_args):
341344

342345

343346
class ShowGroup(show.ShowOne):
344-
"""Show group details"""
347+
"""Display group details"""
345348

346349
log = logging.getLogger(__name__ + '.ShowGroup')
347350

@@ -355,7 +358,7 @@ def get_parser(self, prog_name):
355358
parser.add_argument(
356359
'--domain',
357360
metavar='<domain>',
358-
help='Domain where group resides (name or ID)',
361+
help='Domain containing <group> (name or ID)',
359362
)
360363
return parser
361364

0 commit comments

Comments
 (0)