Skip to content

Commit 58583b5

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Fix PEP8 E265 errors"
2 parents 63b1c06 + 11f3654 commit 58583b5

6 files changed

Lines changed: 4 additions & 19 deletions

File tree

‎openstackclient/common/restapi.py‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -251,16 +251,6 @@ def list(self, url, data=None, response_key=None, **kwargs):
251251
else:
252252
return response.json()
253253

254-
###hack this for keystone!!!
255-
#data = body[response_key]
256-
# NOTE(ja): keystone returns values as list as {'values': [ ... ]}
257-
# unlike other services which just return the list...
258-
#if isinstance(data, dict):
259-
# try:
260-
# data = data['values']
261-
# except KeyError:
262-
# pass
263-
264254
def set(self, url, data=None, response_key=None, **kwargs):
265255
"""Update an object via a PUT request
266256

‎openstackclient/compute/v2/server.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -693,7 +693,7 @@ def take_action(self, parsed_args):
693693
if utils.wait_for_status(
694694
compute_client.servers.get,
695695
server.id,
696-
#callback=_show_progress,
696+
callback=_show_progress,
697697
):
698698
sys.stdout.write('Complete\n')
699699
else:

‎openstackclient/tests/common/test_restapi.py‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,10 +137,6 @@ def test_request_get_auth(self, session_mock):
137137
user_agent=fake_user_agent,
138138
)
139139
gopher = api.request('GET', fake_url)
140-
#session_mock.return_value.headers.setdefault.assert_called_with(
141-
# 'X-Auth-Token',
142-
# fake_auth,
143-
#)
144140
session_mock.return_value.request.assert_called_with(
145141
'GET',
146142
fake_url,

‎openstackclient/tests/identity/v3/fakes.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,8 @@
114114
'description': idp_description
115115
}
116116

117-
#Assignments
117+
# Assignments
118+
118119
ASSIGNMENT_WITH_PROJECT_ID_AND_USER_ID = {
119120
'scope': {'project': {'id': project_id}},
120121
'user': {'id': user_id},

‎openstackclient/tests/volume/v1/test_volume.py‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,6 @@ def test_volume_create_user_project_id(self):
220220
None,
221221
None,
222222
volume_fakes.volume_name,
223-
#volume_fakes.volume_description,
224223
None,
225224
None,
226225
identity_fakes.user_id,
@@ -296,7 +295,6 @@ def test_volume_create_user_project_name(self):
296295
None,
297296
None,
298297
volume_fakes.volume_name,
299-
#volume_fakes.volume_description,
300298
None,
301299
None,
302300
identity_fakes.user_id,

‎tox.ini‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,6 @@ commands=
2828
python setup.py build_sphinx
2929

3030
[flake8]
31-
ignore = E126,E202,W602,H302,H402,E265,H305,H307,H904
31+
ignore = E126,E202,W602,H302,H402,H305,H307,H904
3232
show-source = True
3333
exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools

0 commit comments

Comments
 (0)