Skip to content

Commit 68e10e0

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Move setup_servers_mock() to class TestServer."
2 parents a2047d3 + bf657ef commit 68e10e0

1 file changed

Lines changed: 13 additions & 23 deletions

File tree

‎openstackclient/tests/compute/v2/test_server.py‎

Lines changed: 13 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,19 @@ def setUp(self):
5252
self.volumes_mock = self.app.client_manager.volume.volumes
5353
self.volumes_mock.reset_mock()
5454

55+
# Set object methods to be tested. Could be overwriten in subclass.
56+
self.methods = {}
57+
58+
def setup_servers_mock(self, count):
59+
servers = compute_fakes.FakeServer.create_servers(methods=self.methods,
60+
count=count)
61+
62+
# This is the return value for utils.find_resource()
63+
self.servers_mock.get = compute_fakes.FakeServer.get_servers(servers,
64+
0)
65+
66+
return servers
67+
5568

5669
class TestServerCreate(TestServer):
5770

@@ -569,18 +582,6 @@ def setUp(self):
569582
'pause': None,
570583
}
571584

572-
def setup_servers_mock(self, count=1):
573-
servers = compute_fakes.FakeServer.create_servers(
574-
methods=self.methods,
575-
count=count)
576-
577-
# This is the return value for utils.find_resource()
578-
self.servers_mock.get = compute_fakes.FakeServer.get_servers(
579-
servers,
580-
1)
581-
582-
return servers
583-
584585
def test_server_pause_one_server(self):
585586
servers = self.setup_servers_mock(1)
586587

@@ -809,17 +810,6 @@ def setUp(self):
809810
'shelve': None,
810811
}
811812

812-
def setup_servers_mock(self, count=1):
813-
servers = compute_fakes.FakeServer.create_servers(
814-
methods=self.methods,
815-
count=count)
816-
817-
self.servers_mock.get = compute_fakes.FakeServer.get_servers(
818-
servers,
819-
1)
820-
821-
return servers
822-
823813
def test_shelve_one_server(self):
824814
server = self.setup_servers_mock(1)[0]
825815

0 commit comments

Comments
 (0)