Skip to content

Commit 9c95b37

Browse files
jiaxiSteve Martinelli
authored andcommitted
--property should be required in os unset commands
The three commands below openstack volume unset openstack snapshot unset openstack volume type unset Should have --property as a required argument, not optional. The reason is the command will not work without --property. Closes-Bug: #1475872 Change-Id: Ib9e29392472db38982cc2817af2dd5055f5a01ca
1 parent b08dd6f commit 9c95b37

3 files changed

Lines changed: 3 additions & 0 deletions

File tree

‎openstackclient/volume/v1/snapshot.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,7 @@ def get_parser(self, prog_name):
263263
default=[],
264264
help='Property to remove from snapshot '
265265
'(repeat to remove multiple values)',
266+
required=True,
266267
)
267268
return parser
268269

‎openstackclient/volume/v1/type.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ def get_parser(self, prog_name):
166166
default=[],
167167
help='Property to remove from volume type '
168168
'(repeat option to remove multiple properties)',
169+
required=True,
169170
)
170171
return parser
171172

‎openstackclient/volume/v1/volume.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -437,6 +437,7 @@ def get_parser(self, prog_name):
437437
default=[],
438438
help='Property to remove from volume '
439439
'(repeat option to remove multiple properties)',
440+
required=True,
440441
)
441442
return parser
442443

0 commit comments

Comments
 (0)