Skip to content

Commit d972b83

Browse files
author
Steve Martinelli
committed
Pass in domain and project as positional args, not kwargs
The signature for users.set in keystoneclient dictates that domain and project be sent in, not domainId and projectId, which are being incorrectly sent in as 'extra' data. Closes-Bug: #1376833 Change-Id: I44df3e492f61eab2241f3758dee622417bb6f399
1 parent 31018bf commit d972b83

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎openstackclient/identity/v3/user.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -308,11 +308,11 @@ def take_action(self, parsed_args):
308308
if parsed_args.project:
309309
project_id = utils.find_resource(
310310
identity_client.projects, parsed_args.project).id
311-
kwargs['projectId'] = project_id
311+
kwargs['project'] = project_id
312312
if parsed_args.domain:
313313
domain_id = utils.find_resource(
314314
identity_client.domains, parsed_args.domain).id
315-
kwargs['domainId'] = domain_id
315+
kwargs['domain'] = domain_id
316316
kwargs['enabled'] = user.enabled
317317
if parsed_args.enable:
318318
kwargs['enabled'] = True

‎openstackclient/tests/identity/v3/test_user.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -842,7 +842,7 @@ def test_user_set_domain(self):
842842
# Set expected values
843843
kwargs = {
844844
'enabled': True,
845-
'domainId': identity_fakes.domain_id,
845+
'domain': identity_fakes.domain_id,
846846
}
847847
# UserManager.update(user, name=, domain=, project=, password=,
848848
# email=, description=, enabled=, default_project=)
@@ -874,7 +874,7 @@ def test_user_set_project(self):
874874
# Set expected values
875875
kwargs = {
876876
'enabled': True,
877-
'projectId': identity_fakes.project_id,
877+
'project': identity_fakes.project_id,
878878
}
879879
# UserManager.update(user, name=, domain=, project=, password=,
880880
# email=, description=, enabled=, default_project=)

0 commit comments

Comments
 (0)