Merge "Alphabetize tests for v1 qos_specs"

Author: Jenkins

openstackclient/tests/volume/v1/test_qos_specs.py

@@ -32,6 +32,41 @@ def setUp(self):
         self.types_mock.reset_mock()
 
 
+class TestQosAssociate(TestQos):
+    def setUp(self):
+        super(TestQosAssociate, self).setUp()
+
+        # Get the command object to test
+        self.cmd = qos_specs.AssociateQos(self.app, None)
+
+    def test_qos_associate(self):
+        self.qos_mock.get.return_value = fakes.FakeResource(
+            None,
+            copy.deepcopy(volume_fakes.QOS),
+            loaded=True
+        )
+        self.types_mock.get.return_value = fakes.FakeResource(
+            None,
+            copy.deepcopy(volume_fakes.TYPE),
+            loaded=True
+        )
+        arglist = [
+            volume_fakes.qos_id,
+            volume_fakes.type_id
+        ]
+        verifylist = [
+            ('qos_specs', volume_fakes.qos_id),
+            ('volume_type', volume_fakes.type_id)
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
+        self.cmd.take_action(parsed_args)
+        self.qos_mock.associate.assert_called_with(
+            volume_fakes.qos_id,
+            volume_fakes.type_id
+        )
+
+
 class TestQosCreate(TestQos):
     def setUp(self):
         super(TestQosCreate, self).setUp()
@@ -196,153 +231,118 @@ def test_qos_delete_with_name(self):
         self.qos_mock.delete.assert_called_with(volume_fakes.qos_id)
 
 
-class TestQosSet(TestQos):
+class TestQosDisassociate(TestQos):
     def setUp(self):
-        super(TestQosSet, self).setUp()
+        super(TestQosDisassociate, self).setUp()
 
         # Get the command object to test
-        self.cmd = qos_specs.SetQos(self.app, None)
+        self.cmd = qos_specs.DisassociateQos(self.app, None)
 
-    def test_qos_set_with_properties_with_id(self):
+    def test_qos_disassociate_with_volume_type(self):
         self.qos_mock.get.return_value = fakes.FakeResource(
             None,
-            copy.deepcopy(volume_fakes.QOS_WITH_SPECS),
+            copy.deepcopy(volume_fakes.QOS),
+            loaded=True
+        )
+        self.types_mock.get.return_value = fakes.FakeResource(
+            None,
+            copy.deepcopy(volume_fakes.TYPE),
             loaded=True
         )
         arglist = [
             volume_fakes.qos_id,
-            '--property', 'foo=bar',
-            '--property', 'iops=9001'
+            '--volume-type', volume_fakes.type_id
         ]
         verifylist = [
             ('qos_specs', volume_fakes.qos_id),
-            ('property', volume_fakes.qos_specs)
+            ('volume_type', volume_fakes.type_id)
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
         self.cmd.take_action(parsed_args)
-        self.qos_mock.set_keys.assert_called_with(
+        self.qos_mock.disassociate.assert_called_with(
             volume_fakes.qos_id,
-            volume_fakes.qos_specs
+            volume_fakes.type_id
         )
 
-
-class TestQosUnset(TestQos):
-    def setUp(self):
-        super(TestQosUnset, self).setUp()
-
-        # Get the command object to test
-        self.cmd = qos_specs.UnsetQos(self.app, None)
-
-    def test_qos_unset_with_properties(self):
+    def test_qos_disassociate_with_all_volume_types(self):
         self.qos_mock.get.return_value = fakes.FakeResource(
             None,
             copy.deepcopy(volume_fakes.QOS),
             loaded=True
         )
+
         arglist = [
             volume_fakes.qos_id,
-            '--property', 'iops',
-            '--property', 'foo'
+            '--all'
         ]
-
         verifylist = [
-            ('qos_specs', volume_fakes.qos_id),
-            ('property', ['iops', 'foo'])
+            ('qos_specs', volume_fakes.qos_id)
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
         self.cmd.take_action(parsed_args)
-        self.qos_mock.unset_keys.assert_called_with(
-            volume_fakes.qos_id,
-            ['iops', 'foo']
-        )
+        self.qos_mock.disassociate_all.assert_called_with(volume_fakes.qos_id)
 
 
-class TestQosAssociate(TestQos):
+class TestQosSet(TestQos):
     def setUp(self):
-        super(TestQosAssociate, self).setUp()
+        super(TestQosSet, self).setUp()
 
         # Get the command object to test
-        self.cmd = qos_specs.AssociateQos(self.app, None)
+        self.cmd = qos_specs.SetQos(self.app, None)
 
-    def test_qos_associate(self):
+    def test_qos_set_with_properties_with_id(self):
         self.qos_mock.get.return_value = fakes.FakeResource(
             None,
-            copy.deepcopy(volume_fakes.QOS),
-            loaded=True
-        )
-        self.types_mock.get.return_value = fakes.FakeResource(
-            None,
-            copy.deepcopy(volume_fakes.TYPE),
+            copy.deepcopy(volume_fakes.QOS_WITH_SPECS),
             loaded=True
         )
         arglist = [
             volume_fakes.qos_id,
-            volume_fakes.type_id
+            '--property', 'foo=bar',
+            '--property', 'iops=9001'
         ]
         verifylist = [
             ('qos_specs', volume_fakes.qos_id),
-            ('volume_type', volume_fakes.type_id)
+            ('property', volume_fakes.qos_specs)
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
         self.cmd.take_action(parsed_args)
-        self.qos_mock.associate.assert_called_with(
+        self.qos_mock.set_keys.assert_called_with(
             volume_fakes.qos_id,
-            volume_fakes.type_id
+            volume_fakes.qos_specs
         )
 
 
-class TestQosDisassociate(TestQos):
+class TestQosUnset(TestQos):
     def setUp(self):
-        super(TestQosDisassociate, self).setUp()
+        super(TestQosUnset, self).setUp()
 
         # Get the command object to test
-        self.cmd = qos_specs.DisassociateQos(self.app, None)
+        self.cmd = qos_specs.UnsetQos(self.app, None)
 
-    def test_qos_disassociate_with_volume_type(self):
+    def test_qos_unset_with_properties(self):
         self.qos_mock.get.return_value = fakes.FakeResource(
             None,
             copy.deepcopy(volume_fakes.QOS),
             loaded=True
         )
-        self.types_mock.get.return_value = fakes.FakeResource(
-            None,
-            copy.deepcopy(volume_fakes.TYPE),
-            loaded=True
-        )
         arglist = [
             volume_fakes.qos_id,
-            '--volume-type', volume_fakes.type_id
+            '--property', 'iops',
+            '--property', 'foo'
         ]
+
         verifylist = [
             ('qos_specs', volume_fakes.qos_id),
-            ('volume_type', volume_fakes.type_id)
+            ('property', ['iops', 'foo'])
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
         self.cmd.take_action(parsed_args)
-        self.qos_mock.disassociate.assert_called_with(
+        self.qos_mock.unset_keys.assert_called_with(
             volume_fakes.qos_id,
-            volume_fakes.type_id
-        )
-
-    def test_qos_disassociate_with_all_volume_types(self):
-        self.qos_mock.get.return_value = fakes.FakeResource(
-            None,
-            copy.deepcopy(volume_fakes.QOS),
-            loaded=True
+            ['iops', 'foo']
         )
-
-        arglist = [
-            volume_fakes.qos_id,
-            '--all'
-        ]
-        verifylist = [
-            ('qos_specs', volume_fakes.qos_id)
-        ]
-        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
-
-        self.cmd.take_action(parsed_args)
-        self.qos_mock.disassociate_all.assert_called_with(volume_fakes.qos_id)