Skip to content

Commit ff3dbdd

Browse files
Guojian ShaoSteve Martinelli
authored andcommitted
enhance tests for user v3
Change-Id: Ib17ba0cd71068ba8d7e7665160daf3ae0735971b Related-Bug: #1475357
1 parent 566987e commit ff3dbdd

3 files changed

Lines changed: 72 additions & 3 deletions

File tree

‎functional/tests/identity/v3/test_identity.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,12 +96,14 @@ def _create_dummy_user(self, add_clean_up=True):
9696
'user create '
9797
'--domain %(domain)s '
9898
'--project %(project)s '
99+
'--project-domain %(project_domain)s '
99100
'--password %(password)s '
100101
'--email %(email)s '
101102
'--description %(description)s '
102103
'--enable '
103104
'%(name)s' % {'domain': self.domain_name,
104105
'project': self.project_name,
106+
'project_domain': self.domain_name,
105107
'email': email,
106108
'password': password,
107109
'description': description,

‎functional/tests/identity/v3/test_user.py‎

Lines changed: 37 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,43 @@ def test_user_set(self):
5353
'--domain %(domain)s '
5454
'%(name)s' % {'domain': self.domain_name,
5555
'name': new_username})
56-
new_user = self.parse_show_as_object(raw_output)
57-
self.assertEqual(user['id'], new_user['id'])
58-
self.assertEqual(new_email, new_user['email'])
56+
updated_user = self.parse_show_as_object(raw_output)
57+
self.assertEqual(user['id'], updated_user['id'])
58+
self.assertEqual(new_email, updated_user['email'])
59+
60+
def test_user_set_default_project_id(self):
61+
username = self._create_dummy_user()
62+
project_name = self._create_dummy_project()
63+
# get original user details
64+
raw_output = self.openstack('user show '
65+
'--domain %(domain)s '
66+
'%(name)s' % {'domain': self.domain_name,
67+
'name': username})
68+
user = self.parse_show_as_object(raw_output)
69+
# update user
70+
raw_output = self.openstack('user set '
71+
'--project %(project)s '
72+
'--project-domain %(project_domain)s '
73+
'%(id)s' % {'project': project_name,
74+
'project_domain':
75+
self.domain_name,
76+
'id': user['id']})
77+
self.assertEqual(0, len(raw_output))
78+
# get updated user details
79+
raw_output = self.openstack('user show '
80+
'--domain %(domain)s '
81+
'%(name)s' % {'domain': self.domain_name,
82+
'name': username})
83+
updated_user = self.parse_show_as_object(raw_output)
84+
# get project details
85+
raw_output = self.openstack('project show '
86+
'--domain %(domain)s '
87+
'%(name)s' % {'domain': self.domain_name,
88+
'name': project_name})
89+
project = self.parse_show_as_object(raw_output)
90+
# check updated user details
91+
self.assertEqual(user['id'], updated_user['id'])
92+
self.assertEqual(project['id'], updated_user['default_project_id'])
5993

6094
def test_user_show(self):
6195
username = self._create_dummy_user()

‎openstackclient/tests/identity/v3/test_user.py‎

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -956,6 +956,39 @@ def test_user_set_project(self):
956956
**kwargs
957957
)
958958

959+
def test_user_set_project_domain(self):
960+
arglist = [
961+
'--project', identity_fakes.project_id,
962+
'--project-domain', identity_fakes.domain_id,
963+
identity_fakes.user_name,
964+
]
965+
verifylist = [
966+
('name', None),
967+
('password', None),
968+
('email', None),
969+
('project', identity_fakes.project_id),
970+
('project_domain', identity_fakes.domain_id),
971+
('enable', False),
972+
('disable', False),
973+
('user', identity_fakes.user_name),
974+
]
975+
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
976+
977+
# DisplayCommandBase.take_action() returns two tuples
978+
self.cmd.take_action(parsed_args)
979+
980+
# Set expected values
981+
kwargs = {
982+
'enabled': True,
983+
'default_project': identity_fakes.project_id,
984+
}
985+
# UserManager.update(user, name=, domain=, project=, password=,
986+
# email=, description=, enabled=, default_project=)
987+
self.users_mock.update.assert_called_with(
988+
identity_fakes.user_id,
989+
**kwargs
990+
)
991+
959992
def test_user_set_enable(self):
960993
arglist = [
961994
'--enable',

0 commit comments

Comments
 (0)