From 6925c7f64e45ef066af30d966773011a76c9cac7 Mon Sep 17 00:00:00 2001 From: Cameron DeCoster Date: Tue, 22 Sep 2026 07:22:24 -0600 Subject: [PATCH] fix: Use correct browser suffixes in constants --- src/choreographer/browser_async.py | 12 +++++------- src/choreographer/browsers/_chrome_constants.py | 4 ++-- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/choreographer/browser_async.py b/src/choreographer/browser_async.py index 70f25efc..ef134f3c 100644 --- a/src/choreographer/browser_async.py +++ b/src/choreographer/browser_async.py @@ -180,13 +180,11 @@ def run() -> subprocess.Popen[bytes] | subprocess.Popen[str]: # depends on args break except (BrowserClosedError, BrowserFailedError, asyncio.CancelledError) as e: raise BrowserFailedError( - "The browser seemed to close immediately after starting.", - "You can set the `logging.Logger` level lower to see more output.", - "You may try installing a known working copy of Chrome by running ", - "`$ choreo_get_chrome`." - "" - "It may be your browser auto-updated and will now work upon " - "restart. The browser we tried to start is located at " + "The browser seemed to close immediately after starting. " + "You can set the `logging.Logger` level lower to see more output. " + "You may try installing a known working copy of Chrome by running " + "`$ choreo_get_chrome`. It may be your browser auto-updated and will " + "now work upon restart. The browser we tried to start is located at " f"{self._browser_impl.path}.", ) from e diff --git a/src/choreographer/browsers/_chrome_constants.py b/src/choreographer/browsers/_chrome_constants.py index 17bbf8e8..0ba670cb 100644 --- a/src/choreographer/browsers/_chrome_constants.py +++ b/src/choreographer/browsers/_chrome_constants.py @@ -50,10 +50,10 @@ typical_edge_paths = tuple(_p + _edge_suffix for _p in _windows_app_dirs) _brave_suffix = r"\BraveSoftware\Brave-Browser\Application\brave.exe" - typical_brave_paths = tuple(_p + _edge_suffix for _p in _windows_app_dirs) + typical_brave_paths = tuple(_p + _brave_suffix for _p in _windows_app_dirs) _vivaldi_suffix = r"\Vivaldi\Application\vivaldi.exe" - typical_vivaldi_paths = tuple(_p + _brave_suffix for _p in _windows_app_dirs) + typical_vivaldi_paths = tuple(_p + _vivaldi_suffix for _p in _windows_app_dirs) elif platform.system() == "Linux": typical_chrome_paths = (