From 4f55242e5c83cef2f97b33937ecde4137514acb1 Mon Sep 17 00:00:00 2001 From: Savannah Ostrowski Date: Fri, 6 Nov 2026 14:07:45 -0800 Subject: [PATCH 1/2] Include machine and flags in benchmark artifact names --- bench_runner/templates/_benchmark.src.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bench_runner/templates/_benchmark.src.yml b/bench_runner/templates/_benchmark.src.yml index f97dee05..0a222538 100644 --- a/bench_runner/templates/_benchmark.src.yml +++ b/bench_runner/templates/_benchmark.src.yml @@ -89,7 +89,7 @@ jobs: - name: Upload artifacts uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.0 with: - name: benchmark + name: benchmark-${{ env.BENCHMARK_MACHINE_NICKNAME }}-${{ env.flags }} path: | benchmark.json overwrite: true @@ -131,7 +131,7 @@ jobs: if: ${{ !inputs.perf }} uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.0 with: - name: benchmark + name: benchmark-${{ env.BENCHMARK_MACHINE_NICKNAME }}-${{ env.flags }} path: | benchmark.json overwrite: true @@ -170,7 +170,7 @@ jobs: - name: Upload artifacts uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.0 with: - name: benchmark + name: benchmark-${{ env.BENCHMARK_MACHINE_NICKNAME }}-${{ env.flags }} path: | benchmark.json overwrite: true From 4ed93dbca45a59497a03f7e6f968553c2f2762e2 Mon Sep 17 00:00:00 2001 From: Savannah Ostrowski Date: Thu, 12 Nov 2026 16:12:46 -0800 Subject: [PATCH 2/2] Distinguish benchmark and perf artifacts by job execution --- bench_runner/templates/_benchmark.src.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/bench_runner/templates/_benchmark.src.yml b/bench_runner/templates/_benchmark.src.yml index 0a222538..dcda466a 100644 --- a/bench_runner/templates/_benchmark.src.yml +++ b/bench_runner/templates/_benchmark.src.yml @@ -89,7 +89,7 @@ jobs: - name: Upload artifacts uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.0 with: - name: benchmark-${{ env.BENCHMARK_MACHINE_NICKNAME }}-${{ env.flags }} + name: benchmark-${{ env.BENCHMARK_MACHINE_NICKNAME }}-${{ env.flags }}-${{ job.check_run_id }} path: | benchmark.json overwrite: true @@ -131,7 +131,7 @@ jobs: if: ${{ !inputs.perf }} uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.0 with: - name: benchmark-${{ env.BENCHMARK_MACHINE_NICKNAME }}-${{ env.flags }} + name: benchmark-${{ env.BENCHMARK_MACHINE_NICKNAME }}-${{ env.flags }}-${{ job.check_run_id }} path: | benchmark.json overwrite: true @@ -139,7 +139,7 @@ jobs: if: ${{ inputs.perf }} uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.0 with: - name: perf + name: perf-${{ env.BENCHMARK_MACHINE_NICKNAME }}-${{ env.flags }}-${{ job.check_run_id }} path: | profiling/results @@ -170,7 +170,7 @@ jobs: - name: Upload artifacts uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.0 with: - name: benchmark-${{ env.BENCHMARK_MACHINE_NICKNAME }}-${{ env.flags }} + name: benchmark-${{ env.BENCHMARK_MACHINE_NICKNAME }}-${{ env.flags }}-${{ job.check_run_id }} path: | benchmark.json overwrite: true