Skip to content

Commit 3779dcc

Browse files
committed
no need for threading_helper
1 parent 4fd2db9 commit 3779dcc

1 file changed

Lines changed: 4 additions & 11 deletions

File tree

‎Lib/test/test_external_inspection.py‎

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
from unittest.mock import ANY
1414
from test.support import (
1515
os_helper,
16-
threading_helper,
1716
SHORT_TIMEOUT,
1817
busy_retry,
1918
requires_gil_enabled,
@@ -3545,20 +3544,14 @@ def gen():
35453544
skip_non_matching_threads=True,
35463545
)
35473546

3548-
@unittest.skipIf(
3549-
sys.platform == "linux" and not PROCESS_VM_READV_SUPPORTED,
3550-
"Test only runs on Linux with process_vm_readv support",
3551-
)
3552-
@requires_gil_enabled()
3553-
@threading_helper.requires_working_threading()
3547+
@requires_gil_enabled("Free threaded builds don't have an 'active thread'")
35543548
def test_filtered_active_thread_is_not_replaced(self):
35553549
samples = []
35563550

35573551
def sample():
3558-
for kwargs in ({"all_threads": True},
3559-
{"only_active_thread": True}):
3552+
for kwargs in ({"all_threads": True}, {"only_active_thread": True}):
35603553
unwinder = RemoteUnwinder(
3561-
os.getpid(), mode=PROFILING_MODE_EXCEPTION, **kwargs,
3554+
os.getpid(), mode=PROFILING_MODE_EXCEPTION, **kwargs
35623555
)
35633556
samples.append(
35643557
self._get_thread_statuses(unwinder.get_stack_trace())
@@ -3569,7 +3562,7 @@ def sample():
35693562
raise ValueError
35703563
except ValueError:
35713564
thread.start()
3572-
threading_helper.join_thread(thread)
3565+
thread.join()
35733566

35743567
all_threads, active_thread = samples
35753568
self.assertEqual(list(all_threads), [threading.get_native_id()])

0 commit comments

Comments
 (0)