Skip to content

Commit ef1342e

Browse files
Apply Victor's suggestions
Co-authored-by: Victor Stinner <victor.stinner@gmail.com>
1 parent e51b518 commit ef1342e

4 files changed

Lines changed: 7 additions & 3 deletions

File tree

‎.github/workflows/reusable-san.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ jobs:
7272
- name: MSan option setup
7373
if: inputs.sanitizer == 'MSan'
7474
run: |
75-
echo "MSAN_OPTIONS=${SAN_LOG_OPTION} allocator_may_return_null=1" >> "$GITHUB_ENV"
75+
echo "MSAN_OPTIONS=${SAN_LOG_OPTION} allocator_may_return_null=1 handle_segv=0" >> "$GITHUB_ENV"
7676
# MSan reports false positives for memory initialized by libraries
7777
# that are not built with MSan, so disable modules that use them.
7878
# _remote_debugging links to libzstd directly, but we unpoision the memory.

‎Doc/using/configure.rst‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1026,6 +1026,10 @@ Debug options
10261026

10271027
Enable MemorySanitizer allocation error detector, ``msan`` (default is no).
10281028

1029+
MSan reports false positives for memory initialized by libraries that are
1030+
not built with MSan, so either build all dependencies with MSan or disable
1031+
the extension modules that use them in :file:`Modules/Setup.local`.
1032+
10291033
.. versionadded:: 3.6
10301034

10311035
.. option:: --with-undefined-behavior-sanitizer

‎configure‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎configure.ac‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4458,7 +4458,7 @@ int main(void)
44584458
{
44594459
return 2;
44604460
}
4461-
ffi_arg rc;
4461+
ffi_arg rc = 0;
44624462
ffi_call(&cif, FFI_FN(z_is_expected), &rc, values);
44634463
return !rc;
44644464
}

0 commit comments

Comments
 (0)