From 8d5505e46cb40a9190322ce96abc95ecc898a9d8 Mon Sep 17 00:00:00 2001 From: dhairya05 Date: Fri, 6 Nov 2026 21:09:32 +0530 Subject: [PATCH] [seaborn] Fix misspelled `orientation` default in `Plot.save`/`Plotter.save` Both `save` methods declared `orientation: str = "protrait"`. The keyword-only parameters on these methods mirror `matplotlib.backend_bases.FigureCanvasBase.print_figure`, whose `orientation` default is `"portrait"`. seaborn's runtime signature for both methods is `(self, loc, **kwargs)`, so stubtest cannot compare this default against the implementation and the typo went unnoticed. The value is still surfaced to users in IDE signature help and hover documentation. Co-Authored-By: Claude Opus 5 --- stubs/seaborn/seaborn/_core/plot.pyi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/stubs/seaborn/seaborn/_core/plot.pyi b/stubs/seaborn/seaborn/_core/plot.pyi index 8b8a5633dd44..0bfb8ee129e9 100644 --- a/stubs/seaborn/seaborn/_core/plot.pyi +++ b/stubs/seaborn/seaborn/_core/plot.pyi @@ -115,7 +115,7 @@ class Plot: dpi: float | None = 96, facecolor: ColorType | Literal["auto"] | None = ..., edgecolor: ColorType | Literal["auto"] | None = ..., - orientation: str = "protrait", + orientation: str = "portrait", format: str | None = None, bbox_inches: Literal["tight"] | Bbox | None = None, pad_inches: float | None = None, @@ -140,7 +140,7 @@ class Plotter: dpi: float | None = 96, facecolor: ColorType | Literal["auto"] | None = ..., edgecolor: ColorType | Literal["auto"] | None = ..., - orientation: str = "protrait", + orientation: str = "portrait", format: str | None = None, bbox_inches: Literal["tight"] | Bbox | None = None, pad_inches: float | None = None,