From eda43799ec14d01a44f62f47cf9fe799ce18ad93 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Mon, 14 Sep 2026 08:22:11 -0700 Subject: [PATCH] Separate formatting from lint in GitHub CI Summary: Give formatting its own GitHub CI step and preserve the same coverage in the aggregate `yarn test` command. This makes formatter failures independently visible before Metro becomes GitHub-first while leaving `yarn lint-fix` as the convenient combined fix command. ___ Differential Revision: D119662169 --- .github/workflows/build-test-and-deploy.yml | 3 ++- package.json | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-test-and-deploy.yml b/.github/workflows/build-test-and-deploy.yml index 0424ba9e47..4d1fb96d24 100644 --- a/.github/workflows/build-test-and-deploy.yml +++ b/.github/workflows/build-test-and-deploy.yml @@ -28,13 +28,14 @@ permissions: jobs: run-js-checks: runs-on: ubuntu-latest - name: "Type check, lint, smoke test" + name: "Type check, lint, format, smoke test" steps: - uses: actions/checkout@v7 - uses: ./.github/actions/yarn-install - run: yarn typecheck - run: yarn typecheck-ts - run: yarn lint + - run: yarn format-check - run: yarn test-smoke test-with-coverage: diff --git a/package.json b/package.json index ddeba5def1..aff489a3e6 100644 --- a/package.json +++ b/package.json @@ -56,11 +56,11 @@ "format": "prettier --write .", "format-check": "prettier --check .", "lint-fix": "eslint . --fix --cache && yarn format", - "lint": "eslint . --cache && yarn format-check", + "lint": "eslint . --cache", "postpublish": "npm run cleanup-release --workspaces --if-present", "publish": "yarn run build-clean && yarn run build && npm run prepare-release --workspaces --if-present && npm publish --workspaces", "start": "node packages/metro/src/cli", - "test": "yarn run typecheck && yarn run lint && yarn run build && yarn run jest", + "test": "yarn run typecheck && yarn run lint && yarn run format-check && yarn run build && yarn run jest", "test-coverage": "yarn run build && yarn run jest --coverage -i && node scripts/mapCoverage.js", "test-smoke": "yarn start build --config packages/metro/src/integration_tests/metro.config.js TestBundle.js --out /tmp/TestBundle", "typecheck": "flow check",