fix(mailchimp): reject empty tag and batch inputs instead of sending no-ops, keep numeric tag names, document the archive and permanent delete actions

Author: waleedlatif1

apps/docs/content/docs/integrations/mailchimp.mdx

@@ -14,9 +14,9 @@ Use [Mailchimp](https://mailchimp.com/) in Sim to manage audiences and members,
 
 ## Member removal
 
-**Delete Member from Mailchimp Audience** calls Mailchimp's reversible archive endpoint. **Archive Member from Mailchimp Audience** instead targets permanent deletion of identifying data, after which the member cannot be re-imported. These UI labels differ from the provider's terminology.
+**Delete Member from Mailchimp Audience** and **Archive Member from Mailchimp Audience** both call Mailchimp's reversible [archive endpoint](https://mailchimp.com/developer/marketing/api/list-members/archive-list-member); an archived member can be added back.
 
-The current permanent-deletion action sends `DELETE`, while [Mailchimp documents `POST` for delete-permanent](https://mailchimp.com/developer/marketing/api/lists/members/create-member-action-delete-permanent). Its compatibility is unverified; do not rely on it for deletion until the request method is corrected and tested.
+**Permanently Delete Member from Mailchimp Audience** calls [`POST .../actions/delete-permanent`](https://mailchimp.com/developer/marketing/api/list-member-actions/delete-list-member-permanently), which erases the member's identifying data. It cannot be undone, and the address cannot be re-imported.
 {/* MANUAL-CONTENT-END */}
 
 ## Use the block [#usage-instructions]

apps/sim/tools/mailchimp/create_batch_operation.ts

@@ -1,14 +1,11 @@
-import { createLogger } from '@sim/logger'
 import type { MailchimpBatchOperation } from '@/tools/mailchimp/types'
 import { buildMailchimpUrl, handleMailchimpError } from '@/tools/mailchimp/types'
 import { MAILCHIMP_CREDENTIAL_OAUTH } from '@/tools/shared/saved-credentials'
 import type { ToolConfig } from '@/tools/types'
 
-const logger = createLogger('MailchimpCreateBatchOperation')
-
 export interface MailchimpCreateBatchOperationParams {
   apiKey: string
-  operations: string
+  operations: string | unknown[]
 }
 
 export interface MailchimpCreateBatchOperationResponse {
@@ -54,14 +51,18 @@ export const mailchimpCreateBatchOperationTool: ToolConfig<
       'Content-Type': 'application/json',
     }),
     body: (params) => {
-      let operations = []
-      try {
-        operations = JSON.parse(params.operations)
-      } catch (error) {
-        logger.warn('Failed to parse operations', { error })
+      let operations: unknown = params.operations
+      if (typeof operations === 'string') {
+        try {
+          operations = JSON.parse(operations)
+        } catch {
+          throw new Error('Operations must be a JSON array of batch operations')
+        }
       }
 
-      if (!Array.isArray(operations)) return { operations }
+      if (!Array.isArray(operations)) {
+        throw new Error('Operations must be a JSON array of batch operations')
+      }
 
       return {
         operations: operations.map((operation: unknown) => {

apps/sim/tools/mailchimp/mailchimp.test.ts

@@ -89,6 +89,24 @@ describe('Mailchimp request bodies', () => {
     })
   })
 
+  it('keeps numeric tag names and rejects input with no tag names', () => {
+    const params = { apiKey, listId: 'list1', subscriberEmail: janeHash }
+    expect(bodyOf(mailchimpAddMemberTagsTool, { ...params, tags: '2024' })).toEqual({
+      tags: [{ name: '2024', status: 'active' }],
+    })
+    expect(() => bodyOf(mailchimpAddMemberTagsTool, { ...params, tags: '[]' })).toThrow()
+  })
+
+  it('accepts an already-parsed operations array and rejects unparseable operations', () => {
+    const operations = [{ method: 'GET', path: '/lists' }]
+    expect(bodyOf(mailchimpCreateBatchOperationTool, { apiKey, operations })).toEqual({
+      operations,
+    })
+    expect(() =>
+      bodyOf(mailchimpCreateBatchOperationTool, { apiKey, operations: 'not json' })
+    ).toThrow()
+  })
+
   it('serializes an object batch operation body to the JSON string Mailchimp requires', () => {
     const body = bodyOf(mailchimpCreateBatchOperationTool, {
       apiKey,

apps/sim/tools/mailchimp/types.ts

@@ -405,18 +405,25 @@ export function buildMemberTags(
     }
   }
   const items = Array.isArray(parsed) ? parsed : [parsed]
-  return items.flatMap((item) => {
-    if (typeof item === 'string') {
-      const name = item.trim()
+  const tags = items.flatMap((item) => {
+    if (typeof item === 'string' || typeof item === 'number' || typeof item === 'boolean') {
+      const name = String(item).trim()
       return name ? [{ name, status: defaultStatus }] : []
     }
     if (item && typeof item === 'object' && 'name' in item) {
       const tag = item as { name: unknown; status?: unknown }
+      const name =
+        typeof tag.name === 'string' || typeof tag.name === 'number' ? String(tag.name).trim() : ''
+      if (!name) return []
       const status = typeof tag.status === 'string' && tag.status ? tag.status : defaultStatus
-      return [{ name: String(tag.name), status }]
+      return [{ name, status }]
     }
     return []
   })
+  if (tags.length === 0) {
+    throw new Error('Tags must include at least one tag name')
+  }
+  return tags
 }
 
 // Helper function for consistent error handling