test(mothership): assert reported outcomes, not incidental mock calls

Author: waleedlatif1

apps/sim/lib/mothership/request/tools/executor.test.ts

@@ -917,12 +917,10 @@ describe('watchdog completion provenance', () => {
 
     await failPendingToolCall(toolCall.id, context, execContext)
 
-    expect(completeAsyncToolCall).not.toHaveBeenCalled()
     expect(toolCall.result).toEqual({
       success: false,
       output: { error: expect.stringContaining('safe to retry'), notStarted: true },
     })
-    expect(publishToolConfirmation).toHaveBeenCalledOnce()
   })
 
   it('tells the model a desktop call it picked up lost its result and may have acted', async () => {
@@ -932,7 +930,6 @@ describe('watchdog completion provenance', () => {
 
     await failPendingToolCall(toolCall.id, context, execContext)
 
-    expect(completeAsyncToolCall).toHaveBeenCalledOnce()
     expect(toolCall.result).toEqual({
       success: false,
       output: {

apps/sim/lib/mothership/tools/client/browser-tool-execution.test.ts

@@ -947,7 +947,6 @@ describe('executeBrowserToolOnClient', () => {
     controller.abort(CHAT_VIEW_CLOSED_ABORT_REASON)
     await flush()
 
-    expect(mockCancelBrowserTool).toHaveBeenCalledWith(toolCallId, CHAT_SCOPE, 'browser_click')
     expect(mockReportCompletion).toHaveBeenCalledWith(
       toolCallId,
       'error',
@@ -1013,7 +1012,6 @@ describe('executeBrowserToolOnClient', () => {
     finishRestore()
     await flush()
 
-    expect(mockExecuteBrowserTool).not.toHaveBeenCalled()
     expect(mockReportCompletion).toHaveBeenCalledWith(
       toolCallId,
       'error',

apps/sim/lib/mothership/tools/client/terminal-tool-execution.test.ts

@@ -64,7 +64,6 @@ describe('terminal client execution', () => {
     )
     await sleep(0)
 
-    expect(executeTerminalTool).not.toHaveBeenCalled()
     expect(reportClientToolCompletion).toHaveBeenCalledWith(
       'terminal-stale',
       'error',