improvement(audits): fail on unparsable files, refuse suppressed updates, require balanced dynamic segments

Author: waleedlatif1

knip.jsonc

@@ -4,8 +4,10 @@
   // Unused exports, types, and duplicates are ratcheted by check:unused-exports,
   // which reuses this config in the same knip pass.
   "include": ["files", "dependencies", "unlisted", "unresolved"],
-  // Package `exports`/`main`/`bin` targets are entries; their exports are public
-  // contracts (ts-sdk, emcn, cli, …), so knip must never report them as unused.
+  // knip's default, stated so it is a decision: no entry file's exports are reported.
+  // That keeps package `exports`/`main`/`bin` contracts (ts-sdk, emcn, cli, …) and framework
+  // entries (Next routes, Trigger tasks) public, and also exempts the other configured entries
+  // (scripts, `*.integration.ts`, `background/**`, desktop and SDK examples).
   "includeEntryExports": false,
   "workspaces": {
     ".": {

scripts/check-explicit-any.ts

@@ -68,7 +68,15 @@ function collect(): Baseline {
   const ruleToMetric = new Map<string, Metric>(
     Object.entries(METRICS).map(([metric, rule]) => [rule, metric as Metric])
   )
-  for (const line of result.stdout.toString().split('\n')) {
+  const lines = result.stdout.toString().split('\n')
+  // A file Biome cannot parse yields an undercount, so a parse error fails the audit outright.
+  const unparsable = lines.filter((line) => line.startsWith('::error title=parse,'))
+  if (unparsable.length) {
+    console.error(`✗ Biome could not parse ${unparsable.length} location(s); fix the syntax first:`)
+    for (const line of unparsable) console.error(`  ${line.replace(/^::error title=parse,/, '')}`)
+    process.exit(1)
+  }
+  for (const line of lines) {
     const match = /^::\w+ title=([^,]+),file=([^,]+),/.exec(line)
     const metric = match && ruleToMetric.get(match[1])
     if (!match || !metric) continue
@@ -131,7 +139,17 @@ function shrunkTo(after: Counts, before: Counts): Counts {
   )
 }
 
+const suppressed = suppressions()
+if (suppressed.length) {
+  console.error(
+    `✗ ${suppressed.length} biome-ignore comment(s) hide an \`any\` or \`!\` from this check:`
+  )
+  for (const line of suppressed) console.error(`  ${line}`)
+  console.error('  Delete the suppression and fix the type instead.\n')
+}
+
 if (process.argv.includes('--update')) {
+  if (suppressed.length) process.exit(1)
   const next: Baseline = {
     explicitAny: sorted(shrunkTo(current.explicitAny, baseline.explicitAny ?? {})),
     nonNullAssertion: sorted(shrunkTo(current.nonNullAssertion, baseline.nonNullAssertion ?? {})),
@@ -162,15 +180,6 @@ let stale = 0
 /** A vanished baselined file next to a new file with no more hits: likely a rename. */
 const renames = new Set<string>()
 
-const suppressed = suppressions()
-if (suppressed.length) {
-  console.error(
-    `✗ ${suppressed.length} biome-ignore comment(s) hide an \`any\` or \`!\` from this check:`
-  )
-  for (const line of suppressed) console.error(`  ${line}`)
-  console.error('  Delete the suppression and fix the type instead.\n')
-}
-
 for (const metric of Object.keys(METRICS) as Metric[]) {
   const before = baseline[metric] ?? {}
   const after = current[metric]

scripts/check-file-names.ts

@@ -45,7 +45,7 @@ const BASELINE = path.join(ROOT, 'scripts/check-file-names.baseline.json')
 const SOURCE_FILE = /\.(?:[cm]?[jt]sx?)$/
 const KEBAB = /^[a-z0-9]+(?:-[a-z0-9]+)*$/
 const KEBAB_OR_SNAKE = /^[a-z0-9]+(?:[-_][a-z0-9]+)*$/
-const NEXT_DYNAMIC = /^\[{1,2}(?:\.\.\.)?[A-Za-z][A-Za-z0-9]*\]{1,2}$/
+const NEXT_DYNAMIC = /^(?:\[(?:\.\.\.)?[A-Za-z][A-Za-z0-9]*\]|\[\[\.\.\.[A-Za-z][A-Za-z0-9]*\]\])$/
 const NEXT_GROUP = /^\([a-z0-9]+(?:-[a-z0-9]+)*\)$/
 const NEXT_INTERCEPT = /^(?:\(\.{1,3}\)|(?:\(\.\.\))+)[a-z0-9]+(?:-[a-z0-9]+)*$/
 const NEXT_SLOT = /^@[a-z0-9]+(?:-[a-z0-9]+)*$/