ci: keep the desktop live gate's skip-only-unrelated rule

Author: waleedlatif1

.github/scripts/desktop-live-changes.sh

@@ -1,30 +1,11 @@
 #!/usr/bin/env bash
-# Prints `changed=true` when a pull request touches a path the live desktop suite exercises, or when
-# the diff cannot be worked out, and `changed=false` otherwise.
-#
-# The suite (apps/desktop/e2e/desktop-tools-live-sim.spec.ts) drives the Electron app against a
-# local Sim, realtime and Redis through the desktop, mothership, copilot, upload and auth routes and
-# the chat page. A change that only breaks Sim boot or an unrelated route fails the build and e2e
-# jobs, and every staging and main push runs this suite regardless, so a path missing here can
-# delay a failure to the staging push but never lets it deploy.
+# Prints `changed=false` only when every file a pull request changes is clearly unrelated to the
+# live desktop suite, and `changed=true` otherwise, including when the diff cannot be worked out.
 #
 # Usage: desktop-live-changes.sh <base-sha>
 set -u
 
-relevant='^(apps/desktop/|apps/realtime/'\
-'|packages/(desktop-bridge|browser-protocol|terminal-protocol|realtime-protocol|db|auth|emcn|utils|logger|security|platform-authz|runtime-secrets)/'\
-'|apps/sim/lib/(desktop|mothership|uploads|auth|terminal|browser-agent|workspaces/permissions|api/(client|server))/'\
-'|apps/sim/lib/api/contracts/(chats|copilot|desktop-|mothership-|upload-sessions|workspace-file)'\
-'|apps/sim/app/api/(desktop|mothership|copilot|files|v2/uploads|auth|users/me)/'\
-'|apps/sim/app/api/workspaces/\[id\]/files/'\
-'|apps/sim/app/workspace/\[workspaceId\]/(home/|chat/|components/|layout\.tsx)'\
-'|apps/sim/app/(layout\.tsx|desktop/)'\
-'|apps/sim/stores/(chat|chat-panel|panel|mothership-[a-z-]+|tool-permission|terminal|copilot-terminal|browser-session)/'\
-'|apps/sim/hooks/(use-mothership|use-desktop|use-chat|queries/(mothership|desktop|copilot|chats))'\
-'|apps/sim/types/sim-desktop'\
-'|apps/sim/(proxy\.ts|next\.config\.ts|package\.json|instrumentation)'\
-'|bun\.lock$|package\.json$'\
-'|\.github/(workflows/(checks|ci)\.yml|scripts/desktop-live-changes\.sh|actions/))'
+unrelated='^(apps/docs/|apps/pii/|apps/sim/content/|packages/(python-sdk|ts-sdk)/)|\.mdx?$|(^|/)LICENSE$'
 
 base=${1:-}
 run() {
@@ -36,7 +17,8 @@ run() {
 git fetch --quiet --depth=1 origin "$base" || run "could not fetch $base"
 names=$(git diff --no-renames --name-only "$base" HEAD) || run "could not diff against $base"
 [ -n "$names" ] || run 'no changed files listed'
-printf 'Changed files:\n%s\n' "$names" >&2
-match=$(printf '%s\n' "$names" | grep -E -m 1 "$relevant") && run "a change touches a path it exercises: $match"
+if printf '%s\n' "$names" | grep -qvE "$unrelated"; then
+  run 'a change may affect it'
+fi
 echo "changed=false"
-echo 'Skipping the live desktop suite: no change touches a path it exercises' >&2
+echo 'Skipping the live desktop suite: every change is unrelated to it' >&2

.github/workflows/checks.yml

@@ -224,9 +224,9 @@ jobs:
           if-no-files-found: ignore
           retention-days: 7
 
-  # Pull requests run the live desktop suite only when they touch a path it exercises (listed in
-  # desktop-live-changes.sh), or when the diff cannot be worked out. Pushes always run it, so a
-  # pull request that skipped it wrongly would first fail on staging, before anything deploys.
+  # Pull requests skip the live desktop suite only when every change is clearly unrelated to the
+  # app it drives (docs, other apps, published content). Anything else, and any failure to work
+  # out the diff, runs it: a pull request that skipped it wrongly would first fail on staging.
   desktop-changes:
     name: desktop-changes
     runs-on: &runner-2vcpu ${{ (vars.CI_PROVIDER == '' || vars.CI_PROVIDER == 'blacksmith') && 'blacksmith-2vcpu-ubuntu-2404' || 'ubuntu-latest' }}

scripts/desktop-live-changes.test.ts

@@ -19,7 +19,7 @@ function write(repo: string, file: string, content: string) {
   writeFileSync(join(repo, file), content)
 }
 
-/** Builds a clone whose base commit holds `apps/desktop/x.ts` and whose origin is a local bare repo. */
+/** Builds a clone whose base commit holds `apps/sim/x.ts` and whose origin is a local bare repo. */
 function fixture() {
   const root = mkdtempSync(join(tmpdir(), 'desktop-live-changes-'))
   fixtures.push(root)
@@ -31,7 +31,7 @@ function fixture() {
   git(repo, 'config', 'user.name', 'Test')
   git(repo, 'config', 'commit.gpgsign', 'false')
   git(repo, 'remote', 'add', 'origin', origin)
-  write(repo, 'apps/desktop/x.ts', 'export const x = 1\n'.repeat(20))
+  write(repo, 'apps/sim/x.ts', 'export const x = 1\n'.repeat(20))
   git(repo, 'add', '-A')
   git(repo, 'commit', '--quiet', '-m', 'base')
   const base = git(repo, 'rev-parse', 'HEAD')
@@ -51,7 +51,7 @@ describe('desktop live change gate', () => {
   it('runs the suite when a live file moves into a skipped path', () => {
     const { repo, base } = fixture()
     mkdirSync(join(repo, 'apps/docs'), { recursive: true })
-    git(repo, 'mv', 'apps/desktop/x.ts', 'apps/docs/x.ts')
+    git(repo, 'mv', 'apps/sim/x.ts', 'apps/docs/x.ts')
     git(repo, 'commit', '--quiet', '-m', 'move')
 
     const result = detect(repo, base)
@@ -70,28 +70,6 @@ describe('desktop live change gate', () => {
     expect(result.stdout.trim()).toBe('changed=false')
   })
 
-  it('skips the suite when an app change is outside every path it exercises', () => {
-    const { repo, base } = fixture()
-    write(repo, 'apps/sim/app/api/schedules/execute/route.ts', 'export const GET = () => null\n')
-    git(repo, 'add', '-A')
-    git(repo, 'commit', '--quiet', '-m', 'schedules')
-
-    const result = detect(repo, base)
-    expect(result.status, result.stderr).toBe(0)
-    expect(result.stdout.trim()).toBe('changed=false')
-  })
-
-  it('runs the suite when a change touches the chat page', () => {
-    const { repo, base } = fixture()
-    write(repo, 'apps/sim/app/workspace/[workspaceId]/home/page.tsx', 'export default null\n')
-    git(repo, 'add', '-A')
-    git(repo, 'commit', '--quiet', '-m', 'chat page')
-
-    const result = detect(repo, base)
-    expect(result.status, result.stderr).toBe(0)
-    expect(result.stdout.trim()).toBe('changed=true')
-  })
-
   it('runs the suite when the base commit cannot be fetched', () => {
     const { repo } = fixture()
     const result = detect(repo, '0'.repeat(40))