Repository navigation
Commit 102019b
authored
test(desktop): stop the agent's terminal commands in the real app, with real shells and real tmux (#8733)
* test(desktop): stop the agent's terminal commands in the real app, with real shells and real tmux
An Electron suite for terminal cancel, which ships without a feature flag:
Stop, sign-out (by the web app's logout and by the session cookie going away),
switching Terminal off, the launch after an interrupted sign-out or a crash,
and untracked runs on tmux without pane options. It asserts what is running
and which panes exist, never which calls were made.
- Agent and user commands ignore SIGHUP, SIGINT and SIGTERM, so only Sim's own
stop can end them and a stray stop would show; each launch gets its own tmux
server, and every process name carries a per-run suffix.
- The fixture Sim and its helpers move to e2e/executor-sim.ts, shared with the
background executor suite.
- The macOS E2E job installs tmux so the tmux scenarios run in CI; elsewhere
they skip when tmux is missing.
* test(desktop): draw the run nonce from the shared random helpers, and keep the lease constant private
* test(desktop): attach terminal-cancel diagnostics instead of printing them, write a suite report, and keep the user pane through a session ended elsewhere
* test(desktop): add each terminal-cancel check to the report as it finishes, so a retry keeps the original failure1 parent 8f617da commit 102019b
4 files changed
Lines changed: 1181 additions & 500 deletions
File tree
- .github/workflows
- apps/desktop/e2e
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
84 | 88 | | |
85 | 89 | | |
86 | 90 | | |
87 | 91 | | |
88 | 92 | | |
| 93 | + | |
89 | 94 | | |
90 | 95 | | |
91 | 96 | | |
| |||
0 commit comments